Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 12:10:49 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Markus Stockhausen <markus.stockhausen@gmx.de>
Cc:     linux-crypto@vger.kernel.org
Subject: Re: [PATCH 0/6] crypto/realtek: add new driver
Message-ID: <Y47AycWFkn48EvL5@gondor.apana.org.au>
References: <20221013184026.63826-1-markus.stockhausen@gmx.de>
 <fe7800282ff11f7822778eb9109864f1f3b144f2.camel@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fe7800282ff11f7822778eb9109864f1f3b144f2.camel@gmx.de>
Precedence: bulk

On Mon, Dec 05, 2022 at 07:47:59PM +0100, Markus Stockhausen wrote:
>
> as I got neither positive nor negative feedback after your last
> question I just want to ask if there is any work for me to do on this
> series?

Sorry about that.

There is still an issue with your import function.  You dereference
the imported state directly.  That is not allowed because there is
no guarantee that the imported state is aligned for a direct CPU
load.

So you'll either need to copy it somewhere first or use an unaligned
load to access hexp->state.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt