Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 17:07:08 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Markus Stockhausen <markus.stockhausen@gmx.de>
Cc:     linux-crypto@vger.kernel.org
Subject: Re: [PATCH 0/6] crypto/realtek: add new driver
Message-ID: <Y48GPMnLd12AKj0B@gondor.apana.org.au>
References: <20221013184026.63826-1-markus.stockhausen@gmx.de>
 <fe7800282ff11f7822778eb9109864f1f3b144f2.camel@gmx.de>
 <Y47AycWFkn48EvL5@gondor.apana.org.au>
 <c5fcd63053fb117582fc8788e276fa5d6ffd3e78.camel@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c5fcd63053fb117582fc8788e276fa5d6ffd3e78.camel@gmx.de>
Precedence: bulk

On Tue, Dec 06, 2022 at 09:59:49AM +0100, Markus Stockhausen wrote:
>
> 	const struct rtcr_ahash_req *hexp = in;
> 
> 	hreq->state = hexp->state; << *** maybe unaligned? ***

Try

	const struct rctr_ahash_req __packed *hexp = in;

This should tell the compiler to use unaligned accessors.

> Comparing this to safeexcel_ahash_import() where I got my ideas from
> one sees a similar coding:
> 
> 	...
> 	const struct safexcel_ahash_export_state *export = in;

This is equally broken unless that driver can only be used on
platforms where unaligned access is legal (such as x86).

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt