Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Dec 2022 19:07:48 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Gaosheng Cui <cuigaosheng1@huawei.com>
Cc:     davem@davemloft.net, james.hartley@imgtec.com,
        abrestic@chromium.org, will.thomas@imgtec.com,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: img-hash - Fix variable dereferenced before
 check 'hdev->req'
Message-ID: <Y5MXBMkmckXyvyGG@gondor.apana.org.au>
References: <20221201062526.4089-1-cuigaosheng1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221201062526.4089-1-cuigaosheng1@huawei.com>
Precedence: bulk

On Thu, Dec 01, 2022 at 02:25:26PM +0800, Gaosheng Cui wrote:
> Smatch report warning as follows:
> 
> drivers/crypto/img-hash.c:366 img_hash_dma_task() warn: variable
> dereferenced before check 'hdev->req'
> 
> Variable dereferenced should be done after check 'hdev->req',
> fix it.
> 
> Fixes: d358f1abbf71 ("crypto: img-hash - Add Imagination Technologies hw hash accelerator")
> Fixes: 10badea259fa ("crypto: img-hash - Fix null pointer exception")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  drivers/crypto/img-hash.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt