Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2521423rwb; Fri, 9 Dec 2022 03:15:33 -0800 (PST) X-Google-Smtp-Source: AA0mqf4qm/2wKxX04I+s6sQLPKKspRC/gwI2/1e/1YZarjct97DEhgIfEuDWY9yP5j4PmcfiKosV X-Received: by 2002:a05:6402:c43:b0:468:38e5:f233 with SMTP id cs3-20020a0564020c4300b0046838e5f233mr5547736edb.24.1670584533502; Fri, 09 Dec 2022 03:15:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670584533; cv=none; d=google.com; s=arc-20160816; b=jlT3aunJAZ4x7j3XhamPVwC5fC4bLGXD4MQ3GmkcQh+tNr2XY42QizZsVYE8PQdAsV RthjqZO0VKAbHToAz0huPHTSa1cIYWd5XzHZAWDMxQo4TvKjw3ZKRSszJ4ML6F5IpzBs x7xAGDEsAWZfL9YFzlkr03uDr0k0MmQX5smDBsWFgjYkP8GjsNVKnS8O/qV+sjQKpmBz Xee7QeVCunNx/diNYJcekrEDUfO2VRNEAB4f9qvuFClGnWN8a8wNgO78HQ1wySKdhCPk qDM2gLy1SqqZpesvSWNBNonZOpD3zEqhCEpACKqLzyeZtG7MdzDjlbEVE94KRla84YQ8 NB/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=gsCPXN3/vIR1C7EIeCOeP9CdpvYH3gzG8qAYWyUnZ4M=; b=TGvGJpQPrPfwMb1Gca4j2TJPMI8xsTZf/J2ZlZKqpFhCxKoyC/69tD1N6bOZ1RlHuh qeZLdgc7onMQmYK8B/FxjgNq7DyEH6lEOxCWie+DWgKBavfP66JDLES34s+1wffJRM1s tfpX1o4MU50gSm/iUx1yVxKy4Y5CCMWuD4XD2tEOIfTMr9uimxvAT7cpyhSvkinTdlpB WFVW3RmFsaKaYrWjVDyhGvBFxgX1MWNBmJ3X4raMqa3QTNk1rvTL+o819kjBWE0yLjY9 aXqIR8W/DDRxxei/l4TsHTBJXQFuRC/Yme4w5MPpt9N5D2JAaiuzHwdXvj1GJi/TY/Ru z+1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g22-20020a50ee16000000b0046eff871047si130332eds.366.2022.12.09.03.15.09; Fri, 09 Dec 2022 03:15:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229571AbiLILHT (ORCPT + 99 others); Fri, 9 Dec 2022 06:07:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbiLILHS (ORCPT ); Fri, 9 Dec 2022 06:07:18 -0500 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B88E14D5FA for ; Fri, 9 Dec 2022 03:07:17 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1p3bDl-005gjX-7g; Fri, 09 Dec 2022 19:07:14 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 09 Dec 2022 19:07:13 +0800 Date: Fri, 9 Dec 2022 19:07:13 +0800 From: Herbert Xu To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, keescook@chromium.org, ebiggers@kernel.org Subject: Re: [PATCH 0/4] crypto: arm64 - use frame_push/pop macros Message-ID: References: <20221129164852.2051561-1-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221129164852.2051561-1-ardb@kernel.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Nov 29, 2022 at 05:48:48PM +0100, Ard Biesheuvel wrote: > We have a pair of macros on arm64 that can be used in asm code to set up > and tear down the stack frame when implementing a non-leaf function. > > We will be adding support for shadow call stack and pointer > authentication to those macros, so that the code in question is less > likely to be abused for someone's ROP/JOP enjoyment. So let's fix the > existing crypto code to use those macros where they should be used. > > Ard Biesheuvel (4): > crypto: arm64/aes-neonbs - use frame_push/pop consistently > crypto: arm64/aes-modes - use frame_push/pop macros consistently > crypto: arm64/crct10dif - use frame_push/pop macros consistently > crypto: arm64/ghash-ce - use frame_push/pop macros consistently > > arch/arm64/crypto/aes-modes.S | 34 +++++++------------- > arch/arm64/crypto/aes-neonbs-core.S | 16 ++++----- > arch/arm64/crypto/crct10dif-ce-core.S | 5 ++- > arch/arm64/crypto/ghash-ce-core.S | 8 ++--- > 4 files changed, 24 insertions(+), 39 deletions(-) > > -- > 2.35.1 All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt