Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     Taehee Yoo <ap420073@gmail.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "x86@kernel.org" <x86@kernel.org>
CC:     "jussi.kivilinna@iki.fi" <jussi.kivilinna@iki.fi>,
        "ebiggers@kernel.org" <ebiggers@kernel.org>
Subject: RE: [PATCH v7 3/4] crypto: aria: implement aria-avx2
Thread-Topic: [PATCH v7 3/4] crypto: aria: implement aria-avx2
Thread-Index: AQHZCkQw/pdq4Hz77EaYUz9M1f3PSa5l72Tg
Date:   Fri, 9 Dec 2022 19:16:01 +0000
Message-ID: <MW5PR84MB1842C9F4CAC5511B977439DBAB1C9@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20221207135855.459181-1-ap420073@gmail.com>
 <20221207135855.459181-4-ap420073@gmail.com>
In-Reply-To: <20221207135855.459181-4-ap420073@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0pVWwN6vOLKNrJupmHJrWPuY1H+UnLvemn5HGrm0RqG2ddtPE6E40BU6jNAj?=
 =?us-ascii?Q?GdIFr5slrElWzVesdzHk4EPYX8yrjM0F6i4R0Q2v/w96axIOxjC0u60nV4oV?=
 =?us-ascii?Q?b/bVSLJqSHbBW72eLx7mi46vc9CxWiynOgB4FnBQzg2hYqDcz+AT1tZLLBNZ?=
 =?us-ascii?Q?v9TDN5jt+J5gRTk7HpzGPF8BQIz3yH8eWyVbl+S5tuEha4kupCu51O0QxYZT?=
 =?us-ascii?Q?oFv0b8qdnI7MK7pLGbwgXMDDVzTem4Zxk1EwY6TuwcBx6iPTKowX6qdvrhHh?=
 =?us-ascii?Q?0sprEI8NDrtXETYkQNWbVPabqIPKtXhaZn7wCYtlu4PQcb0Ej8O2ZmV9uRDN?=
 =?us-ascii?Q?ifuvoM24i6/3ZK4oGnO3HjDYkeFy7HWKUqJnlHFj+vvPaF4amuO/tskdPSi7?=
 =?us-ascii?Q?EPcN1xjaC/jdO9rPSCSirtIYgmNxvUzqSsIQKHf1wrLTi6zzsd35cQg8zJRV?=
 =?us-ascii?Q?jSw2jiVxmQUyYnFdDFfkWW+ybGcEL6WOHeUKu9rV6k0NjCGo/mNye7WfxWgw?=
 =?us-ascii?Q?XHFLvjkaXFD0q9bAI3JOPOk4sIDlag0PRax+UbmtwfYKHJNW4KuUy4CoFOBi?=
 =?us-ascii?Q?NUPCSMLZ2GYFHTbKAci+JNvncLzRlQVObdDs2lMvMNCF9DjkBkLbeD+P7s0t?=
 =?us-ascii?Q?sctg4PHRykegS/TRHjlHvTsyvYPqqjwE2ZAWVPY71clyPJ7wuzLl59BkteC3?=
 =?us-ascii?Q?V8ycr/N0y6BrQ+iVhpVVS8aLRz//P1BUC9MZ7LWMQwfE+9c1XKWjvnHihCXx?=
 =?us-ascii?Q?oLoNOl97avh3082ZgcpMI7uHSjNxG36sA0twf0EtAE1Qc22DzrCGIy/Oszlu?=
 =?us-ascii?Q?gtpxXL6vPmcgDC5S46Xz7XNj0Z2cXKAaD0qYS6tuS11/KqZPSGLxTUY5i3sy?=
 =?us-ascii?Q?uWlI6asjpHNHutounmEfOK5FLmPyy9bj9vTqu1DC8pW/Mj74yCIG5IBwAsVH?=
 =?us-ascii?Q?gvD1glrMavc6zKbudCBcsCCtinorQDxrWIm4ZZiXtC9gzDjNqyb2dnIpgQqo?=
 =?us-ascii?Q?Fj8L9iQqImNY1YciKwIdxhvSy+yH9xHQhS+e0YIIrSs9V7MJ1ss92JsooJKN?=
 =?us-ascii?Q?1NPGAEP+B7O5S+Hobw82p1Aa+TMgxCUDbH+0moW+7zx8H2Vl6tAPpYcqmKQz?=
 =?us-ascii?Q?lqG2XF0f9HPoFdvtmzLkBDfyhG/CnatHpVZugao/P3NYtcu8dTjHp48+g+ao?=
 =?us-ascii?Q?Ehc7xrnG1QodciTYfM1Z+hZiUXMIGCEizNoSMGWT15kkcBP88bR1f+zWfN7S?=
 =?us-ascii?Q?HS2S3JJHRGClx9RLfLQCVYIYbip+aynqk9hunb1NNO1S4Td0oYzW+V8f4k6a?=
 =?us-ascii?Q?2fs2h2/hb5PDN2a+sx+gGf0VXowvVgykeRVFi0+lQJ/TXecYmcnq2O0Mxv3+?=
 =?us-ascii?Q?QMZSCooCKMmUsOeaHCoRPF336VKAy3kdGBir+iEolcM15y625D+l1VsuGCOw?=
 =?us-ascii?Q?VLg/cSSwyKmNGhH/GT4yDF1z2H+/BrrsE7dwnATqv5+IVvLOZeOegyZe7Am6?=
 =?us-ascii?Q?7ZESNQY1o1Z6Wy2N5J2g12UBxKO4WbiwgAPiIw024pGD9mQbXbwLyMeyn+ES?=
 =?us-ascii?Q?TaH1aFMcdBBIvfEkDrQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e8cbb7e-b60b-49e3-b87d-08dada19cf2d
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2022 19:16:01.1107
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: M8jHSQLD6SK8lZzgS3AZqvwAj5dJDR6ZW60YzoJSQcYl1Ze3dqtU6+FpPonJ91fD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR84MB1495
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: Lm02onXKQK_xM7i6q5UWMaj6ZrJuu89Q
X-Proofpoint-GUID: Lm02onXKQK_xM7i6q5UWMaj6ZrJuu89Q
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-09_11,2022-12-08_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0
 malwarescore=0 spamscore=0 impostorscore=0 mlxlogscore=523 phishscore=0
 clxscore=1011 adultscore=0 lowpriorityscore=0 suspectscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2212090156
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


> -----Original Message-----
> From: Taehee Yoo <ap420073@gmail.com>
> Sent: Wednesday, December 7, 2022 7:59 AM
> Subject: [PATCH v7 3/4] crypto: aria: implement aria-avx2
>=20
...
> diff --git a/arch/x86/crypto/aria-avx.h b/arch/x86/crypto/aria-avx.h
> index 01e9a01dc157..b997c4888fb7 100644
> --- a/arch/x86/crypto/aria-avx.h
> +++ b/arch/x86/crypto/aria-avx.h
> @@ -7,10 +7,48 @@
>  #define ARIA_AESNI_PARALLEL_BLOCKS 16
>  #define ARIA_AESNI_PARALLEL_BLOCK_SIZE  (ARIA_BLOCK_SIZE * 16)
>=20
> +#define ARIA_AESNI_AVX2_PARALLEL_BLOCKS 32
> +#define ARIA_AESNI_AVX2_PARALLEL_BLOCK_SIZE  (ARIA_BLOCK_SIZE * 32)

I think those _SIZE macros should use the _BLOCKS macros rather
than hardcode those numbers:

	#define ARIA_AESNI_PARALLEL_BLOCK_SIZE  (ARIA_BLOCK_SIZE * ARIA_AESNI_PARA=
LLEL_BLOCKS)
	#define ARIA_AESNI_AVX2_PARALLEL_BLOCK_SIZE  (ARIA_BLOCK_SIZE * ARIA_AESNI=
_AVX2_PARALLEL_BLOCKS)