Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp856743rwb; Thu, 15 Dec 2022 03:28:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf5QNISmVUg3vw6g6uiH6UPNKpB9a9WDrGTKW6WS51/3DYrX/hAXmWHwcOsMw77rEUtlxuEZ X-Received: by 2002:a17:906:341b:b0:7c0:f118:7e51 with SMTP id c27-20020a170906341b00b007c0f1187e51mr10313084ejb.38.1671103700271; Thu, 15 Dec 2022 03:28:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671103700; cv=none; d=google.com; s=arc-20160816; b=njKcKgXxR8DnDWewl/JAgQ6HO9AqiKKzTNf9I0cdZ4RmKkJfU36ahOMkeWpksZlOH6 pBYbdZ2PHR0kWZKVYrb+AGrn/mSD46ZBGLZka3cQbqUYBOA2qvN7UsjDKnK6k2uAnVyg B5Zh71OdSB4OnppJ4qvkmyTLw+wD/nffP5kEHOnMUWmgCz/aCm5wVZiTMPY7nIhv/3FU stf2HjLPiUfpe/wgr7tnFS5ogehYb69oU5RjSzu/L/2G4tONl++cMhl3+pIaklSi9bE1 Iryj2BAWWkqvZNh/LoYE2GmT1IHy8tAeRJuNR2mD3IOzhN9NyE2maFH/6FGhV38WrErM S9lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=rUYLvmFOgFDqDQdDN12wI1WE4ZOCsYwtI8WfEJp0Fvo=; b=uDUvTYNLNlJ36Y8k7js3V9lzz/B7YjoGM52bgKKG0fa751x2IWDqo3iPenBK/OZmc+ 2MHBau/3Efb0X6E7wMdQdPeHeh9ee3flGkzo3S2PxyvFCOu6/EgzcjIttIk8JBgtF5v9 A+VksWgASaF6UY5pVGevXrqKVl+dhPgiZJ4kfxloF4t9cHI5cLywyuZTC+5ecnFS2d3v R1eUhvQInvUilpUh9dux2Anhzd3UH4v2ajNjfIdX4hOAaXBZ8TgFK0ucA8ZyiPJ24Lue j0lac3AQ1NlO5Jycno1I36FuJPEvUorE6nxZSONg+rtOOvf55uabfarmHNSLX0kwFcjB Hu4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=YEScXS8F; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm22-20020a170907949600b007aea9dfb4f5si14274252ejc.511.2022.12.15.03.27.51; Thu, 15 Dec 2022 03:28:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=YEScXS8F; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230011AbiLOLKb (ORCPT + 99 others); Thu, 15 Dec 2022 06:10:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229603AbiLOLKa (ORCPT ); Thu, 15 Dec 2022 06:10:30 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85FD123E84; Thu, 15 Dec 2022 03:10:29 -0800 (PST) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BFB1E47008360; Thu, 15 Dec 2022 11:10:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=rUYLvmFOgFDqDQdDN12wI1WE4ZOCsYwtI8WfEJp0Fvo=; b=YEScXS8FUo6JWnAJrvXZcb2SHKVXpimUP6tpakgNBI6zeOXxC9widnbXE1LWmU2M3h8U wJZkyp8zEA3nlrLlN9+v3D8DmTvZF/IzUiaHJzJF5wJMymqKov4TIH+sK2vujfbTVwZK OYnxz4HTK6EoEXaU77UFpmmODpjraO7G0Tsk4yIW8zQJzPtTUBbOA14j/8ud/aQVIlAF ADxqTtQ7ptVp+7Cb6einjqScSfX1pmLirDN/EJzOir8tEbQVPQWnR1A4aVRpgxRoP6Yb 1zC+ux90a1duY5pIyjaVki1a2cznvlAJ9Hq0gG5jw0HrWi+9Dk6hnT8/em6fk/zrPkob 4w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3mg2bcg7pc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Dec 2022 11:10:11 +0000 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2BFB2aOr018669; Thu, 15 Dec 2022 11:10:10 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3mg2bcg7n4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Dec 2022 11:10:10 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 2BF8kKHk019328; Thu, 15 Dec 2022 11:10:09 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([9.208.130.99]) by ppma04dal.us.ibm.com (PPS) with ESMTPS id 3mf03ad5ax-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Dec 2022 11:10:09 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2BFBA7WS38994298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Dec 2022 11:10:08 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9AC2158064; Thu, 15 Dec 2022 11:10:07 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 683415805E; Thu, 15 Dec 2022 11:10:05 +0000 (GMT) Received: from sig-9-65-242-118.ibm.com (unknown [9.65.242.118]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 15 Dec 2022 11:10:05 +0000 (GMT) Message-ID: Subject: Re: [PATCH v3 03/10] KEYS: X.509: Parse Basic Constraints for CA From: Mimi Zohar To: Eric Snowberg , jarkko@kernel.org Cc: dhowells@redhat.com, dwmw2@infradead.org, herbert@gondor.apana.org.au, davem@davemloft.net, dmitry.kasatkin@gmail.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pvorel@suse.cz, noodles@fb.com, tiwai@suse.de, kanth.ghatraju@oracle.com, konrad.wilk@oracle.com, erpalmer@linux.vnet.ibm.com, coxu@redhat.com, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org Date: Thu, 15 Dec 2022 06:10:04 -0500 In-Reply-To: <20221214003401.4086781-4-eric.snowberg@oracle.com> References: <20221214003401.4086781-1-eric.snowberg@oracle.com> <20221214003401.4086781-4-eric.snowberg@oracle.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 7hrEsgPkc-5WyJ_M4FHbjv-cUSKcs8f0 X-Proofpoint-ORIG-GUID: 85H4ZOaWVoU9OVfFfNcY9xwzHIR2SHYr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-15_05,2022-12-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1015 mlxscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212150086 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org > diff --git a/crypto/asymmetric_keys/x509_parser.h b/crypto/asymmetric_keys/x509_parser.h > index a299c9c56f40..7c5c0ad1c22e 100644 > --- a/crypto/asymmetric_keys/x509_parser.h > +++ b/crypto/asymmetric_keys/x509_parser.h > @@ -38,6 +38,7 @@ struct x509_certificate { > bool self_signed; /* T if self-signed (check unsupported_sig too) */ > bool unsupported_sig; /* T if signature uses unsupported crypto */ > bool blacklisted; > + bool root_ca; /* T if basic constraints CA is set */ > }; The variable "root_ca" should probably be renamed to just "ca", right? -- thanks, Mimi