Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2932807rwb; Fri, 16 Dec 2022 08:10:35 -0800 (PST) X-Google-Smtp-Source: AA0mqf5oySjvYMBzlf1MQe//hCNIXl9zb0V44EBhtLpWe09v0ql5SFo+0484tz+qjJu9dB8Rb81r X-Received: by 2002:a05:6402:44a:b0:46c:d2f2:123d with SMTP id p10-20020a056402044a00b0046cd2f2123dmr29727656edw.40.1671207034945; Fri, 16 Dec 2022 08:10:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671207034; cv=none; d=google.com; s=arc-20160816; b=ZUoR08d6h+hVhIbNvJgPES7Xwo8/v1F1lsfAA8w05DX9M2IEBsGdloNdHNOJGPrOEx zxmiVWjPmvz/6R/OocIk2cO3aYN2bAOscxNoDb0jrul+spww80NfK55JyHkXSoHmzzml TWw7kDwGe+EbZk30jGPc7lPQoWUR82rs3Xn3toqHptGndByaqyAc2wcYu5IwvnKBZNL0 IHXGFOrKUn6T/YNBb7k6OCDMbson8Svb0V5qGbsdAT72j1JVsjCHl3uYNqBRPSDrlpUa H3ipKWcQk8NdQFyVQ5StOvAKqEG6CUSbzyF6M5qOvnjiVZllLbQbxs46vtPcEMpiS2xD 2Lzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=IGoF+2jeK3IkIsvFOiLtqC8rk3aTOnFvuluK6bOOS/s=; b=xGfxE8XLSh02ED2UFi0JctWzfRtW3Ev04POgYr49kzbceBgoddIwIsztzMITzNEnN6 H0uPRWezRvlWEgFcLLJKXMaAsu0+UT9xlA0kj+NNFVDWIyHMf2h7+zo3nTbFYDd+E0x+ Gg9WQqXKFcJm364geCINKgzRhbfEAJhU1hDl159CGtqstGS7kIANcMzgs9UtBX5GI3MS DKF3FQ+sEzRQ+7eTKdA4fkta3Mi4BvFM7Wj2cU0rRsNwrJwe6KkN+5IvcFJyHOmfsNTV PkN4lGwzSv/v4xx4P0iJ6MJE6Wi5QkS1nSDFKnKmnL4+uknRFCWDQ3UxZx3EqJn0lFMy 1UEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=V4uY+vWc; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s10-20020a056402520a00b0046b1c26d81dsi3352595edd.80.2022.12.16.08.09.58; Fri, 16 Dec 2022 08:10:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=V4uY+vWc; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232589AbiLPQJz (ORCPT + 99 others); Fri, 16 Dec 2022 11:09:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231641AbiLPQJQ (ORCPT ); Fri, 16 Dec 2022 11:09:16 -0500 Received: from mail-wm1-x349.google.com (mail-wm1-x349.google.com [IPv6:2a00:1450:4864:20::349]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 094683882 for ; Fri, 16 Dec 2022 08:08:48 -0800 (PST) Received: by mail-wm1-x349.google.com with SMTP id a6-20020a05600c224600b003d1f3ed49adso720757wmm.4 for ; Fri, 16 Dec 2022 08:08:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=IGoF+2jeK3IkIsvFOiLtqC8rk3aTOnFvuluK6bOOS/s=; b=V4uY+vWc/RMYG7pA2bA3dSUek6jo2HTpzw5kpwwq+9/ZdVNEH0gQvYNW5Or+TWCRky f7Y6/9Khiv+DoWa+oGa9504FjuzAI92zMsjPS/QFrXPTYs0St3aidPUdVqKijA3MwxGm smBZ3ZsJThu78ZkErPyhH5oUXvp8EvszZj2Czz6sYjakiEk8hBNLXgxpaypl9nppX52i qeKqRqG00MJ0oEX97SxQPzmlSeG+JJPzr3w32COM053OLO9ECwgeYq1V6zmkOIJ2MSCp bYyfMtxQdxIdSzuzl+oltMftHHci/r5R9LFEYrmoTyyDTPsgdhb6Sw8QIQAiTv43zm+P qrkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IGoF+2jeK3IkIsvFOiLtqC8rk3aTOnFvuluK6bOOS/s=; b=J4hVwpf+y21t6vc5MVJe43fF4xFEezowKGYjVrAwSNdHorXg/TSaP5J8Vv5Fqr8taf ULXOh7Re+x5kHqWTbly7FJCoDmmFiAchkO1ekbCowLpRzr7WMoCmTw5mQJCej30fYt1g OKtvEpS7FgtWCb84VyhvMfWkf9QPkwscqn/DBZtwXjGaPU3UeLwFk/Z8zSU5eDEYhtcG rkDpNbzZw2FB8+T+H2djoBJX0dvIcLOoE+2XPmT74l0yFbKmKtII3bv4GtrNeAZLYZhz mbf+jK4f0OepD7rDR6YSMGPOTZn5GSUiwWoezezAca4ocZyUmZEd3lRUDOuxkQ9LWYEM wfxA== X-Gm-Message-State: ANoB5pmDVL5ojVJRxhzqgfrpeQIwdJt81/Vn+gaBm7oPefkm3pwOQv0K T36gsk+NnmUl63Bnb3F4hvEfj8RldLQ= X-Received: from glider.muc.corp.google.com ([2a00:79e0:9c:201:ad2c:4edf:bcb3:f7ae]) (user=glider job=sendgmr) by 2002:a05:6000:146:b0:242:9e3:87ba with SMTP id r6-20020a056000014600b0024209e387bamr33632358wrx.580.1671206926247; Fri, 16 Dec 2022 08:08:46 -0800 (PST) Date: Fri, 16 Dec 2022 17:08:41 +0100 In-Reply-To: <20221215162956.4037570-1-arnd@kernel.org> Mime-Version: 1.0 References: <20221215162956.4037570-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20221216160841.2061759-1-glider@google.com> Subject: Re: [PATCH] crypto: wp512: disable kmsan checks in wp512_process_buffer() From: Alexander Potapenko To: arnd@kernel.org Cc: arnd@arndb.de, davem@davemloft.net, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org > The memory sanitizer causes excessive register spills in this function: > crypto/wp512.c:782:13: error: stack frame size (2104) exceeds limit (2048) in 'wp512_process_buffer' [-Werror,-Wframe-larger-than] > Assume that this one is safe, and mark it as needing no checks to > get the stack usage back down to the normal level. KMSAN indeed bloats the stack frames heavily. Wouldn't it be more preferable to further increase KMSAN's -Wframe-larger-than limit instead? It is not intended for production anyway, and detecting a runtime stack overflow in the debug mode should not be a problem.