Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp3713260rwj; Tue, 20 Dec 2022 00:27:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf7TZ56TD/ZOIfmLtFh6/Y9TaPernMZ+5TY29EMktPv3iqgtUMyOFErLgR+e47HUN0Tqf8Be X-Received: by 2002:a17:902:ee44:b0:189:7816:2eeb with SMTP id 4-20020a170902ee4400b0018978162eebmr46667764plo.3.1671524836894; Tue, 20 Dec 2022 00:27:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671524836; cv=none; d=google.com; s=arc-20160816; b=pCaoYrwcYrwgyV/kXvNJL52Ln9JPjXdErP+8QP09STLuvdZg7TM+/4XFt1HVInJ7Uo Sbk9x8W/ZHP+vve9STd6WxdL7pMH/x2Wo6cpIGKTLyE7O5xI0e6jQxpPkDRiNTUxPrZo giVlbH7Rz01LB+VENYnYw+ijH2LnYpM0AOSsip/E7YXqZMkD57t8yZLY2sVUBGQQUDgx kyC7zzTO5K8QhlKzkooJYfYT03H2SNv5cVungxnKPqyX4rNbMA+ri0KBtq0atD7qYoFX roDI5HADiT8NflUp8KCwc/IGUqNmYeLy+txCCa0zQErKGSYCogTB0gtWAH51Q4rhIsqQ BAKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:subject:cc:to:from; bh=KxqTpbRry2e7W+ZgkT+ktWQZWvBm4/302YsxMGo+PvQ=; b=DwU2v/wIk9KSsGT4nc+e6KomPOQQYPbRGOI39qzh0PtB0tFp8l2/wv5PmpMYJtkr6E 6+Pw/5RW9EqBQrwG66t/El5X8bw2XTIldFb4kX+t9SvDzi5VGSC+QmXBe3jvYJovAqKE S4dfpyNSuOq7ORi7hfSbqNGHOYc5GJp9qlUd0Jz5/r7y9F8tgP+1KBdIqSmzYyEY905n rEssOr6DEg4AoRGpuSPltxVJWIICuwGK1AcnDaJIq65/h+Vx16Sdxkt34F/hdTAWI+xW XHayfz72uHos4HHEvSNAhyPH9zoCNZm13CKLHSFCSLZu9D18TeqMFdzUnvrcbMUcJ0Zo Lm1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=haag-streit.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u5-20020a170902e80500b001867db1d29csi14033794plg.60.2022.12.20.00.27.01; Tue, 20 Dec 2022 00:27:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=haag-streit.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232442AbiLTISC (ORCPT + 99 others); Tue, 20 Dec 2022 03:18:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbiLTISB (ORCPT ); Tue, 20 Dec 2022 03:18:01 -0500 Received: from mail.steuer-voss.de (mail.steuer-voss.de [85.183.69.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3508F1658E; Tue, 20 Dec 2022 00:17:57 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at mail.steuer-voss.de Received: by mail.steuer-voss.de (Postfix, from userid 1000) id 2D0183BDB; Tue, 20 Dec 2022 09:17:50 +0100 (CET) From: Nikolaus Voss To: "Horia Geanta" , Pankaj Gupta , Gaurav Jain , Herbert Xu , "David S. Miller" , Ahmad Fatoum , David Gstir , Steffen Trumtrar , Nikolaus Voss Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] crypto: caam: blob_gen.c: fix CAAM io mem access Message-Id: <20221220081750.2D0183BDB@mail.steuer-voss.de> Date: Tue, 20 Dec 2022 09:17:50 +0100 (CET) X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org IO memory access has to be done with accessors defined in caam/regs.h as there are little-endian architectures with a big-endian CAAM unit. Fixes: 6a83830f649a ("crypto: caam - warn if blob_gen key is insecure") Signed-off-by: Nikolaus Voss Reviewed-by: Ahmad Fatoum --- v2: added upstream commit ref and reviewed-by line drivers/crypto/caam/blob_gen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/caam/blob_gen.c b/drivers/crypto/caam/blob_gen.c index 1f65df4898478..f46b161d2cda6 100644 --- a/drivers/crypto/caam/blob_gen.c +++ b/drivers/crypto/caam/blob_gen.c @@ -104,7 +104,7 @@ int caam_process_blob(struct caam_blob_priv *priv, } ctrlpriv = dev_get_drvdata(jrdev->parent); - moo = FIELD_GET(CSTA_MOO, ioread32(&ctrlpriv->ctrl->perfmon.status)); + moo = FIELD_GET(CSTA_MOO, rd_reg32(&ctrlpriv->ctrl->perfmon.status)); if (moo != CSTA_MOO_SECURE && moo != CSTA_MOO_TRUSTED) dev_warn(jrdev, "using insecure test key, enable HAB to use unique device key!\n"); -- 2.34.1