Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp6253645rwj; Wed, 21 Dec 2022 12:52:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXvEK/xZ5TYlsH4hMprF/VljY3iaVSQT/AhwdJuZFYDV9uvIfqxkSEPjPSonOjoRNn4/1G+p X-Received: by 2002:aa7:9382:0:b0:56b:da42:95c7 with SMTP id t2-20020aa79382000000b0056bda4295c7mr3650020pfe.30.1671655952946; Wed, 21 Dec 2022 12:52:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671655952; cv=none; d=google.com; s=arc-20160816; b=M+4DleXWJno5vOzUSdltrTng3ek3mwY+YuEcwKTJq+vwRPgx+UppPWPginzH57xtTt bhsMZr/AW4rtHhfSzkhwgbjTkR1JDgf7lhR0Hnx1kE9UGfBXjdO8+tD/I2KeNEe1ZUQj 5tc47LoHrYFKB8bAtoWSsS9WF5ebSX3NH7WImpFgMVWpTBV+qpbMF2/l9spDiYxTp/5Y mmNC9R5g+HFBhD10e+S7HSz7MblqkQlGyte0kTsqVPUYnTcIpzFG1XJemmus4WydxnZX gARnu9hv1/YTj3C27/q6i06Y7bqV1FshQLm6XTbMzaySdB+RGSzgeUByFNBaJe2RwK+3 NZlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=EArWsSsoQFPak8uH4gIGnJD8pyZnlQJAaBi2bdOzVoA=; b=p4LQcNSLvSorIo8yzUwEQVZGin94+CSQNDMlVho1Qt10aadSPSZ7JVCLrp8fIL3FtN O4jjbWUBe3ZvrRxb3+G9Gh1hqLojXQZqN9GHfPYUMZEwTHtH9wQF0izPF/QZejaWbZE2 s/C+5cWX6VyFoWyT6NIL1Apd8drvsIajmrCouaTWmaTX0NeOESXV85RJeblYuYyfAX+G rkgB8Dp+u/7piSgWRuysVYhtpdQfpvFsaBOlftXkCh5qoJ6fVJIyyvr85sm9QfKBKWys pyqI7+sQELnWcvgFRtuLZnGrxFahi99G+uMz0MI61oiDvgMtX5k2u0Oh2zR0A3Scd0W7 mTSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="ugzfuQ/F"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c1-20020a056a000ac100b0056bae3f63b5si18026218pfl.327.2022.12.21.12.52.19; Wed, 21 Dec 2022 12:52:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="ugzfuQ/F"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbiLUUst (ORCPT + 99 others); Wed, 21 Dec 2022 15:48:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbiLUUss (ORCPT ); Wed, 21 Dec 2022 15:48:48 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8138B1A822; Wed, 21 Dec 2022 12:48:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0DCA460CBB; Wed, 21 Dec 2022 20:48:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB2A8C433D2; Wed, 21 Dec 2022 20:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671655726; bh=V20cak5a7oCUhu/ElPJQDWDEPcrzF+kUY7ml3BOPRAA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ugzfuQ/F8El0jwSlwYMle/yRAjDhWVugkamPioI3pUY+8UDkXBGc1PHBwn8DGQkiv IGRQdriSNr3uGD9Ra03+7w75b6rRHNUSxRCD1N3Womaolj2G7ePA+z2/+YI6XaA038 dsaLm+ie15QOiyOS3pJe8Jg3FR4zF+ya0zTgHOiD7MuP0XLvhw89RIC75wVV9pWdbf jRRXfZYGifZfd+IMnojvmz5kzGVG4J9guOfY4ep/o/vKfNfIRKcUFpeIobehqrSXp1 svckhF3Mu4pRx6vuFsEYboC9GspJv7a9W5o3/1sVPpOlDoGHkl8XOjHvwTBloaMKtP ijFjIzlG7t9wg== Date: Wed, 21 Dec 2022 12:48:44 -0800 From: Eric Biggers To: "Jason A. Donenfeld" Cc: Christophe Leroy , "linux-kernel@vger.kernel.org" , "patches@lists.linux.dev" , "tglx@linutronix.de" , "linux-crypto@vger.kernel.org" , "linux-api@vger.kernel.org" , "x86@kernel.org" , Greg Kroah-Hartman , Adhemerval Zanella Netto , Carlos O'Donell , Florian Weimer , Arnd Bergmann , Jann Horn , Christian Brauner , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [PATCH v12 0/6] implement getrandom() in vDSO Message-ID: References: <20221212185347.1286824-1-Jason@zx2c4.com> <86cfa465-2485-ff24-16f5-9014e25a0e98@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Dec 21, 2022 at 03:25:49PM +0100, Jason A. Donenfeld wrote: > On Tue, Dec 20, 2022 at 08:13:14PM +0000, Eric Biggers wrote: > > On Tue, Dec 20, 2022 at 05:17:52PM +0000, Christophe Leroy wrote: > > > Hi Jason, > > > > > > Le 12/12/2022 ? 19:53, Jason A. Donenfeld a ?crit?: > > > > Changes v11->v12: > > > > ---------------- > > > > - In order to avoid mlock()ing pages, and the related rlimit and fork > > > > inheritance issues there, Introduce VM_DROPPABLE to prevent swapping > > > > while meeting the cache-like requirements of vDSO getrandom(). > > > > > > > > This has some tenticles in mm/ and arch/x86/ code, so I've marked the > > > > two patches for that as still RFC, while the rest of the series is not > > > > RFC. > > > > > > > > - Mandate that opaque state blobs don't straddle page boundaries, so > > > > that VM_DROPPABLE can work on page-level granularity rather than > > > > allocation-level granularity. > > > > > > > > - Add compiler barriers to vDSO getrandom() to prevent theoretical > > > > reordering potential. > > > > > > > > - Initialize the trials loop counter in the chacha test. > > > > > > I would have liked to give it a try on powerpc, but the series > > > conflicts. I tried both on v6.1 and on linus/master from now: > > > > > > > Same here, I can't figure out how to apply this series. > > Rebased v13 posted: https://lore.kernel.org/all/20221221142327.126451-1-Jason@zx2c4.com/ > Thanks, it is always good to give the *actual* base commit though, preferably with the --base option to git format-patch. "Latest random.git master branch" changes over time. - Eric