Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221221224111.19254-1-vdronov@redhat.com> <20221221224111.19254-3-vdronov@redhat.com>
 <Y6OXuT95MlkNanSR@sol.localdomain>
In-Reply-To: <Y6OXuT95MlkNanSR@sol.localdomain>
From:   Vladis Dronov <vdronov@redhat.com>
Date:   Thu, 22 Dec 2022 17:41:18 +0100
Message-ID: <CAMusb+QuNN9bgWSFZnd_VVVie7uBdBOsn=Z+_k5RLv5F1QtPqQ@mail.gmail.com>
Subject: Re: [PATCH 2/6] crypto: xts - drop xts_check_key()
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     herbert@gondor.apana.org.au, davem@davemloft.net, nstange@suse.de,
        elliott@hpe.com, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org, smueller@chronox.de
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Thu, Dec 22, 2022 at 12:33 AM Eric Biggers <ebiggers@kernel.org> wrote:
>
> On Wed, Dec 21, 2022 at 11:41:07PM +0100, Vladis Dronov wrote:
> ...skip...
> > -     /* ensure that the AES and tweak key are not identical */
> > +     /* ensure that the AES and tweak key are not identical
> > +      * when in FIPS mode or the FORBID_WEAK_KEYS flag is set.
> > +      */
> >       if ((fips_enabled || (crypto_skcipher_get_flags(tfm) &
> >                             CRYPTO_TFM_REQ_FORBID_WEAK_KEYS)) &&
> >           !crypto_memneq(key, key + (keylen / 2), keylen / 2))
>
> Please use the kernel style for block comments:
>
>         /*
>          * Ensure that the AES and tweak key are not identical when in FIPS mode
>          * or the FORBID_WEAK_KEYS flag is set.
>          */

Thanks Eric, I will wait a bit for more review notes and I will resend
the patchset.

Best regards,
Vladis