Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Dec 2022 12:30:35 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Anders Roxell <anders.roxell@linaro.org>,
        Kees Cook <keescook@chromium.org>,
        Horia =?utf-8?Q?Geant=C4=83?= <horia.geanta@nxp.com>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
        linux-crypto@vger.kernel.org, kernel@pengutronix.de,
        "David S. Miller" <davem@davemloft.net>,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] crypto: caam - Avoid GCC memset bug warning
Message-ID: <20221228113035.ups6echnsmo4flnz@pengutronix.de>
References: <20221222162513.4021928-1-u.kleine-koenig@pengutronix.de>
 <Y6VK4IJkHiawAbJz@gondor.apana.org.au>
 <20221223174719.4n6pmwio4zycj2qm@pengutronix.de>
 <Y6wCbyttJ+WVzmZX@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="gaxrg6dgi72ticld"
Content-Disposition: inline
In-Reply-To: <Y6wCbyttJ+WVzmZX@gondor.apana.org.au>
Precedence: bulk


--gaxrg6dgi72ticld
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 28, 2022 at 04:46:39PM +0800, Herbert Xu wrote:
> Certain versions of gcc don't like the memcpy with a NULL dst
> (which only happens with a zero length).  This only happens
> when debugging is enabled so add an if clause to work around
> these warnings.
>=20
> A similar warning used to be generated by sparse but that was
> fixed years ago.
>=20
> Link: https://lore.kernel.org/lkml/202210290446.qBayTfzl-lkp@intel.com
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Kees Cook <keescook@chromium.org>
> Reported-by: Uwe Kleine-K=EF=BF=BDnig <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>=20
> diff --git a/drivers/crypto/caam/desc_constr.h b/drivers/crypto/caam/desc=
_constr.h
> index 62ce6421bb3f..824c94d44f94 100644
> --- a/drivers/crypto/caam/desc_constr.h
> +++ b/drivers/crypto/caam/desc_constr.h
> @@ -163,7 +163,8 @@ static inline void append_data(u32 * const desc, cons=
t void *data, int len)
>  {
>  	u32 *offset =3D desc_end(desc);
> =20
> -	if (len) /* avoid sparse warning: memcpy with byte count of 0 */
> +	/* Avoid gcc warning: memcpy with data =3D=3D NULL */
> +	if (!IS_ENABLED(CONFIG_CRYPTO_DEV_FSL_CAAM_DEBUG) || data)

I just tried: For me a plain

	if (data)

is also enough to make both gcc and sparse happy.

(On a related note, sparse reports:

  CHECK   drivers/crypto/caam/jr.c
drivers/crypto/caam/jr.c: note: in included file (through arch/arm64/includ=
e/asm/io.h, include/linux/io.h, include/linux/irq.h, ...):
include/asm-generic/io.h:290:22: warning: incorrect type in argument 1 (dif=
ferent base types)
include/asm-generic/io.h:290:22:    expected unsigned long long [usertype] =
val
include/asm-generic/io.h:290:22:    got restricted __le64 [usertype]
include/asm-generic/io.h:290:22: warning: incorrect type in argument 1 (dif=
ferent base types)
include/asm-generic/io.h:290:22:    expected unsigned long long [usertype] =
val
include/asm-generic/io.h:290:22:    got restricted __le64 [usertype]

Didn't look into that though.)

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=C3=B6nig         =
   |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--gaxrg6dgi72ticld
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmOsKNkACgkQwfwUeK3K
7AmDTwf+IuUVfMjDYicgKbEIu+CX1FN2NZUUW5qaon/vZyXKji1o2grwEzVYRPwE
m/pm8APNaT/2BlmiN8C0a4Ax/yXjfrzQnClMXxa96Tl5cMsf4AD5wEM6aFdxFUct
td471SO3y13UtPvSl01Q9pcv4E2RLxyt1g4hlXEbM7hNnZhBYA1nFlqPIyqf8lB+
H09vp5Ik6Vclv7PfDiprlMLWSwzh8NLWpYpYCDlNVgwjAizzVI17OyD1fWH/sYaj
WOUoONKLJgsITZnZ2k7SWww+RuAbZCAmxKjO7vJVukgHg+P5JWjzEsxYl1MRqdoN
+b/sP7duuBP57MFlQJQnGXft8SuSNw==
=gV7e
-----END PGP SIGNATURE-----

--gaxrg6dgi72ticld--