Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Dec 2022 15:55:44 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Markus Stockhausen <markus.stockhausen@gmx.de>
Cc:     linux-crypto@vger.kernel.org, markus.stockhausen@gmx.de
Subject: Re: [PATCH v2 3/6] crypto/realtek: hash algorithms
Message-ID: <Y66ZgBx+hduj9S3K@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221206192037.608808-4-markus.stockhausen@gmx.de>
Precedence: bulk

Markus Stockhausen <markus.stockhausen@gmx.de> wrote:
>
> +       /* Write back any uncommitted data to memory. */
> +       if (hreq->buflen)
> +               dma_sync_single_for_device(cdev->dev, virt_to_phys(hreq->buf),
> +                                          hreq->buflen, DMA_TO_DEVICE);

This is not how the DMA API works.  You must not do virt_to_phys.
Instead use dma_map_single and dma_sync_* is not necessary unless
you are using the mapping for something else.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt