Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        "David S . Miller" <davem@davemloft.net>,
        ChiaWei Wang <chiawei_wang@aspeedtech.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        Christoph Hellwig <hch@infradead.org>
Subject: RE: [PATCH v4 1/4] crypto: aspeed: Add ACRY RSA driver
Thread-Topic: [PATCH v4 1/4] crypto: aspeed: Add ACRY RSA driver
Thread-Index: AQHZD4nhuBerx3rD8U+/oUEvaZ6riq6GMoiAgAX3k6A=
Date:   Tue, 3 Jan 2023 03:37:48 +0000
Message-ID: <TY2PR06MB321306D17A97FBEBFE969A8B80F49@TY2PR06MB3213.apcprd06.prod.outlook.com>
References: <20221214070114.3966155-1-neal_liu@aspeedtech.com>
 <20221214070114.3966155-2-neal_liu@aspeedtech.com>
 <Y66hXZHl+kqIivOl@gondor.apana.org.au>
In-Reply-To: <Y66hXZHl+kqIivOl@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?V2LJcRbkxuESCOlwGE6P8fm6ijioCT31TTQ6qjtR7wSXgo/ZBjYFi6qwbAl/?=
 =?us-ascii?Q?LQElNRJVtiRB4eRRtdRTY/dQuMIdmhChjnTlNchELUaZwhEYLXUOgCYBGcZh?=
 =?us-ascii?Q?luZj29aAX9l9y0KlMlOs2UZxYLRSjBzeP81zlu5y44iaVcZHYQhmN2JdgBB2?=
 =?us-ascii?Q?sHzdynE7CLK2rDCIApJH9m9d2BDPeke3EY0+JcuyBdx5gcED1A7zcl9HI1zP?=
 =?us-ascii?Q?ZckbyrBSH8jc51QaL/ggDi4SLphX2WVXiHheLzPxdLNCE/uN8l4WS/ooTDEZ?=
 =?us-ascii?Q?/uo5m5j1ZGX7EL1VsiG557YgFcnjKK9CAUbtj1lzdWYhsXHkVuCFZIxzloNQ?=
 =?us-ascii?Q?EeogY1pQkpRBkw+M778YLvpG3W6yjfdtooGVJj1rDSOfMwaO1htxR/wQRAit?=
 =?us-ascii?Q?/+yS4htiVCTTFpz5koL1hzQf9OHh+1/ktkzEykBFGvv02jndemAVVKoYcRoS?=
 =?us-ascii?Q?Tb/O+OzuFVkNrfvRtnjkpDmJNX4ceES5M09oKTPmEGwDYlRLA8au+gGlUjZe?=
 =?us-ascii?Q?bkWBROVlcFLqjsyKYFhDXs5vamhW74jnsh0z49Fz2A+JSnuLy8ZTfAZ7YAju?=
 =?us-ascii?Q?I1bxX0RKdX5IbGSON6+0CMqH2c9zk1HzQm8KDqeCHa1AmhiCRd0t+u2OM9+W?=
 =?us-ascii?Q?XVFwe0NoBdSfRK5LC9D9I2/QhAg52SdM/81sA6Fd3iBFOGfRW3Dpg9sS0fsy?=
 =?us-ascii?Q?pqgDCe2O71SGsHvxl5+w3omVpn8uT8sIXQXqF5ISAIynnClEOF/6tfcFKvD7?=
 =?us-ascii?Q?A08KKt8XGfzI+ojC1rwdCyrsj6+qgMUrwqwohrst3/Dm8O2OQiZFxOCqw58r?=
 =?us-ascii?Q?b0XQpEEidb+G2JXV1rcwC9lBMMh1Npqsyqf7m4fz6gh1EelID1op0eOiP6qf?=
 =?us-ascii?Q?YsT9CuYsHLZwGT+MOFzkjubKlL0L8VN1nYt45v0A1kU/toOeGuyYRZxU0Xqq?=
 =?us-ascii?Q?Sckyt4hEUGf61pir5+Ae9xJ1fN1kGIohRVGmn/xdfdMoMnJQYmttCkGJUAlb?=
 =?us-ascii?Q?lUSikjkJGycZXSUPD9FA794CGFH4nyUIhFkb5/wL2cGnHZfSOlql8dhFpDvP?=
 =?us-ascii?Q?ykdz2hbfOjCFHHYwt4r3qz36rjd+p/Q7mUuYKlmy/gFrCeS0boBt7k0rYjdo?=
 =?us-ascii?Q?g6ihSWj2WC9/2CcsO0jVdMpWW2OYFez51O7IYowk8Ljw6783tEXp3yFVqJUg?=
 =?us-ascii?Q?g/vm9Z1Tam0LoU+OkMprBzmzfjlD4q069evBVnzUkbQZlgxPc2gyNe54PSgc?=
 =?us-ascii?Q?Zq1Euyd9SbtqM8AreX4DTYdv7UqbrVe50aEJdvsl9wskInWNSIJX6XV84b3b?=
 =?us-ascii?Q?5wHcNyaRa29rObuYoeX6brpQfCN8kwEUOiHqujNdVAGVnDCzUcFSAsbaQRCL?=
 =?us-ascii?Q?nyy5P4CNFufNowcEfbymOw9D+ujT1ZZKCpFgWyg3iGCCM7iumWzN0amW60hd?=
 =?us-ascii?Q?z7WV6qU471CdLof+9hjIEFdCQf3DzlgnOrQQjxZX8YFrWJuOxleqYmvvZ7Q5?=
 =?us-ascii?Q?6sNPnusMORe2glYDx31eTqk4i5c9moCaVTV6mRqd/IdvJaNOtw9XbSQu2sEg?=
 =?us-ascii?Q?N/wLvozqCIGFCAgh0iiwrIBdohGBYMhoPk5u78qw?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3213.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf9276da-77c0-4956-6b9b-08daed3be2a4
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2023 03:37:48.7313
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5/1snHlQmiE/eDcnWAyb72/2kmd9FjWvjShmYNCKv/51SsbM/18Aa3rogIAlPmFapM6Ml6STU5LyeCpbVKV+ZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5782
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Friday, December 30, 2022 4:29 PM
> To: Neal Liu <neal_liu@aspeedtech.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; Andre=
w
> Jeffery <andrew@aj.id.au>; David S . Miller <davem@davemloft.net>;
> ChiaWei Wang <chiawei_wang@aspeedtech.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> linux-crypto@vger.kernel.org; Christoph Hellwig <hch@infradead.org>
> Subject: Re: [PATCH v4 1/4] crypto: aspeed: Add ACRY RSA driver
>=20
> On Wed, Dec 14, 2022 at 03:01:11PM +0800, Neal Liu wrote:
> >
> > +static u8 *aspeed_rsa_key_copy(u8 *src, size_t len) {
> > +	return kmemdup(src, len, GFP_DMA | GFP_KERNEL);
>=20
> Please explain why you are using GFP_DMA.

Looks like it's unnecessary. I'll remove it.
Thanks.

> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt