Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2ebc9510-d7bf-a46d-6e78-f9e528b79501@amd.com>
Date:   Thu, 5 Jan 2023 09:38:59 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH RFC v7 01/64] KVM: Fix memslot boundary condition for
 large page
Content-Language: en-US
To:     Chao Peng <chao.p.peng@linux.intel.com>,
        Jarkko Sakkinen <jarkko@kernel.org>
Cc:     Michael Roth <michael.roth@amd.com>, kvm@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        linux-crypto@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
        jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com,
        ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com,
        vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
        luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com,
        pgonda@google.com, peterz@infradead.org,
        srinivas.pandruvada@linux.intel.com, rientjes@google.com,
        dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de,
        vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com,
        dgilbert@redhat.com, ashish.kalra@amd.com, harald@profian.com
References: <20221214194056.161492-1-michael.roth@amd.com>
 <20221214194056.161492-2-michael.roth@amd.com> <Y7VqgbTE34/Sxupw@kernel.org>
 <20230105033451.GA2251521@chaop.bj.intel.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <20230105033451.GA2251521@chaop.bj.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmZ0UzVpR0toeDk0ekp0c2NmcHhIaDJrN1ZhMWF2LzJZeWZrRjBKQUtGSnZX?=
 =?utf-8?B?dnNDTG5udzZQaTZjbHF2Z21EaWxVdy9jRDQ4d3h0bExuSUZ2aFBOMTRFYjBO?=
 =?utf-8?B?ZjkzWHN6VkNVM01lWWlPWVlJT2xaL3ltdUpNSHMrUjBlYkw0Z2V4TndVSnor?=
 =?utf-8?B?MFQyNmZRcDFRWUFNejduTEFBZnJmMkg3U2lKU2xZTzZGclQ0b1hNeWJZRjJW?=
 =?utf-8?B?YkRESmRDYjJzOVY2RHRNSVlJcHY5RVpOVkJxL3NuNGlxMHBKTzFDdndiVkxG?=
 =?utf-8?B?TXZTd1NOaVhnd0VTYkFFQVV2WE4wTWFvcXpnSXZIODk5MmREYVM2MEZ2YkVB?=
 =?utf-8?B?MnBOKzNYN0Q2aVJKUVkydUlsOE1SOTBqa1FWY0dDd3ZVN29vVDMyaWJTcWFO?=
 =?utf-8?B?aUdDY1I0UnlTelFBbzM5bzVMb1BKdnBCcVN2VVlSNlIzYUx1QlpjM2Q5cFRH?=
 =?utf-8?B?V1p3d3NRbUdOYjZieHJFMkg3VUlxL1NLMHl5OXYrS2hwU2FFTFZRMG5CbEVp?=
 =?utf-8?B?YUVBZ2dEZHUrbXQ5dzRvc2hBWDJ2WExsZnJDVjhXSUoyNDZkdWFBZklBOWl0?=
 =?utf-8?B?dC9DellRT0pjaS9QRysvaW9aNkJvNXd1NDZVN2F4RUszOUIveDBpZkZONSth?=
 =?utf-8?B?YXRKeEc5Y2dSa3BLZGpsNG55eTRtdy9LZWZyaytiMGNZNThLQWpCOVU2SXNo?=
 =?utf-8?B?MVBhU1FYNTNrM1VrVkNNNURZZ0E1N3VIeGZBaTdEWVN0VmVwNVU2MUVLSzdz?=
 =?utf-8?B?aDFvKzhyR0NHZ1JqZnpxYnNXRUVQeFUzL2NPUG9kbWxHZ0E0WGNpd2ZpNDI5?=
 =?utf-8?B?ZVlLNzA4QW4vWXlXTCt0cnlpYjZrSDNTeXJCQzFpYTFhbWNUT3pmeVNxZUcx?=
 =?utf-8?B?SnhYTllCOHRuWmU2RjB4ZHJFd2cwcEszNCs4VkdOWlNncFJmbm9ZTWROTENT?=
 =?utf-8?B?VE1vbFdNaWg2MTdGMFk0TEdNQlpOcDZKeVRhNTFITFAzMHpybHp5MEovSGFy?=
 =?utf-8?B?SG4wRzFCSnZSRStzdXdnSytid0k1UngxV24yZDQ2ZGxQcGErNVRxVkJXZml4?=
 =?utf-8?B?S2dWSjRuTWlRRTI1WXB1ajZPODVYaG5yS2dNYUhrY2szaEI4dXhVeDlMZ0o5?=
 =?utf-8?B?VWpWYXMydzVrS01RZzFZejJod2Z2bmt4Qk9CV1JnZ2tNdWxYNWo2eTAvUzZR?=
 =?utf-8?B?T2l1dG1NUkdSa0V1blVaZFQySFFpandKY2w5SUVoOUF4WnRLSEo1UGE4YkZX?=
 =?utf-8?B?RXQ2eWMrdWVTS2FEYTZmbHhaMEprUzVTaSt4NjlqOGtzNG55clpPWm9vWmJO?=
 =?utf-8?B?MDd4VHVEZW9BcjNUQjhQckJmSWF0ckZSNWFtUFllcVJTQ0lYM3RTVGlPTGV1?=
 =?utf-8?B?QkR6bkIwYUFnU2pFbFRtL2hEeE1pQ3BETGQwTnJlakZMaSt4WUMyQWVONFB2?=
 =?utf-8?B?b29iSm1ubW1tck1IRGJuaFowbG5FRzRqV0NVUHFqZ0k3TkNiWlA5eEQ3dzhZ?=
 =?utf-8?B?Wko4MlpMcUU5cWlzdTQrU3l5WDRobi9ocHFxK3IrREczY28vb0tDTFJadDJF?=
 =?utf-8?B?SVRLbUsxWXROV3dxa25leUlRbml2S3ErOFpWekFKdWErdTZ4Lzd4aWVCTzRY?=
 =?utf-8?B?b2hNc1gvUHJ2UTFqRXNBV2ZweTAwL0tpTlZXM0FVN0M5dld5OHpyZ1ZXV0hw?=
 =?utf-8?B?eklrUVcraEFKekd6U3QwM2tHeWUxS3M0NmM1YlViUzk5dGJQbUxDVVV2OWhi?=
 =?utf-8?B?V3NldGZ5RkJJZldHT1h1OXpLU2VRamFUUWFJaGFhdFRZVVFTV3M1Ujh5VnFT?=
 =?utf-8?B?alJ2S05CVzNwclJGVUxuTUxDSU1zUGxhZkwyeTlKQTZ0RFFpS1dwTXM5WmNI?=
 =?utf-8?B?Um44alZYT2xpVVlodk9xN1AyMUF0bGFBV0lJaG90d2kycUVSZFdTcDdsbmNa?=
 =?utf-8?B?WDF2Y2VERGxza3BCd3o1SnZOMFE4U1hHbXNPWlBxYUtiOW9uL01PQjJpQlk5?=
 =?utf-8?B?dTdJVUZwVXF0dHN2ZTlDN3lzZnlyOGxYaU1uaytxclI3TWUwNEdFZnlOdWVj?=
 =?utf-8?B?SzdpMHhGOUFTY0M3NWVpaDZkVEhFSU4vMVdXL0NJK0s2b2lScE1mRGFzZktk?=
 =?utf-8?Q?WlA8Xsn1j0BgF/7KXQMJ88mSm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cab18f80-ea90-4bd2-633e-08daeed2a119
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 04:09:24.1715
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WwHPlDwhuKOV4SRQxFvRZfsGOFs3IPj1CDkhTA8QTbD+IXH5xxE9xfOvbXSb+2aNZmTmy4rZ0WYKuGJuTJN0hQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8510
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 05/01/23 09:04, Chao Peng wrote:
> On Wed, Jan 04, 2023 at 12:01:05PM +0000, Jarkko Sakkinen wrote:
>> On Wed, Dec 14, 2022 at 01:39:53PM -0600, Michael Roth wrote:
>>> From: Nikunj A Dadhania <nikunj@amd.com>
>>>
>>> Aligned end boundary causes a kvm crash, handle the case.
>>>
>>
>> Link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fkvm%2F20221202061347.1070246-8-chao.p.peng%40linux.intel.com%2F&data=05%7C01%7Cnikunj.dadhania%40amd.com%7C7a95933fac1b433e339c08daeece6c2c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638084867591405299%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vDEu9Uxs0QRdzbUkJbE2LsJnMHJJHBdQijkePbE2woc%3D&reserved=0
>>
>> Chao, are you aware of this issue already?
> 
> Thanks Jarkko adding me. I'm not aware of there is a fix.

It was discussed here: https://lore.kernel.org/all/e234d307-0b05-6548-5882-c24fc32c8e77@amd.com/

I was hitting this with one of the selftests case.

> 
>>
>>> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
>>> Signed-off-by: Michael Roth <michael.roth@amd.com>
>>> ---
>>>  arch/x86/kvm/mmu/mmu.c | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
>>> index b1953ebc012e..b3ffc61c668c 100644
>>> --- a/arch/x86/kvm/mmu/mmu.c
>>> +++ b/arch/x86/kvm/mmu/mmu.c
>>> @@ -7159,6 +7159,9 @@ static void kvm_update_lpage_private_shared_mixed(struct kvm *kvm,
>>>  		for (gfn = first + pages; gfn < last; gfn += pages)
>>>  			linfo_set_mixed(gfn, slot, level, false);
>>>  
>>> +		if (gfn == last)
>>> +			goto out;
>>> +
> 
> Nikunj or Michael, could you help me understand in which case it causes
> a KVM crash? To me, even the end is aligned to huge page boundary, but:
>     last = (end - 1) & mask;
> so 'last' is the base address for the last effective huage page. Even
> when gfn == last, it should still a valid page and needs to be updated
> for mem_attrs, correct?

Yes, that is correct with: last = (end - 1) & mask;

We can drop this patch from SNP series.

Regards
Nikunj