Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp742354rwl; Thu, 5 Jan 2023 04:02:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXtSLRG1Xtga/i++rfnjbv1WTiUQPhueb9g5aI8i/XrnEvd/3bTJzo7J5+OXMIwLZRZjKqPh X-Received: by 2002:a17:90a:64c5:b0:226:1713:6b9 with SMTP id i5-20020a17090a64c500b00226171306b9mr29685179pjm.37.1672920152817; Thu, 05 Jan 2023 04:02:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672920152; cv=none; d=google.com; s=arc-20160816; b=uBAFrOR5eFSrk0y/0oZm2AL/nLcXL5d7YOZ5YPQ+xC9kuI6hxY5b4XJeNs1pWZAbN1 9iKOikDBjoqfLFtBfMJqFrOp6O+namrYkvzj+C08llTUnLaBhBncn4AqgcFwgm3ww1XC NH92EMC1KNpCqUI0sapUftqf3D6ZMrRRCPoppGFpEQf/Jbv/33vMBv33CpM+daPVqc+f aeQ5696nmjg+iG6Oo5yrxLbVOnN5H4Ho2PzZZJ+C3KunWLUy5nGt4ZCkNyAU6qhv9QCe 16V/496CYCQhdysfjR7Qu+//FfOSbJmfqzOZRXa00S2aWscQPcy6LsAGv+dThNq/E9yZ +ZLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rxDSQBwHRnb3E0R5N+GbgGmVgnJfEtgemZ1Yx2+Gk0s=; b=hmM8Yeqbpr8vx7uK53RSJUD1oRKRWC9Jo8Z72CLxnzCH3Kmr82JGX7ew0Cd89hvNst EcfFJUqmxmAHRoC1SABWt68IKWYyTfwFUp4J8wmBKXZPA0lW+dwf/CXjl94oJWAgIu1Y DBhvhCV1mfdrKu0sIE7k2pkrkgjX3sHhibiv0d/iKtowS7sbPiF3fg2X/RBMZ2Zjgs75 Ysk37N3i6p+x1dbuTLB/2ttQLQKREtOZHEvfbPHr0lel2mdEeN1m9kKQUKF96wDi/D1G JNocsPTLX88I+Rs7PX6q9dUNXzVrjvv9zg1noFrxvtzIhX4jOFHaUrL/NDvcqDbXEw+3 RfSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=fldm+pr1; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z9-20020a6552c9000000b00490a1c37b20si37068869pgp.615.2023.01.05.04.02.14; Thu, 05 Jan 2023 04:02:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=fldm+pr1; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231917AbjAEL5x (ORCPT + 99 others); Thu, 5 Jan 2023 06:57:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231646AbjAEL5w (ORCPT ); Thu, 5 Jan 2023 06:57:52 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59F624E432; Thu, 5 Jan 2023 03:57:52 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9DE7A1EC068E; Thu, 5 Jan 2023 12:57:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1672919870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=rxDSQBwHRnb3E0R5N+GbgGmVgnJfEtgemZ1Yx2+Gk0s=; b=fldm+pr1lRU+kw1bGYeepeJ61YDNxYNDV/pcfHJ/IOXUbKH/PN2ZPlU05O6jiGqdCz82ln wDA9OdQjMbBD4Z4+ywfQUHpCu0QmJxA4IayDocp0uWJ3TDe1F2JOoeQ0jvYhHYOG5/+hrI Ge843g8gWeg+u7ueLcu+wFhZdv+LMBE= Date: Thu, 5 Jan 2023 12:57:47 +0100 From: Borislav Petkov To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, harald@profian.com, chao.p.peng@linux.intel.com Subject: Re: [PATCH RFC v7 02/64] KVM: x86: Add KVM_CAP_UNMAPPED_PRIVATE_MEMORY Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-3-michael.roth@amd.com> <20230104174721.wa4detzppqzvsgsy@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230104174721.wa4detzppqzvsgsy@amd.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jan 04, 2023 at 11:47:21AM -0600, Michael Roth wrote: > But maybe it's okay to just make KVM_CAP_MEMORY_ATTRIBUTES writeable and > require userspace to negotiate it rather than just tying it to > CONFIG_HAVE_KVM_MEMORY_ATTRIBUTES. Or maybe introducing a new > KVM_SET_SUPPORTED_MEMORY_ATTRIBUTES ioctl to pair with > KVM_GET_SUPPORTED_MEMORY_ATTRIBUTES. It sort of makes sense, since userspace > needs to be prepared to deal with KVM_EXIT_MEMORY_FAULTs relating to these > attributes. Makes sense. AFAICT, ofc. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette