Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 6 Jan 2023 17:01:49 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Markus Stockhausen <markus.stockhausen@gmx.de>
Cc:     linux-crypto@vger.kernel.org, markus.stockhausen@gmx.de
Subject: Re: [PATCH v3 3/6] crypto/realtek: hash algorithms
Message-ID: <Y7fjfYCQdbP+2MU8@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221231162525.416709-4-markus.stockhausen@gmx.de>
Precedence: bulk

Markus Stockhausen <markus.stockhausen@gmx.de> wrote:
>
> +       while (datalen) {
> +               len = min(sg_dma_len(sg), datalen);
> +
> +               idx = rtcr_inc_src_idx(idx, 1);
> +               rtcr_add_src_to_ring(cdev, idx, sg_virt(sg), len, reqlen);

You cannot use sg_virt because the SG might not even be mapped
into kernel address space.  Since the code then simply converts
it to physical you should simply pass along the DMA address you
obtained from the DMA API.

> +
> +               datalen -= len;
> +               if (datalen)
> +                       sg = sg_next(sg);
> +       }
> +
> +       if (padlen) {
> +               idx = rtcr_inc_src_idx(idx, 1);
> +               rtcr_add_src_to_ring(cdev, idx, ppad, padlen, reqlen);
> +       }
> +
> +       rtcr_add_src_pad_to_ring(cdev, idx, reqlen);
> +       rtcr_add_src_ahash_to_ring(cdev, srcidx, hctx->opmode, reqlen);
> +
> +       /* Off we go */
> +       rtcr_kick_engine(cdev);
> +       if (rtcr_wait_for_request(cdev, dstidx))
> +               return -EINVAL;

You cannot sleep in this function because it may be called from
softirq context.  Instead you should use asynchronous completion.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt