Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp2510189rwl; Fri, 6 Jan 2023 07:24:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXvI4g0nL6tB+lmg3SbBK6Bzhepg/SFtwywpdPVbrlT3kbmPVMdkxjOetChshHwmtmp1Tc+n X-Received: by 2002:aa7:8d4a:0:b0:578:333d:d6ab with SMTP id s10-20020aa78d4a000000b00578333dd6abmr56835836pfe.21.1673018663094; Fri, 06 Jan 2023 07:24:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673018663; cv=none; d=google.com; s=arc-20160816; b=Ai0V/uSD8X/0vDAkR2wgRnUFaQBjTVCRXr0CPsE/pE8ktrQdWTUNZD/Mf2Kgz1iP+r CUHIUidI6VlLZ8FCRsFGx1LAa511foGnRHKx9ch3clWm3SOobYRhM+UdYbXg37beCDb9 AceiTxWEgbD/KLxuw0S1vEHZIea9ZHg1Y+32Q0v5JUnRkbch6YzbFbzWwx3I26PoN6hN 5PmdV4iAvqT+AiDq8dzD5C+swhOfnavzRwSWzcdHfjlWmKJ/j8M1OORQqC4vyIqah0vp Rnk6PCP3RYPkrrudwSJAqD3awr817Pr8F3iVObZTwQgeIcUJV9ILfw0i6G8zPwWK42Wr XA8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ERJh3bCGJjLo7lSZay5fCm30w7UOcE5OnOtB0gj/vW0=; b=cukLAco3JVWVgj8ABmHwJJDfR3E3UBfgpyPlMEJDgqgdli6H1UW8vqPZklHgTiXHsl IqtyKpYLKrL7pBE0840qb2f3OfDG+ZX3oLKZ05HZGc7qLz9Sfp2/rySHuJmaDkhzG6Fy /aDgwgUaU59YU6vgFru6rCZXp6eFks4JWV92QyFy1WYQ6iBkWzwpbLDnCEaDRNa4+PxJ y0XK5S05Gmb0UbdNP/2SE+vvnXmLIN/U3ko9uaLbi15IWsC8mlvguhPcJ2040AZVavRt paYqf8+mptqwfaJCSRSMPEeKPNI9B9Z/6KA2x8h8NguNy17bTaZHQrOLfUIHnUe5v56v 3Gtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o20-20020a056a0015d400b00582687fb9f4si1762382pfu.152.2023.01.06.07.24.03; Fri, 06 Jan 2023 07:24:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230294AbjAFPUC (ORCPT + 99 others); Fri, 6 Jan 2023 10:20:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234924AbjAFPTC (ORCPT ); Fri, 6 Jan 2023 10:19:02 -0500 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 320AD809BA; Fri, 6 Jan 2023 07:19:02 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1pDoUW-00Ebxu-03; Fri, 06 Jan 2023 23:18:45 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 06 Jan 2023 23:18:43 +0800 Date: Fri, 6 Jan 2023 23:18:43 +0800 From: Herbert Xu To: Vladis Dronov Cc: "David S . Miller" , Nicolai Stange , Elliott Robert , Stephan Mueller , Eric Biggers , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/6] Trivial set of FIPS 140-3 related changes Message-ID: References: <20221229211710.14912-1-vdronov@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221229211710.14912-1-vdronov@redhat.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Dec 29, 2022 at 10:17:04PM +0100, Vladis Dronov wrote: > Hi, > > This patchset and cover letter was initially composed by Nicolai Stange > and sent earlier as: > > https://lore.kernel.org/r/20221108142025.13461-1-nstange@suse.de/ > with a subject: [PATCH 0/4] Trivial set of FIPS 140-3 related changes > > I'm adding patches 2 and 3 which (I hope) resolve issues spotted by > reviewers of previous version of the patchset. This new patchset should > ease our future kernel work on the FIPS mode. > > I'm quoting Nicolai's cover letter here: > > > Hi all, > > > > these four rather unrelated patches are basically a dump of some of the > > more trivial changes required for working towards FIPS 140-3 conformance. > > > > Please pick as you deem appropriate. > > > > Thanks! > > > > Nicolai > > v2: fixed a block comment formatting > > v3: "Reviewed-by: Eric Biggers" was copied from the v1 thread: > https://lore.kernel.org/r/Y6OXuT95MlkNanSR@sol.localdomain/ > > Nicolai Stange (4): > crypto: xts - restrict key lengths to approved values in FIPS mode > crypto: testmgr - disallow plain cbcmac(aes) in FIPS mode > crypto: testmgr - disallow plain ghash in FIPS mode > crypto: testmgr - allow ecdsa-nist-p256 and -p384 in FIPS mode > > Vladis Dronov (2): > crypto: xts - drop xts_check_key() > crypto: xts - drop redundant xts key check > > arch/s390/crypto/aes_s390.c | 4 --- > arch/s390/crypto/paes_s390.c | 2 +- > crypto/testmgr.c | 4 +-- > drivers/crypto/atmel-aes.c | 2 +- > drivers/crypto/axis/artpec6_crypto.c | 2 +- > drivers/crypto/cavium/cpt/cptvf_algs.c | 8 +++--- > .../crypto/cavium/nitrox/nitrox_skcipher.c | 8 +++--- > drivers/crypto/ccree/cc_cipher.c | 2 +- > .../crypto/marvell/octeontx/otx_cptvf_algs.c | 2 +- > .../marvell/octeontx2/otx2_cptvf_algs.c | 2 +- > include/crypto/xts.h | 25 +++++++------------ > 11 files changed, 23 insertions(+), 38 deletions(-) > > base-commit: b6bb9676f2165d518b35ba3bea5f1fcfc0d969bf > -- > 2.38.1 All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt