Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
CC:     "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>
Subject: RE: [PATCH][next] crypto: aspeed - Replace zero-length array with
 flexible-array member
Thread-Topic: [PATCH][next] crypto: aspeed - Replace zero-length array with
 flexible-array member
Thread-Index: AQHZJJRaDVnvok26Y0eyz/Y/HvnX1K6XeAsw
Date:   Tue, 10 Jan 2023 10:46:03 +0000
Message-ID: <TY2PR06MB321351BBEA501A7BACC9802C80FF9@TY2PR06MB3213.apcprd06.prod.outlook.com>
References: <Y7zBxbEAvcEEJRie@work>
In-Reply-To: <Y7zBxbEAvcEEJRie@work>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1JLTJ4oOpSgfGSc5cyDqGENUk5UvTYXB3V3aBrojkX0h8fqujF8SWfUcRG10?=
 =?us-ascii?Q?75zZhjoOpKsTEYd9Fy+aNPTASKeXlJVIirEGtOcJ038UAde7xe5zP1h3niUQ?=
 =?us-ascii?Q?hwnpj+KV/iyvaoanhIH18VcPZclbdSg6YtKIvM+yqLNYPoBpx6f+lS8pfkeh?=
 =?us-ascii?Q?gU7l0jVMWNk1l97VS8E0uxuINab7AieFk1C4Ks7T4YTRvz1WYvtDZ+kMqQ+s?=
 =?us-ascii?Q?zfMG5m4e/pvc0SwED9aKxXegnjIWydzfVNmagZOZ+iXhmOk/0lGreHVQuB3A?=
 =?us-ascii?Q?gfL4AZv7A37+nPGZ6d9uoUrecyufjbUhzXjZqGCEq4wBRlSX402DrPIwaMCw?=
 =?us-ascii?Q?961zhCHCFUfXhS6icZJl8KfCMgSH+n6DWQr48Dtqk+sGPi9Y0VyrZW2gRS1W?=
 =?us-ascii?Q?jfkVjUxl5Aq8zK/59eFW53geQlPJzRL0dWXBfAmegghoJ+c5SWH8lFPYwuAf?=
 =?us-ascii?Q?U/8FYucu2LKRgMc7iaBadE1CB582lrBPuli2wELBQWACK290BXMm3ZUZPaTH?=
 =?us-ascii?Q?VtEiWarfEg/fsEFWwc0ySNbYM7cSuEJodR07csY79TV7AOr1ZS/ORsxLUJWB?=
 =?us-ascii?Q?Hb1638HhxhOpBwPXV74mHcPkmz0T2X0EKAPWa5czu0wk5Xc16ZGOEYdtfIKS?=
 =?us-ascii?Q?vAlH/Y2Uuu6yAzc3pBfCfW4qV8ZEnVo/rUy1sHGmGuv/HIRMBNe6qvcua34m?=
 =?us-ascii?Q?GJNb0Rx50PljY8JCdMJP1QZTaYfnr9uaGlRn/uEkp6RUxm3P7859KRo8hi6z?=
 =?us-ascii?Q?UrBAJbJ95afOn2SDtfjtw/22Y/wxd+iVxdCffI+cseN/CV2T35ejZoys+8bz?=
 =?us-ascii?Q?wrzyt2ucZqyINli0lpY7vhc1j+A/N89SjgHSmPwIfk6XJcumsUE/5zNjuEQL?=
 =?us-ascii?Q?7EjPO3Lnu+Io+LV4xnoP9RcHifBlyZBlm5j8D1obYafc/JZxjEr20vSQu95z?=
 =?us-ascii?Q?9gYXPerdWsv0ZurNPGzWsJkwI5wfha2PH1WYOPmoOUW/IAL4wh7GyhrNNYHw?=
 =?us-ascii?Q?5ELy5mYcwFjWgJPj6DwHctK3MA17Iln7VHIykxz+YCW47H3dCrSfFMn3tFgU?=
 =?us-ascii?Q?6NZB3ooV98xbaOQySjfl9ZgZ4ogqywooD0yhWOCOZNmD5m1SwAdPmUNPsCxV?=
 =?us-ascii?Q?jjFXTmtQJ4Af15b6vsPgLZRe7RknA1jCRJ9zLoNIodLeqjvNjNXBEEaVQUAX?=
 =?us-ascii?Q?BILDE1nHFz/rNUynKsLBU90osbXqteRnlE6wp0wYpU+tVrQQxL6SWq7YQrNJ?=
 =?us-ascii?Q?6Zh2q3j7oB63udJYW16WRefnjI3fpUiKv9AoxbYJyBrFWVZaZbQw2LClyck3?=
 =?us-ascii?Q?Gx2MZulxSpM2hSDWBnnFf/TiJbUKoWawsIH7h3cH+XJ/8F/uOrHns8mwixvz?=
 =?us-ascii?Q?3wYoxNkSxUEQr37R+o2AWdJQdEIFkRSG+889iDLIs0TbI/IVv740lG6kG8cg?=
 =?us-ascii?Q?ChLHxMgP2nIEag1META7GLsmwzt9xNcvqev7Hm71nPvPHj7oI6YaanhYJnDJ?=
 =?us-ascii?Q?/iHb5WTedgYAOt0TYqP4k0cgJieQ0jTTPToivGS9Hp81+DGn5Nw7xT17rXDv?=
 =?us-ascii?Q?tTrw6QULaqcQ09+ZGHb468dlXDAZS6epvy9QlTJR?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3213.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e24a1b5d-f759-4404-208f-08daf2f7de97
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2023 10:46:03.1480
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 74LZMJPJgUCN36thYG4OMSfD5wFD/dA2VqxZUzOFkxI4Jl70jmFXSoVFpPK+xLmQlN31HissRwCjugFcKn1O2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4122
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> Zero-length arrays are deprecated[1] and we are moving towards adopting
> C99 flexible-array members instead. So, replace zero-length array declara=
tion
> in struct aspeed_sham_ctx with flex-array member.
>=20
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE routine=
s
> on memcpy() and help us make progress towards globally enabling
> -fstrict-flex-arrays=3D3 [2].
>=20
> Link:
> https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-lengt
> h-and-one-element-arrays [1]
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html
> [2]
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
>  drivers/crypto/aspeed/aspeed-hace.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/crypto/aspeed/aspeed-hace.h
> b/drivers/crypto/aspeed/aspeed-hace.h
> index f2cde23b56ae..05d0a15d546d 100644
> --- a/drivers/crypto/aspeed/aspeed-hace.h
> +++ b/drivers/crypto/aspeed/aspeed-hace.h
> @@ -183,7 +183,7 @@ struct aspeed_sham_ctx {
>  	struct aspeed_hace_dev		*hace_dev;
>  	unsigned long			flags;	/* hmac flag */
>=20
> -	struct aspeed_sha_hmac_ctx	base[0];
> +	struct aspeed_sha_hmac_ctx	base[];
>  };
>=20
>  struct aspeed_sham_reqctx {
> --
> 2.34.1

Reviewed-by: Neal Liu <neal_liu@aspeedtech.com>