Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp1461408rwb; Thu, 19 Jan 2023 10:56:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXudLc4kHX/Ups+3kJiwfhhpdE1tYhzE9DnxVWUbObACOsVphnQ4bTwgEapMMOUze4wyPX+P X-Received: by 2002:a05:6a20:42a0:b0:ad:e914:5523 with SMTP id o32-20020a056a2042a000b000ade9145523mr16290285pzj.53.1674154610606; Thu, 19 Jan 2023 10:56:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674154610; cv=none; d=google.com; s=arc-20160816; b=QZi4M9jvBnAkNSnOR4MEaUA1QVEBWCoI6yvSrYIHPzr4CGKQy8DfwxFyrBVHRdC54d NfE81p7GSS1Z9gJV1c9hy1qSK08bpPhL2WUgTEogMOxKGcQLziMbPrk8/MCkJbpC51aV 9vpr063LUygRrdzWtmlOPPHbD48Whesz4Avje7EQ+sCKY+JtjHCWpOVGUskAOPNcirZf kyLLGXqN/WqDKEEb45wDXfd0QlPV+p9S5TloRaspmiboEPFQSR2QX0RbzUIciabGzpup x9FWwZg7RwKbxUg1CQiN87wXvGKVm8d7wM0Vmgr8nY5gNpHg675Hj5qqFb689QGGxOr2 i6Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=xNVXfWTFHPUTtkdhJd1rvFQYW6suzNo+IYrlxBerVjw=; b=fNUSKz+ZPpBcP2DumdYe3J14EG+QXY6dCCJZEIP59n1bw182bSIZ+S4h8oFpa6qZFv WWmlCbxWxb+/F1U19FmmVfF4S6mR+yOeBHgZad51sqH5AKtv1XLkn2YCpQpzrnAN6ny5 5xzG9oTXrEDnYeUpEWu/8JqoBWfdZaWZqX8EcjHuiuE+0BVYxEmafr2D5rEK+cd9MUY2 iCwnfJ2PEupFKdJYc4TBN/gQJV/EXK8WNhyvNYUxvR+3vueBRNwDQ7d270j2W5dk4JB6 1Z77zStoO8WAaENK5zmoc/+7tBcVn4fhrm6bfozL5DP8iGnRsMmdkHv3DlQ3WhTdr3tR L9hA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=JCfzsF2f; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e14-20020a63d94e000000b00478ee0ffc8bsi38374175pgj.792.2023.01.19.10.56.38; Thu, 19 Jan 2023 10:56:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=JCfzsF2f; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230432AbjASSuO (ORCPT + 99 others); Thu, 19 Jan 2023 13:50:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230240AbjASSt6 (ORCPT ); Thu, 19 Jan 2023 13:49:58 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EC8395142 for ; Thu, 19 Jan 2023 10:49:55 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id s67so2277336pgs.3 for ; Thu, 19 Jan 2023 10:49:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xNVXfWTFHPUTtkdhJd1rvFQYW6suzNo+IYrlxBerVjw=; b=JCfzsF2f0L14x6DnDb97ikzDMd+kmDUm+hY4g0ikovS6VCInjBWJHaf/91emjlkbvv 7wIBq95BwSi0sYX+qpZD/SDvgq6Rh0mChGWHNsKn3x3hLmQ8FzFzJ8/ZbJBpvglwgQ4P DCgQbf4DC/hZmnSwoV0J3qJIQ2CUCL3azLbW7iE8ZYMMJf7aB+WsETKfdqrzzfEJ6ojU vsPAh6PoOnotNaQto+c0+ylg5pDTEUWQjzlqfqHA4n+xq9Aj/eYU3tjl8BclPsCxy96X tvpdUK9qzbs7kasSXAsdoo6MSNp8cPe7grioN6SM05rjDR6+YxuYdpreH2mSGn1YnH2i 7GNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xNVXfWTFHPUTtkdhJd1rvFQYW6suzNo+IYrlxBerVjw=; b=3KyiN9NlaXsfz60Gmhn6NbBTQsFjddfz/TuTw+kpcqcMr9XyCGEJnP+Wi85zpnrWTA QTygTeyW1YsYxywSQpul20A0fixiqymja3LgNkUGwYyxO/eZ9s6d55ZImcrpFAg8h42K WBbNEUcVUZJYzIoNYr/SYDDORPS2k6oNBKdzNugEGO+MgQCWc7AFACV4/BsoOuJXZjZW axkfyAFOx/3ykIJYL/leu+ck/Yy3D4TyQwNJ7tCXWAAIoR6N60Ii7lBCR2BeLVkszgw3 vvaTqvWLwKpeZD8V0+21zZT5XDQSIMpb9A2zgflQf08DeBUUtaB3sGZxIW15I91Ey7hR nQZg== X-Gm-Message-State: AFqh2kpDV7x9MJVYP0mPfaOeBlVDurkmU+qlWnFBPpICJJwgsefcpaNr vVPS1PVPR8hJR70dLx6etIQFUyWMKK4PPLv1csVyAg== X-Received: by 2002:a63:d455:0:b0:478:ae53:a299 with SMTP id i21-20020a63d455000000b00478ae53a299mr956491pgj.260.1674154194728; Thu, 19 Jan 2023 10:49:54 -0800 (PST) MIME-Version: 1.0 References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-63-michael.roth@amd.com> In-Reply-To: <20221214194056.161492-63-michael.roth@amd.com> From: Dionna Amalie Glaze Date: Thu, 19 Jan 2023 10:49:43 -0800 Message-ID: Subject: Re: [PATCH RFC v7 62/64] x86/sev: Add KVM commands for instance certs To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, harald@profian.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org > + > + /* Page-align the length */ > + length = (params.certs_len + PAGE_SIZE - 1) & PAGE_MASK; > + I believe Ashish wanted this to be PAGE_ALIGN(params.certs_len) -- -Dionna Glaze, PhD (she/her)