Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e75569a8-6b15-780c-a7fa-945f1cce576c@amd.com>
Date:   Thu, 19 Jan 2023 14:54:01 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH RFC v7 52/64] KVM: SVM: Provide support for
 SNP_GUEST_REQUEST NAE event
Content-Language: en-US
To:     Dionna Amalie Glaze <dionnaglaze@google.com>,
        Michael Roth <michael.roth@amd.com>
Cc:     kvm@vger.kernel.org, linux-coco@lists.linux.dev,
        linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
        jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com,
        ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com,
        vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
        luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com,
        pgonda@google.com, peterz@infradead.org,
        srinivas.pandruvada@linux.intel.com, rientjes@google.com,
        dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de,
        vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com,
        dgilbert@redhat.com, jarkko@kernel.org, harald@profian.com,
        Brijesh Singh <brijesh.singh@amd.com>
References: <20221214194056.161492-1-michael.roth@amd.com>
 <20221214194056.161492-53-michael.roth@amd.com>
 <CAAH4kHYoWtM=Xe0kgmtKw01-45DefEikdLz0qUJRRMLdZHzkwA@mail.gmail.com>
From:   "Kalra, Ashish" <ashish.kalra@amd.com>
In-Reply-To: <CAAH4kHYoWtM=Xe0kgmtKw01-45DefEikdLz0qUJRRMLdZHzkwA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amlJQk4xalhTZ2Z2QndNYzdaQXJDZUdRSGhNT0ZNRmkzNlNrNnRMTFFmWjBF?=
 =?utf-8?B?TGlGMHhsRDAwNlh1RnpBMHdMcnhQa2p5ckVGVnY2REdmMi9LaGhMTUlhSlNN?=
 =?utf-8?B?cDdJUHVtY3JrSS9TUmFWTStRYmNhaU92YjZyMjdQcER1WUFLWXZGQVBLZjQx?=
 =?utf-8?B?ZWdmcXVPSHdSald3d1pJSjhUM0tyRDc0Vlo2SW5HdC9ZTDl3V21BaVhlbkxK?=
 =?utf-8?B?eUNlQy9jVXZZRnptSUE5d3ZJeG5KbkE5bDQrYWkzRTgzNEVaVDhOMlB4eFpC?=
 =?utf-8?B?cE96Q3BZVkRMUFVsUVFNcXpFaUNEVW9RVTlvTkg5czAzTlhjcGlVMU5VTS8y?=
 =?utf-8?B?aElQL0V4WUhXM015YkpFdmVGRkJyNUtIM01tMkNuN1EzWnlSL3NnVDV3c1Jo?=
 =?utf-8?B?Z2VyRkVETDQ4eDJOR0FoK1h6bDRKb0g3NEtabU1oaWJTU2VVSGFWOXp0TkFO?=
 =?utf-8?B?MWtWQlhRNjRYRGVzWTgyRmhFdG9seEJrQmFoWEVUQWxwbXFYVUM4Ny9Da2ZJ?=
 =?utf-8?B?TzRYeW9jNSs0dEN4VzMzQVJUMTNmNUlZbzh3djdCS1daODRKdTY4V3hRczVn?=
 =?utf-8?B?eSs4NVo4RmZIa3l4K3dLalVodVEycmsya3o5WDBkUzVGTGlFRmFxYWNjK1Rl?=
 =?utf-8?B?eHZXWG95RHFHbVhNY0JBOU9PYXNFbzZ0c1pMU21wak0xdmRwRSsrcUdNUzNm?=
 =?utf-8?B?Y0ZOc3puTEZGbldJcitGSGwwZDJQKzAwZ3A0SWdVK1Uxc243cVo0QUcrY1du?=
 =?utf-8?B?Z3IwS0h5dmd1RGpnS2tjMVJkZWtNdlJ1cEtuaGhVNjZFUFRzbTFjL0RjbXQ4?=
 =?utf-8?B?UTF2bkpaRGsrUklQQUNkR254RVZFT1NxTHZLeHRZb1l6R0llUTg0VWVNb1RL?=
 =?utf-8?B?NFlrT0txN2ZyZzg5UHRKb1NYb1VwblhOVERLM0x2cEcvZDBXZDRVME9zWWZr?=
 =?utf-8?B?aldpU2w2YlBEL2RpTDN5cUZtNUd1QWNPalRsSmVTb3duUzhOVTdRR3dRSFJ5?=
 =?utf-8?B?Si9QUnZJVzEvbU9HN2NWWm5URElBd0pIaUNYZFlZN1lrL2Rzd3NtYkxNOWlQ?=
 =?utf-8?B?dFVCUlRMd0ZMN2ZVeDBwK0hHMHRvekp3a3Q5ejc0emxMNG5EQ1NLa3JadS9F?=
 =?utf-8?B?eVpxZmM5bXhvNmxKZndySzk5azZab0tSZmYrWW1XYmtLbFVLNXJlS09oRWFT?=
 =?utf-8?B?TUJIZ1gxajNwN0lGZjdJK2VPT0dGWnZ4MWdSS25qcXgyNVZBZ2d2MlJUYk5Z?=
 =?utf-8?B?dExydEZNS0pGQ1RiN29wSlZpcDlzSjJSTWxWMGlVMXpZekZFTUhUYnp5MC93?=
 =?utf-8?B?M1cxanQvdlJLTlRCbnBGb2I1c2JJNU14TUhkdlNRcmtzWGwyWXdMVkRWTGFK?=
 =?utf-8?B?a0xhTzlBTWJnZmRPNi9CZWd3cUxuZVFNS2J0WTM3c1NybDc4SUt3SDBjanR1?=
 =?utf-8?B?cFIyNHJicTlIRVZFSW1WalR2ZFZDbGtYYVZPc0w3ZW4rdFlQV3FkL2ZmMUpJ?=
 =?utf-8?B?LzNNN2F0SnkyTGRGVGMyamhCeEd2eHVHK2VoTFU4K1pLUWY3SThQc2Zsejgx?=
 =?utf-8?B?Sm9TeWZXaDRTSnBNZXZIQWRKMUpZRG5VbEgwd3dsMlUwdzJhby9vSy9NanFs?=
 =?utf-8?B?OHg4cno3SE11VkVEYitXT0I3eUc3K3RlNlNlN0N6S1hSL3VyOHUzQllXUS9O?=
 =?utf-8?B?Q0tLbUVuT2xJR0xMNmloYWhIaFRXeDdZakJGUmFJbFlhLzFnTHZ3RHhCNFB3?=
 =?utf-8?B?VTNaMFlOeUUvanRQazlvWE9xZmxrclZTSkZKV0NldDhJTERLTDBvcmxNNnlJ?=
 =?utf-8?B?ZDg4RVVmcm5qK0hZNzN2bEpXS0Jxa1hVaFJRMElKcXlnaHdSNkV0aE0wZDAr?=
 =?utf-8?B?N1FBcFZQN1hZQWVtN2MrYnZlMGR3YWJ5OWxVSGd5Rys0ejQ3NkZQazVWaUx1?=
 =?utf-8?B?QTBlK0YrZysvR0ZWbVQ4ZGJVT1NVRXFGQkxBOTBzNmplUTlDdjFDSkZWMXR5?=
 =?utf-8?B?YXp4cjRZd216TnlES2dsZ0FRa1BBQlF5bTlJclg1UWh6ZE5nbjhuUW4xQzE2?=
 =?utf-8?B?K0xiSXg2MjBjS1dzQXVDYzdmQjFEem93UnUxL1N1RjdjWkZJaE1kdWV2Qnl1?=
 =?utf-8?Q?5DwNnRUbau5LJjlt2e1nt1u61?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52ada9bd-adc6-4505-d18e-08dafa5f4f15
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 20:54:08.4513
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uX+WPEm5b/fc1S+j/aYNqhicpwJk1kTy3eDCN+PjZXrApMV2z4xNnv5Tvc65/17c8vDHnU90toywUeOzFH98Sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8570
X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NORMAL_HTTP_TO_IP,
        NUMERIC_HTTP_ADDR,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 1/19/2023 2:35 PM, Dionna Amalie Glaze wrote:
>> +
>> +static void snp_handle_guest_request(struct vcpu_svm *svm, gpa_t req_gpa, gpa_t resp_gpa)
>> +{
> 
> Both regular,
> 
>> +
>> +static void snp_handle_ext_guest_request(struct vcpu_svm *svm, gpa_t req_gpa, gpa_t resp_gpa)
>> +{
> 
> and extended guest requests should be subject to rate limiting, since
> they take a lock on the shared resource that is the AMD-SP (psp?). I
> proposed a mechanism with empirically chosen defaults in
> 
> [PATCH v2 0/2] kvm: sev: Add SNP guest request throttling
> [PATCH v2 1/2] kvm: sev: Add SEV-SNP guest request throttling
> [PATCH v2 2/2] kvm: sev: If ccp is busy, report throttled to guest
> 
> http://129.79.113.48/hypermail/linux/kernel/2211.2/03107.html
> http://129.79.113.48/hypermail/linux/kernel/2211.2/03110.html
> http://129.79.113.48/hypermail/linux/kernel/2211.2/03111.html
> 
> But I don't see these on lore. Would you like me to repost these?
> 

Yes, please.

Thanks,
Ashish