From:   Gaurav Jain <gaurav.jain@nxp.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Horia Geanta <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>
Subject: RE: [EXT] [PATCH] crypto: caam - Use ahash_request_complete
Thread-Topic: [EXT] [PATCH] crypto: caam - Use ahash_request_complete
Thread-Index: AQHZLjOk6sG+TpMCPEejWeXjQJGx/66tFLyg
Date:   Tue, 24 Jan 2023 05:59:29 +0000
Message-ID: <AM0PR04MB6004BD5600952AB555261B72E7C99@AM0PR04MB6004.eurprd04.prod.outlook.com>
References: <Y8zmcwnwZOIoj8Vs@gondor.apana.org.au>
In-Reply-To: <Y8zmcwnwZOIoj8Vs@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9N/2MhsmMqgpHFIO8w+thYANm0kQw2i2KguKok6SQSyQ4jgjxXyWOJJ2b78Y?=
 =?us-ascii?Q?B5HHlVYH2VuzxaIwsAGSOZDbJ3k/UbBtGl6QktUqv3Qb+Sn86RK9UvRhgXxg?=
 =?us-ascii?Q?9MuFZXOaO8GXag/ib0j1heBtkjgMXwut8Y86DD1gphUbSZJVoSHv6TC6Zlmb?=
 =?us-ascii?Q?wCIdj+/cZKGDBay10eAscK7IrQr744H78TsCJZ5WTB2fHyETCWBON/B0n9pX?=
 =?us-ascii?Q?GRSSS2s0SzIxhV/nAAFx1UypgeiU09ht66lf2VFYBFExEqKvetSjU0dMJ35j?=
 =?us-ascii?Q?9Ey6JMx4uL7+mObwHkfTpxI0FmS702likML1l1kzB5DFTTqos8snwuiNJfqm?=
 =?us-ascii?Q?2PIdhoUjjZgfI+GzSiiTVUR5Rfo1iWz1CkqT/uoM4cH5rZDySIjoX+N55GIt?=
 =?us-ascii?Q?I37avy+cnCprLl7Mtgf0i4GIwTCRSxigjg0ze6LwXm1t+6gp9PK5fFeBvb/O?=
 =?us-ascii?Q?krb3GDHnc1aep0uDvhTB/iJW7FdK7kMIfOR+6oU2rsZu9C+h+eci/pOPg5xA?=
 =?us-ascii?Q?jHlSAwy0y9QdVN5Yv3QnZCqQ2HPfzcewixHgNQJgShy2pIYIVsVO2gI59xVY?=
 =?us-ascii?Q?jubKnYazei6GHrAosIGbbbEiglo1qxaVzp7K7A/Xdn0usaJqN8XYdVCRwZrd?=
 =?us-ascii?Q?Qv9fIfMK95fscLnCSnhhdDQmvPzV5ZiuIZt+4zTe4squB0/h0Udug1w1yCmK?=
 =?us-ascii?Q?g6+0cFBCqbR/1cJmj5hjS9jHWcj8wBM6qFpAn4p/ukobwO6Y2AHycBsWXhdy?=
 =?us-ascii?Q?8CmSsCfluPvNaliTjDFwzdua/k2gAkGNBOWu1owg382ZnfTbDJ20aGqFiQJ8?=
 =?us-ascii?Q?f2R07S23jF5WEgu4++YZRCPFvNNMCk7Gz+ajBGzk23gp6oX8GYuwdwCjH135?=
 =?us-ascii?Q?I77qvQryLV2aD02PTG/4Un86t6W6ju0RGyNXIfmNJqvlCgoI3hpwEvYj7XUW?=
 =?us-ascii?Q?LfavOPajhMpsrljh3JoInpgudpK6foCnUsoUlHE7MVSYGsb4dEcGnx4oixQ3?=
 =?us-ascii?Q?VOWp19KpeKhyMlSDOR1/0ITCtUZg34++owmMnASSftF5JHa5QH3Ds2KRHiLw?=
 =?us-ascii?Q?x5SO61c9cIaaCxADVTNtl/UoiH9PC393CY0zY2ifiRiNeZ1Meb7wBLnE2nmv?=
 =?us-ascii?Q?Ch/NhJOheTVufD/lksH0p/awSdHvO3grnB0/02Xe7uXTOEKhBgQd9S1wcjgP?=
 =?us-ascii?Q?fl/0w5UT/Xmt9IcNSczlmRyG8u9KZWYSJGjx7+DxQ73wQ/fKLwTL31CSBs2x?=
 =?us-ascii?Q?VUzcpWPcv4EKHplqr3pjHWyMFa5rQG4GS19dBeEjwv5zJf+tdMJKeE4RA+S9?=
 =?us-ascii?Q?xMIje/ENxMNFi9isuF895DneWnKQepGdMuP9s4NuV0Rlk+kY3bX7D5rEHtOB?=
 =?us-ascii?Q?K1u+sg1f82k5UHh+1+GdqgdfLT6ur1kW6gwbkQgClrxA9dzuAjncXbD0DUTl?=
 =?us-ascii?Q?0KjFULgAX8E40RPcfz23Zi6Ib+SqkDq2yXNY9vZ2ZiItfxEroU0SbyS12HAg?=
 =?us-ascii?Q?8Kwg/XyBkqwDhdXw3DlLukv1K+no8PYc50cBNdJFyqPvM6ynTlnY4Z+1vBEU?=
 =?us-ascii?Q?Joc2ru2zXrjzcrYiU6jglzkICrAJnpGupB+SsB+B?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6004.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b9aa43b-db41-4619-b88c-08dafdd02834
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2023 05:59:29.5602
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ohdhv0LQ2jmzcGIEROAGEH9sg1mM8w1yS1zO6gGXC9cLTWBeSfAhMaC5l2FSBmbsrYDuzS0QaGGcHt8fRkRXyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9675
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Reviewed-by: Gaurav Jain <gaurav.jain@nxp.com>

> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Sunday, January 22, 2023 1:02 PM
> To: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>; Horia Geant=
a
> <horia.geanta@nxp.com>; Pankaj Gupta <pankaj.gupta@nxp.com>; Gaurav Jain
> <gaurav.jain@nxp.com>
> Subject: [EXT] [PATCH] crypto: caam - Use ahash_request_complete
>=20
> Caution: EXT Email
>=20
> Instead of calling the base completion function directly, use the correct=
 ahash
> helper which is ahash_request_complete.
>=20
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>=20
> diff --git a/drivers/crypto/caam/caamalg_qi2.c
> b/drivers/crypto/caam/caamalg_qi2.c
> index 0ddef9a033a1..5c8d35edaa1c 100644
> --- a/drivers/crypto/caam/caamalg_qi2.c
> +++ b/drivers/crypto/caam/caamalg_qi2.c
> @@ -3419,7 +3419,7 @@ static void ahash_done(void *cbk_ctx, u32 status)
>                              DUMP_PREFIX_ADDRESS, 16, 4, state->caam_ctx,
>                              ctx->ctx_len, 1);
>=20
> -       req->base.complete(&req->base, ecode);
> +       ahash_request_complete(req, ecode);
>  }
>=20
>  static void ahash_done_bi(void *cbk_ctx, u32 status) @@ -3457,7 +3457,7 =
@@
> static void ahash_done_bi(void *cbk_ctx, u32 status)
>                                      DUMP_PREFIX_ADDRESS, 16, 4, req->res=
ult,
>                                      crypto_ahash_digestsize(ahash), 1);
>=20
> -       req->base.complete(&req->base, ecode);
> +       ahash_request_complete(req, ecode);
>  }
>=20
>  static void ahash_done_ctx_src(void *cbk_ctx, u32 status) @@ -3484,7 +34=
84,7
> @@ static void ahash_done_ctx_src(void *cbk_ctx, u32 status)
>                              DUMP_PREFIX_ADDRESS, 16, 4, state->caam_ctx,
>                              ctx->ctx_len, 1);
>=20
> -       req->base.complete(&req->base, ecode);
> +       ahash_request_complete(req, ecode);
>  }
>=20
>  static void ahash_done_ctx_dst(void *cbk_ctx, u32 status) @@ -3522,7 +35=
22,7
> @@ static void ahash_done_ctx_dst(void *cbk_ctx, u32 status)
>                                      DUMP_PREFIX_ADDRESS, 16, 4, req->res=
ult,
>                                      crypto_ahash_digestsize(ahash), 1);
>=20
> -       req->base.complete(&req->base, ecode);
> +       ahash_request_complete(req, ecode);
>  }
>=20
>  static int ahash_update_ctx(struct ahash_request *req) diff --git
> a/drivers/crypto/caam/caamhash.c b/drivers/crypto/caam/caamhash.c index
> 1f357f48c473..82d3c730a502 100644
> --- a/drivers/crypto/caam/caamhash.c
> +++ b/drivers/crypto/caam/caamhash.c
> @@ -614,7 +614,7 @@ static inline void ahash_done_cpy(struct device *jrde=
v,
> u32 *desc, u32 err,
>          * by CAAM, not crypto engine.
>          */
>         if (!has_bklog)
> -               req->base.complete(&req->base, ecode);
> +               ahash_request_complete(req, ecode);
>         else
>                 crypto_finalize_hash_request(jrp->engine, req, ecode);  }=
 @@ -676,7
> +676,7 @@ static inline void ahash_done_switch(struct device *jrdev, u32 =
*desc,
> u32 err,
>          * by CAAM, not crypto engine.
>          */
>         if (!has_bklog)
> -               req->base.complete(&req->base, ecode);
> +               ahash_request_complete(req, ecode);
>         else
>                 crypto_finalize_hash_request(jrp->engine, req, ecode);
>=20
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fgondor=
.ap
> ana.org.au%2F~herbert%2F&data=3D05%7C01%7Cgaurav.jain%40nxp.com%7C2c
> 291da8543f4910bd3b08dafc4ac495%7C686ea1d3bc2b4c6fa92cd99c5c301635%
> 7C0%7C0%7C638099695322344265%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM
> C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7
> C%7C%7C&sdata=3DhWeStOfWJ6Ukmo%2FeqL%2BRuLstFvJAjtByuGesO73BY0M%
> 3D&reserved=3D0
> PGP Key:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fgondor=
.ap
> ana.org.au%2F~herbert%2Fpubkey.txt&data=3D05%7C01%7Cgaurav.jain%40nxp.c
> om%7C2c291da8543f4910bd3b08dafc4ac495%7C686ea1d3bc2b4c6fa92cd99c5
> c301635%7C0%7C0%7C638099695322500501%7CUnknown%7CTWFpbGZsb3d8
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> 7C3000%7C%7C%7C&sdata=3DqCab7Bd9xy2uQAgWO3QsxzwHSOYGUM3uEary7b
> %2FSeTY%3D&reserved=3D0