From:   Peter Lafreniere <peter@n8pjl.ca>
To:     linux-crypto@vger.kernel.org
Cc:     Peter Lafreniere <peter@n8pjl.ca>, x86@kernel.org,
        jussi.kivilinna@mbnet.fi
Subject: [PATCH v2 0/3] crypto: x86/blowfish - Cleanup and convert to ECB/CBC
 macros
Date:   Mon, 30 Jan 2023 20:26:23 -0500
Message-id: <20230131012624.6230-1-peter@n8pjl.ca>
MIME-version: 1.0
Content-transfer-encoding: 8bit
Reporting-Meta: AAEteT6nhtSJC5yvk27zuBZexFe292wfs99ey1Dc5Q4RVBSj5Oet4txWpCt9HriU
 2JFcH9jpE1cuXPl86VaqnxBv9QdjGpYDFtph1sDJlcvyjlDrb0YEuERApNAoBIlX
 8cLtSla6+Yvz68Np0ttj9cE4z3o1VraUf8aO9361CXnxAtfo37x+kvCZxGTEQ8Wr
 UbFSnoZAd2fmTjw9vgaBAWg4hPpotiMFI6u92DytjqZsySfvbkghbiqnNaqbnJSp
 qiRjcaSwTJWofIakHPlswM3TpqSdhneYCk7IBscB3reC0AtmOQ5x1zKTcX7+G1oj
 8PSK6OBIZegI19yXrkh2c96GvwwRGBNGDjjWwEtZrHunngobteyHbDkcRAuqG7CA
 a7CUk7XwVn5JfUVj/2yvBkUxK5pMycnM0URc1nj8GEu4WUFYab+DK1AqK4MkcVbc
Precedence: bulk

We can acheive a reduction in code size by cleaning up unused logic in
assembly functions, and by replacing handwritten ECB/CBC routines with
helper macros from 'ecb_cbc_helpers.h'.

Additionally, these changes can allow future x86_64 optimized
implementations to take advantage of blowfish-x86_64's fast 1-way and
4-way functions with less code churn.

When testing the patch, I saw a few percent lower cycle counts per
iteration on Intel Skylake for both encryption and decryption. This
is merely a single observation and this series has not been rigorously
benchmarked, as performance changes are not expected. 

v1 -> v2:
 - Fixed typo that caused an assembler failure
 - Added note about performance to cover letter

Peter Lafreniere (3):
  crypto: x86/blowfish - Remove unused encode parameter
  crypto: x86/blowfish - Convert to use ECB/CBC helpers
  crypto: x86/blowfish - Eliminate use of SYM_TYPED_FUNC_START in asm

 arch/x86/crypto/blowfish-x86_64-asm_64.S |  71 ++++----
 arch/x86/crypto/blowfish_glue.c          | 200 +++--------------------
 2 files changed, 55 insertions(+), 216 deletions(-)

-- 
2.39.1