MIME-Version: 1.0
References: <20230131012624.6230-1-peter@n8pjl.ca>
In-Reply-To: <20230131012624.6230-1-peter@n8pjl.ca>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Tue, 31 Jan 2023 09:11:13 +0100
Message-ID: <CAMj1kXG7m9aYjStESRu7r-7qN0ursAi5jY33EpEOTLbPxUS8Ow@mail.gmail.com>
Subject: Re: [PATCH v2 0/3] crypto: x86/blowfish - Cleanup and convert to
 ECB/CBC macros
To:     Peter Lafreniere <peter@n8pjl.ca>
Cc:     linux-crypto@vger.kernel.org, x86@kernel.org,
        jussi.kivilinna@mbnet.fi
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 31 Jan 2023 at 02:26, Peter Lafreniere <peter@n8pjl.ca> wrote:
>
> We can acheive a reduction in code size by cleaning up unused logic in
> assembly functions, and by replacing handwritten ECB/CBC routines with
> helper macros from 'ecb_cbc_helpers.h'.
>
> Additionally, these changes can allow future x86_64 optimized
> implementations to take advantage of blowfish-x86_64's fast 1-way and
> 4-way functions with less code churn.
>

'future x86_64 optimized implementations' of blowfish? That is a joke, right?

> When testing the patch, I saw a few percent lower cycle counts per
> iteration on Intel Skylake for both encryption and decryption. This
> is merely a single observation and this series has not been rigorously
> benchmarked, as performance changes are not expected.
>
> v1 -> v2:
>  - Fixed typo that caused an assembler failure
>  - Added note about performance to cover letter
>
> Peter Lafreniere (3):
>   crypto: x86/blowfish - Remove unused encode parameter
>   crypto: x86/blowfish - Convert to use ECB/CBC helpers
>   crypto: x86/blowfish - Eliminate use of SYM_TYPED_FUNC_START in asm
>

Tested-by: Ard Biesheuvel <ardb@kernel.org>
Acked-by: Ard Biesheuvel <ardb@kernel.org>


>  arch/x86/crypto/blowfish-x86_64-asm_64.S |  71 ++++----
>  arch/x86/crypto/blowfish_glue.c          | 200 +++--------------------
>  2 files changed, 55 insertions(+), 216 deletions(-)
>
> --
> 2.39.1
>