Date:   Tue, 31 Jan 2023 11:34:37 +0100
From:   Corentin LABBE <clabbe@baylibre.com>
To:     troy.lin@rock-chips.com, shawn.lin@rock-chips.com,
        hl@rock-chips.com, ty@wevs.org, mike.rudenko@gmail.com
Cc:     "Jason A. Donenfeld" <Jason@zx2c4.com>,
        linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Heiko Stuebner <heiko@sntech.de>,
        linux-rockchip@lists.infradead.org, robin.murphy@arm.com
Subject: Re: [PATCH] hw_random: rockchip: import driver from vendor tree
Message-ID: <Y9juvficPxFUfgHD@Red>
References: <20220919210025.2376254-1-Jason@zx2c4.com>
 <32f8797a-4b65-69df-ee8e-7891a6b4f1af@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <32f8797a-4b65-69df-ee8e-7891a6b4f1af@arm.com>
Precedence: bulk

Le Tue, Sep 20, 2022 at 10:35:44AM +0100, Robin Murphy a ?crit :
> On 2022-09-19 22:00, Jason A. Donenfeld wrote:
> > The Rockchip driver has long existed out of tree, but not upstream.
> > There is support for it upstream in u-boot, but not in Linux proper.
> > This commit imports the GPLv2 driver written by Lin Jinhan, together
> > with the DTS and config blobs from Wevsty.
> 
> Note that Corentin has a series enabling the full crypto driver for 
> RK3328 and RK3399[1], so it would seem more sensible to add TRNG support 
> to that. Having confliciting compatibles for the same hardware that 
> force the user to change their DT to choose one functionality or the 
> other isn't good (plus there's also no binding for this one).
> 
> Robin.
> 

Hello

I am very interested on how this serie was tested and which tools was used to ensure output was random.
And how did you get that CRYPTO_V1_TRNG_SAMPLE_PERIOD(100); was the best choice.

Thanks
Regards