Message-ID: <7d6effd4-4109-184c-064e-e606b9dcd200@amd.com>
Date:   Tue, 31 Jan 2023 09:21:41 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 17/32] crypto: ccp - Use request_complete helpers
Content-Language: en-US
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Jesper Nilsson <jesper.nilsson@axis.com>,
        Lars Persson <lars.persson@axis.com>,
        linux-arm-kernel@axis.com,
        Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,
        George Cherian <gcherian@marvell.com>,
        John Allen <john.allen@amd.com>,
        Ayush Sawal <ayush.sawal@chelsio.com>,
        Kai Ye <yekai13@huawei.com>,
        Longfang Liu <liulongfang@huawei.com>,
        Antoine Tenart <atenart@kernel.org>,
        Corentin Labbe <clabbe@baylibre.com>,
        Boris Brezillon <bbrezillon@kernel.org>,
        Arnaud Ebalard <arno@natisbad.org>,
        Srujana Challa <schalla@marvell.com>,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
        qat-linux@intel.com, Thara Gopinath <thara.gopinath@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Vladimir Zapolskiy <vz@mleia.com>
References: <Y9jKmRsdHsIwfFLo@gondor.apana.org.au>
 <E1pMlat-005vmv-9T@formenos.hmeau.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <E1pMlat-005vmv-9T@formenos.hmeau.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SStLS2FYcm1wM1dvL2IyNjRIZE1ZNVhGUWpuOWFLSlJOMlluWC9iSkprLzZs?=
 =?utf-8?B?K1ppSVJiNE5kZG1CUUd3ZjZTdzkwSGVsY0xpN1V0dkd0N0c1a2NscWVWYXlB?=
 =?utf-8?B?ZldRS1FvMzJGVEVSa255TXBHdGRFaU1jSWNMOHBRN0pMODdieVZIb28vako0?=
 =?utf-8?B?eXRBbGVKOWlDZ2hMTDhEaXJUUHFYa1d3Q1JDc2V6T01SMWMxWkxDRWpvbjBq?=
 =?utf-8?B?SmJ2TVQwQmsrdkp3L1g3M2VHK1liUlVLMDM0ZGVGeTZhZTZPK25nNy9TSGti?=
 =?utf-8?B?UUxzVWRkWEMvN0ZXWnBVMXh5aG9tVGh6N2xvamQ4UW0zWWs2R0tvekN0N1l3?=
 =?utf-8?B?WmtGWHlaYzRNTU01cEtsWWhIK2NLRno3QWd3QmRoTzRJanBUU3pDQmF1QzMw?=
 =?utf-8?B?K2VwMWd3VGRSc3crbHJmelRRVCsyZ3ZrSk03ZlhYK1lpWFlOYWdZV0FjZGt5?=
 =?utf-8?B?bVpEVFZOczNQVy9ScWxLMWE5V2huaTZaWm5VMFo0U1R3UmFrVnVCRU1KUk4v?=
 =?utf-8?B?d0NTSDU5Zi9xaFkwRXhlOWN0Ynd4NzVHNmJDaTh6bXJOaVNxRCtyTUpsZmdj?=
 =?utf-8?B?aXppbG81NE1jN0xpTkJ4WjRzR20vdmtzYk9zc2JxankwRjBGNGFLMFVTN3h2?=
 =?utf-8?B?M2pUWXhYQmNlQkd6eWFVUVZ5SmxKc1YwZXUrVEdXMUJqeEpFWnV0RWZScjVK?=
 =?utf-8?B?YjUrNlRPS3FFZ25VVmgzcWRvQnpURG9UME53OWJpSnpRNm5qcSt0LzdMejMz?=
 =?utf-8?B?V3BTRVBZRHJjS0VIYVJFaVpnR0FUSFkrTmlRMWp0UzZGNGpTV2JtY3M5WU14?=
 =?utf-8?B?OVlCM3pCVTJPZ1A4RE50am1lTXNxOUNpaHFEclRUZ1haRDc4R1VXcXVXcW5P?=
 =?utf-8?B?NFVOcmtkNlFUUnFwaGFkcFdGMCsxSDI3NGNaVzJibzZBYllJWVJUUmNGdjVk?=
 =?utf-8?B?eTFsbFNqT09rWTRhSXhQdHVBUjJPZHl4eFh6OXFZVTFIMlRkZmtiUGVnRmdO?=
 =?utf-8?B?YkJKQUhCMVRSTVhWSnJXNzJFaFN0Q3l0OVFoVnFXVjAxQXF2cWxSR0lBMGRz?=
 =?utf-8?B?dDZIa202V2Z6anR5UWFHSGloNEp3UW0rT2I1VTZBN2ZOc3lRT0JEdllMRERo?=
 =?utf-8?B?RGtsOW5PSWZGK3lwVkRQR2dXMnVQenJVUHpjQWVBU24ydGhQNXFsRW80djdX?=
 =?utf-8?B?dkNScFNDVkR6WG4wS0lLc0ltdHZlWDAvQzFuT2czVVM4MTVJOHRWK3VjYXN2?=
 =?utf-8?B?QXB2TUJCRmVkQi9DYXoydXE0T3dCM2JKclVPSXJSMW1IcEprQWt5ZjdVSkxK?=
 =?utf-8?B?UTUrcmthK2hyZktlZlV2WnlyVmpMdUY5MTEvWkxzdU01K21lV1N2VkZFUGtz?=
 =?utf-8?B?dW9GVVMxQjd0NXdmUFcwM0kvZ3ZSbzZ6OGxaOExvaU0xSDhwYjhpVERKdHM0?=
 =?utf-8?B?MWRnWU8xTHNpMTRXalZFUEJKTzA5aFo3cEZGV2k3dUFKR2crOGlRb2VnLyty?=
 =?utf-8?B?eEVIRStmU1JGcDRpaEQvZE5uTkRrNDlrd041Z3U3SHlMNUFlOG1UZ1Q4cWpW?=
 =?utf-8?B?cDNRSXVIZllCK0hrZ3prZy9jaUUxQnlrQnNocEFnOThVenFzUjdpeXhmczBq?=
 =?utf-8?B?L1RUSnJmTkpuNllQUTJ5UUkrZGlUM3hpUy9td1UvRzY1dzhHYnNMeEw0REIr?=
 =?utf-8?B?TGhlc0xOQW5RNkRYMHZaZmgyWFduaGlUNndqQjBZUmpKSllkRzJaaHQ1TnlC?=
 =?utf-8?B?N1NNdFNtd0xmSmRRTlI5NDRnajV0dmNxb09iZ2NCMGM0L25SRGxlQ3VnRFI0?=
 =?utf-8?B?OXF1MWRyNk1pRzhXcXpSZnhMNmN5Q3JmMVFrRXVGNmVwQnhoYzJ1U0hEZTZq?=
 =?utf-8?B?Q09zZXBSaHh1QVR2L2gvZGo1UmI2TmloMURHOTFUVVRwK1FBN2huNUQvZ0dB?=
 =?utf-8?B?Tk9ndUlXdStJYVdvOS95VnR3NmtQOXhlOUJOY1ZXSHhjVjg3cnBBMUF1ZTI3?=
 =?utf-8?B?UVp3aDBtNXUwVTkvRU41QWE1MWRrNnp6bG52VVljaFlCRGZ0VUtwelArbFFh?=
 =?utf-8?B?c3dTM2ZjaURNSk05aFZacVZydnU1ajBpcVdQUVpnbXRneG0xVWIxWEVrOGZs?=
 =?utf-8?Q?R+KLOom27ik2/KomAjGidIjv9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a3ace3d-9db5-4ea0-6256-08db039edd94
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 15:21:46.1960
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VJfznaO+OMa9GZ0XsHUoRhrop6uPlqYgMpYM/LSM1+aLFuvu+xQKWhEMuxYf8UJjvZBe/uqdvAD2QRIU0zA+bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6006
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 1/31/23 02:02, Herbert Xu wrote:
> Use the request_complete helpers instead of calling the completion
> function directly.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
> 
>   drivers/crypto/ccp/ccp-crypto-main.c |   12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/ccp-crypto-main.c b/drivers/crypto/ccp/ccp-crypto-main.c
> index 73442a382f68..ecd58b38c46e 100644
> --- a/drivers/crypto/ccp/ccp-crypto-main.c
> +++ b/drivers/crypto/ccp/ccp-crypto-main.c
> @@ -146,7 +146,7 @@ static void ccp_crypto_complete(void *data, int err)
>   		/* Only propagate the -EINPROGRESS if necessary */
>   		if (crypto_cmd->ret == -EBUSY) {
>   			crypto_cmd->ret = -EINPROGRESS;
> -			req->complete(req, -EINPROGRESS);
> +			crypto_request_complete(req, -EINPROGRESS);
>   		}
>   
>   		return;
> @@ -159,18 +159,18 @@ static void ccp_crypto_complete(void *data, int err)
>   	held = ccp_crypto_cmd_complete(crypto_cmd, &backlog);
>   	if (backlog) {
>   		backlog->ret = -EINPROGRESS;
> -		backlog->req->complete(backlog->req, -EINPROGRESS);
> +		crypto_request_complete(backlog->req, -EINPROGRESS);
>   	}
>   
>   	/* Transition the state from -EBUSY to -EINPROGRESS first */
>   	if (crypto_cmd->ret == -EBUSY)
> -		req->complete(req, -EINPROGRESS);
> +		crypto_request_complete(req, -EINPROGRESS);
>   
>   	/* Completion callbacks */
>   	ret = err;
>   	if (ctx->complete)
>   		ret = ctx->complete(req, ret);
> -	req->complete(req, ret);
> +	crypto_request_complete(req, ret);
>   
>   	/* Submit the next cmd */
>   	while (held) {
> @@ -186,12 +186,12 @@ static void ccp_crypto_complete(void *data, int err)
>   		ctx = crypto_tfm_ctx_dma(held->req->tfm);
>   		if (ctx->complete)
>   			ret = ctx->complete(held->req, ret);
> -		held->req->complete(held->req, ret);
> +		crypto_request_complete(held->req, ret);
>   
>   		next = ccp_crypto_cmd_complete(held, &backlog);
>   		if (backlog) {
>   			backlog->ret = -EINPROGRESS;
> -			backlog->req->complete(backlog->req, -EINPROGRESS);
> +			crypto_request_complete(backlog->req, -EINPROGRESS);
>   		}
>   
>   		kfree(held);