Message-ID: <682c0bf9-ccf7-9660-21fe-925ef63c5fbb@amd.com>
Date:   Tue, 31 Jan 2023 15:21:24 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH RFC v7 52/64] KVM: SVM: Provide support for
 SNP_GUEST_REQUEST NAE event
Content-Language: en-US
To:     Alexey Kardashevskiy <aik@amd.com>,
        "Kalra, Ashish" <ashish.kalra@amd.com>,
        Michael Roth <michael.roth@amd.com>, kvm@vger.kernel.org
Cc:     linux-coco@lists.linux.dev, linux-mm@kvack.org,
        linux-crypto@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
        jroedel@suse.de, hpa@zytor.com, ardb@kernel.org,
        pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com,
        wanpengli@tencent.com, jmattson@google.com, luto@kernel.org,
        dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com,
        peterz@infradead.org, srinivas.pandruvada@linux.intel.com,
        rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com,
        bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name,
        ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com,
        dgilbert@redhat.com, jarkko@kernel.org, harald@profian.com,
        Brijesh Singh <brijesh.singh@amd.com>
References: <20221214194056.161492-1-michael.roth@amd.com>
 <20221214194056.161492-53-michael.roth@amd.com>
 <aab7ed11-870e-579d-9328-4c32d9936392@amd.com>
 <66039193-14ca-5edb-d8d4-ca732d8c13a6@amd.com>
 <119075dd-5f3e-a393-f543-6cdfd34cd337@amd.com>
 <385016f9-e948-4f7f-8db3-24a0c0543b3d@amd.com>
 <55e5f02f-4c1f-e6b0-59ba-07abc4d3408f@amd.com>
 <81037a58-6b5c-cde4-79fe-3686d9b8a551@amd.com>
 <b0baa6ee-ea6d-3a30-d5fb-3ec395896750@amd.com>
 <dbcb6666-270a-4867-6de7-73812d32fd8c@amd.com>
 <7fb25176-3752-1be3-66d4-a7f5a0e1617a@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <7fb25176-3752-1be3-66d4-a7f5a0e1617a@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlZPTjJla3BEWVRlT25JM3RzaGE4VEV5MG53aHBtMnlKOVpPWERrWlNaNENy?=
 =?utf-8?B?NzZvR0p4M2o3UmhPTGdZM1QyMUdha2lrc2M4MHRMWFp2bzRVSUc0VHVvY3o4?=
 =?utf-8?B?MnJYb01QeFdjRTM1aVpMdm1KUTNCc2N2c1RPSDFQYW5EejFvVlJNOGJOaHF2?=
 =?utf-8?B?aTdZRVRhMDV3b2R1NGsyYi9tR0xPTldIQkV1ZVhLL0Nndm91alB1NU8rdkIr?=
 =?utf-8?B?UStUenhneVk2dzR1WmFOb0Jwc3U3MUo2M3ZUdks3ZmxIRjc0SmlGamZlbWMv?=
 =?utf-8?B?V3dkbnZ3N1JZb0VXR25qWWV3Q01rNldLdGNaZzQ0NGYwcWxtbmt3VHl6MG1l?=
 =?utf-8?B?MlB2NFdjYTlCVWs4Q1RMT0h2VlZDSEtWcU9vcnZxaGxENlUvOGs3ZGYwenZh?=
 =?utf-8?B?WVBPOE9BT0xJdWtZaHlmc0duTkR0UGZZNHNEMUZTblQwQzB6N2k0S05LUGkx?=
 =?utf-8?B?NTA1TTRQK0Jla0s3cnlqeXE4dWdsSUFibE1YK2lhdVVmQmVQcFZNRzZDNWly?=
 =?utf-8?B?NktrUTUvWXo1dTVmcEVkMmtOMTI2d1FISERFWStKQXEvalI5Q3ZENHB3SGxq?=
 =?utf-8?B?M1hLdzBVSkxhcEFGc3BQR09ydWgzQ09LOVVVSE54ZGpHcjZTbWFuclQ1UFVD?=
 =?utf-8?B?SUlzU3pvSXBHVS9LNHhEVUYraWsyeHArRERySUJ0cy9wcUkxcHh1YTg4NzlJ?=
 =?utf-8?B?Qjl5d29QWEk0WVlQK005K3hxVVA5ZU1zNWJJU0JDc2xCL3docEEzWkY4Y3VN?=
 =?utf-8?B?cWNRbTNkQTNETUw1RzBkNTB3OGlNNmpXQmNCejcyc09pbzRkSldvanYvekFr?=
 =?utf-8?B?ZmllUXpWdmNJMU5lMlRSdW1pdEdsRC8zZTJlSjBJb0Z0LzY0bTUrSFUxQlNH?=
 =?utf-8?B?OVJCM2QxbDZFam00enFsVHdhbUJ0RUQ4NVMva3R3K2wyd3pLQnM0cXJjYmk1?=
 =?utf-8?B?cFEzb1ZRM0dMYXBEc0lPVVZub29pem4wUFpmTWxWMDBTeExDcDBpWVVITE91?=
 =?utf-8?B?TUtiK3I2UElqYlVUZFArQVFvWHZEWmlqNW5sWDRvdFA1eU40TmxXU1dtU0NP?=
 =?utf-8?B?UTh2YzVZemlYREloNW1aWFFhcDN1MDRRZVlGNHd2WkNwdS82bE9JVGw3SXQr?=
 =?utf-8?B?WFEyWW9JRmJaNWlzV0tYREZNbE5MdS95MVhZSHU3MzVDN0tUQ0R1NURvdXhq?=
 =?utf-8?B?WXZ1RzdrL1BUWEJCZllwOHNUYWxGY04xQ1YwVEJ1M3laZXA1K3ZLbnl4Z2ZQ?=
 =?utf-8?B?S2IwaWF3RW5oaXZZMHI1WW9kWEZ3M0E0YkdtTHRxLzVueDZ1dCtnaGhhMksz?=
 =?utf-8?B?ZTRZbll6bVdlZ0hsVm9xQ2xTZXNObnBFdkVaWHNHS2FvSmtZWlB5b09pYXQ1?=
 =?utf-8?B?djlyMkxzcUFqU3h1d00rN0lvb09pTU9yUHV3T0ZoL1FQeG5Fc3BXa2s1Q2xZ?=
 =?utf-8?B?RkRZb0NzNm9oRFJIM3hNcm1qWHVnZ01ITzl5SDBxcDlXa0lmKzIwQ0c1amNy?=
 =?utf-8?B?clpMRit3bndZTXVrbWpMSW5JU29zQ25RNlIySWtqUm1CNGxCU3VCYkRxWjkx?=
 =?utf-8?B?WUNuVERhelVjZ0pIYzJiZmFFdXJCNTdzeFdwU3lWRmppRFRweFFRQitNTGZQ?=
 =?utf-8?B?ZTJyVVVvYnFhK3RBaVUyS0VBV3dBbm1yT1Vaa1VzSnZHRDZXSnBMdDJYMFFs?=
 =?utf-8?B?K3hWY1NaTzMzUTNZQk41ZmlmNUNsNWJvWC9RK3p6TWxvaDdmdGp4NXFjTXBL?=
 =?utf-8?B?WnFwWGFiWHo4djZEcEIzcHM1TmQwZzR0TTIvaFVodE9aQldTMFkwVlllQW5P?=
 =?utf-8?B?RjhXeE1PM2xCMHY5WldBZU9CTnY5M0h4VExpcDVoTk4yOTFPcE0yNFp6UjNp?=
 =?utf-8?B?MUhTbTl4SjdKRGJjTWZoWXlvY2txdnRFWmdjWjYzdFZxdDI4WDVVVGtxM3kr?=
 =?utf-8?B?RTlRQ1ZlNml3bFZFN2RqbGdnSnptYVlZSnQzTXpkQ2dZc1JJN3M0S0dVdTZQ?=
 =?utf-8?B?UWlrZndwQVp1ditiR3EyMXpGWDNPM29BSW9KWXJ3T0hHZUdJMGhzcWVLcUt3?=
 =?utf-8?B?Qno4Y1JndzVDNFhLV0JvOFRXc0NnWCtCTGQ1K3dtdkJGNDhKdm9oUXpGVGZi?=
 =?utf-8?Q?Gza8rG5ss08L9jy6QWz2bdfui?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8411d55-62bc-432a-2c89-08db03d11dcf
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 21:21:28.9033
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IhLaeXGotpDqq1qYEWbHhp1F/g2aBM7YVFqrGvYp38SLi8E03Xf8keTuqDRlWp2oI2sR4oY8SQPnp6NC/4aWTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8171
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 1/31/23 14:21, Alexey Kardashevskiy wrote:
> On 01/02/2023 03:23, Tom Lendacky wrote:
>> On 1/30/23 19:54, Alexey Kardashevskiy wrote:
>>> On 11/1/23 13:01, Kalra, Ashish wrote:
>>>> On 1/10/2023 6:48 PM, Alexey Kardashevskiy wrote:
>>>>> On 10/1/23 19:33, Kalra, Ashish wrote:
>>>>>> On 1/9/2023 8:28 PM, Alexey Kardashevskiy wrote:
>>>>>>> On 10/1/23 10:41, Kalra, Ashish wrote:
>>>>>>>> On 1/8/2023 9:33 PM, Alexey Kardashevskiy wrote:
>>>>>>>>> On 15/12/22 06:40, Michael Roth wrote:
>>>>>>>>>> From: Brijesh Singh <brijesh.singh@amd.com>
>>>>>>>>>>
>>>>>>>>>> Version 2 of GHCB specification added the support for two SNP Guest
>>>>>>>>>> Request Message NAE events. The events allows for an SEV-SNP 
>>>>>>>>>> guest to
>>>>>>>>>> make request to the SEV-SNP firmware through hypervisor using the
>>>>>>>>>> SNP_GUEST_REQUEST API define in the SEV-SNP firmware specification.
>>>>>>>>>>
>>>>>>>>>> The SNP_EXT_GUEST_REQUEST is similar to SNP_GUEST_REQUEST with the
>>>>>>>>>> difference of an additional certificate blob that can be passed 
>>>>>>>>>> through
>>>>>>>>>> the SNP_SET_CONFIG ioctl defined in the CCP driver. The CCP driver
>>>>>>>>>> provides snp_guest_ext_guest_request() that is used by the KVM 
>>>>>>>>>> to get
>>>>>>>>>> both the report and certificate data at once.
>>>>>>>>>>
>>>>>>>>>> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
>>>>>>>>>> Signed-off-by: Ashish Kalra <ashish.kalra@amd.com>
>>>>>>>>>> Signed-off-by: Michael Roth <michael.roth@amd.com>
>>>>>>>>>> ---

>>>
>>> And GET ioctls() return what SET passed on (not something the firware 
>>> returned, for example), what is ever going to call SET? The userspace can 
>>
>> As stated above, the firmware already has the information needed to sign 
>> the attestation report. The SET IOCTL is used to supply the certficates 
>> to the guest for validation of the attestation report.
> 
> 
> Does the firmware have to have all certificates beforehand? How does the 
> firmware choose which certificate to use for a specific VM, or just signs 
> all reports with all certificates it knows?

 From the SNP API spec, the firmware uses the VCEK, which is derived from 
chip-unique secrets, to sign the attestation report.

The guest can then use the returned VCEK certificate, the ASK certificate 
and ARK certificate from the extended guest request to validate the 
attestation report.

> 
> 
>> This reduces the traffic and complexity of the guest requesting the 
>> certficates from the KDS.
> 
> Guest <-> HV interaction is clear, I am only wondering about HV <-> FW.

I'm not sure what you mean here. The HV doesn't put the signing key in the 
firmware, it is derived.

Thanks,
Tom