Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E65C61DA4 for ; Thu, 2 Feb 2023 03:10:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229882AbjBBDKS (ORCPT ); Wed, 1 Feb 2023 22:10:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229612AbjBBDKR (ORCPT ); Wed, 1 Feb 2023 22:10:17 -0500 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C9661E2A8; Wed, 1 Feb 2023 19:10:16 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1pNPz1-006b2v-38; Thu, 02 Feb 2023 11:09:56 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 02 Feb 2023 11:09:55 +0800 Date: Thu, 2 Feb 2023 11:09:55 +0800 From: Herbert Xu To: Neal Liu Cc: Joel Stanley , Andrew Jeffery , "David S . Miller" , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH-next] crypto: aspeed: fix type warnings Message-ID: References: <20230202025600.2598548-1-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202025600.2598548-1-neal_liu@aspeedtech.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Feb 02, 2023 at 10:56:00AM +0800, Neal Liu wrote: > > @@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf, > static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev) > { > struct akcipher_request *req = acry_dev->req; > - u8 *sram_buffer = (u8 *)acry_dev->acry_sram; > + u8 *sram_buffer = (u8 __force *)acry_dev->acry_sram; Wouldn't it be better to keep the iomem marker and then use readb on sram_buffer? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt