From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
        "David S . Miller" <davem@davemloft.net>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: RE: [PATCH-next] crypto: aspeed: fix type warnings
Thread-Topic: [PATCH-next] crypto: aspeed: fix type warnings
Thread-Index: AQHZNrHmMT+Cp3JQVkSaFLeXTAj48q66+kKAgAAC+UCAAAFlgIAAAKqg
Date:   Thu, 2 Feb 2023 03:29:40 +0000
Message-ID: <TY2PR06MB3213C9EDE5B9A07F63B5295880D69@TY2PR06MB3213.apcprd06.prod.outlook.com>
References: <20230202025600.2598548-1-neal_liu@aspeedtech.com>
 <Y9spg/66x/wQ3x+g@gondor.apana.org.au>
 <TY2PR06MB321395387369059BC9F9722E80D69@TY2PR06MB3213.apcprd06.prod.outlook.com>
 <Y9stLeguRuQVpbiD@gondor.apana.org.au>
In-Reply-To: <Y9stLeguRuQVpbiD@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cbFwFZ0ls0Jfj0dMlhcJbRPDfx4wuHM5qWWMPVi26stTtNXsK9XfiX7Lljhk?=
 =?us-ascii?Q?IhKJR3p+qzfYVUn0sWHv4iEQxmwRzi4PNmCzSpBE9BEmW8YitvAdiisdja5b?=
 =?us-ascii?Q?CkB0JEKdgwWBQmZWu2YZhbYKJLCurSDwYUim/+2qkFmIg8EI8BbS/KKI9649?=
 =?us-ascii?Q?Zivf4EDfEex/Wdxg5yB8Ug/KEZ78vdsHAS9gbudKCGXFA+88+EmmiotGDd5t?=
 =?us-ascii?Q?Abs8OZPpBx1qEut8ygzKjvnbs6B2A1/SYB60zn9IedcQ6eA1i78xRl7tPH4p?=
 =?us-ascii?Q?y9pGue0ThE0vUZbqL2xo9T7Z/f0E+NeCB5wW2mDu/GB9JTUx4l0VwrJnjh1W?=
 =?us-ascii?Q?e3NpysRK3cNWQmxC31SMzc+fIV6vvYSV3g8SE3JE6pHlkamkjaPs6fjaVJzd?=
 =?us-ascii?Q?qNsIpvT+8dBLNbwaMYU8QxHn0DyqDcMSx74YQHsOTanUZ2+JQzeJsMO7GCkZ?=
 =?us-ascii?Q?X4ao338QKRCt5JllzFP61TragOQibrOh9fLPdN7kteaKDkpR1JSEoTzxNobs?=
 =?us-ascii?Q?CDU9G26MSpLcei9v7rCfaYc0JRsZsXjLwS/HHHUVt0tnJHV1DRwAaoroxCzP?=
 =?us-ascii?Q?cKOAJGwrcDQvP/KlUM2GpPd/B0UkLvnN7H8kbWfXV3gpxlUokkpA+eBYLqFH?=
 =?us-ascii?Q?0859y1DQceOTx5j8USCChRldBtARvMOiA3n/FxRejHow7/e6fJ5Hr3+i4l5X?=
 =?us-ascii?Q?2EEw++wiH+mdmIjpDbJcmatWO7QQkVemonvghnLstgPVYzzeYN0d7581qefq?=
 =?us-ascii?Q?X2Edu7DfFmrEZJZ8LXanq/Tb3+9lpegWANVZCsb8u+GrMwB8FXs0AJZYMq9B?=
 =?us-ascii?Q?AVXI/PqPtiYzRiD4fJwlRAVsRHEW6ZI80TEN26OnAFJ5RUaS/ainRLIRT3zf?=
 =?us-ascii?Q?MsAOn6UeAFcsliGOLQBvJoswOJYqTjpN7PwBjqdKO4YCuiK3TqzsR7mizysc?=
 =?us-ascii?Q?GiVan82l7Qkz+13SvO1qJao2UfWyhbw4Qlm4rMf15vXlKO2KfsUzcJ9jWrXJ?=
 =?us-ascii?Q?qtjvo+q9Kh7hn0hhdQ7tryCNuXL/JTfa8djn/4Hw0OlQPx6jdMPXLqncMPvO?=
 =?us-ascii?Q?pXVA+iTgQFJT/0ytubCIHyAW6hajCnJvag2wpHYMBvAdpNkStTDzgSN/a8WM?=
 =?us-ascii?Q?AExAC6Xzp2eJKcaPZO0xFk0ABYUYOfoVEsSgF8Z45bcfbTrAMGZMVgHprxHC?=
 =?us-ascii?Q?r53Zfp2C8WpKi3IdNzLG+bQYoEm+WV3NyXHJBJW0kV2M1//NTEOvBoJLmW/B?=
 =?us-ascii?Q?+QXsRdCQ7tvQ9IphtlmNPZdqFOFATczxCvPOiQ28WOugHa/URKp7Zbs1dlsF?=
 =?us-ascii?Q?AMjUjCVSxsk1dkK0whcIWbAI8GjmlGwh9v+SUFw+v907eJnpSLwfdX1rRNyA?=
 =?us-ascii?Q?rFHGNGALikuSeDXqm7vhuNfygcvQYDSE5BZomNDE5ZqrqGDJ31OS0MJ06q5H?=
 =?us-ascii?Q?aXfkysDAUA9E2fI9Q5JATR20Lh79JXtQN88Ebmq4+6qDuCogU6+0+ZQGZxwV?=
 =?us-ascii?Q?tg9QnRP2ppLAVE2kiTryYXMVd9aRciJExHXQv4DuuH5LuaBVZbBJbG4O1DtF?=
 =?us-ascii?Q?Q0Ahmk1ic6sheQylUo3gEWE+RKWtBJi+9pujSHvr?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3213.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35e7c305-3260-47f1-35e1-08db04cdb82f
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 03:29:40.7809
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8bxGOH/rv9+1kDTK0JnReINahd+XAqGS9pOz0TeMa0mlf6tkbK45pOOpebwUgI7SSsTUMK4bU7LHhg1lZgetqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6158
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> >
> > I cannot tell which way is better. Do you prefer to keep the iomem mark=
er?
>=20
> The whole point of iomem is to prevent you from directly dereferencing th=
at
> memory.  So casting it away to remove the warning simply defeats its
> purpose.
>=20
> If you're worried about the overhead of readb perhaps you can look into
> readb_relaxed after considering the effects of the barriers.
>=20
Thanks for the information. I'll send next patch as you suggested.

-Neal