Message-ID: <d49fc5ba-b581-0051-bd82-1e7a4daae91b@amd.com>
Date:   Thu, 2 Feb 2023 13:39:14 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH RFC v7 11/64] KVM: SEV: Support private pages in
 LAUNCH_UPDATE_DATA
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>, Michael Roth <michael.roth@amd.com>
Cc:     kvm@vger.kernel.org, linux-coco@lists.linux.dev,
        linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
        jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com,
        ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com,
        vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
        luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com,
        pgonda@google.com, peterz@infradead.org,
        srinivas.pandruvada@linux.intel.com, rientjes@google.com,
        dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz,
        kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com,
        marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com,
        alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org,
        ashish.kalra@amd.com, harald@profian.com
References: <20221214194056.161492-1-michael.roth@amd.com>
 <20221214194056.161492-12-michael.roth@amd.com> <Y9qt50zW+eJcz7cm@zn.tnic>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <Y9qt50zW+eJcz7cm@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WndqUjMxSDROV3F1bktpdnJCUXQzTVAxaUxQTTJxU0crL0JJZnc4M25vR2ND?=
 =?utf-8?B?NVJLak9xeEZKa2IySlFORjVBd0RRVzRSa3FIZGUrZkpyb0FzejJPQzlKT3N2?=
 =?utf-8?B?dzl3WXlydWNybEptWUhTVTBobm1qZzRFODU0VldYeGl6S2p2c09HWDdZVHRN?=
 =?utf-8?B?Y0tWWUFZYk5FdXk5dFpaTWFwaWtoaXlmdEllK1hueVJIYkovWmdoUkxmN2Er?=
 =?utf-8?B?b2tJemxnUXdhZXZwMG5qNzdPdllQZ2lzOGxYVEVJY3RzTld1SnBaT3Zvc1NL?=
 =?utf-8?B?SE11dXJXUmphVFl2bWc0NHFqWHhVZFljbGV2MitYMzR4UW94NlpjZHNpc1RF?=
 =?utf-8?B?N3N3dHdiNXVhcGFGaDhMYlhMTUNlQWd1STRkZ3hGWmV5ekpLVmdxWWFhSlg3?=
 =?utf-8?B?VG5QVDUrc201cC9jUXZpTVZxbTQ4Y1ZyME41VW9GaDdvdjBsa0Q1SjVwSHpG?=
 =?utf-8?B?VWUrb2MzbEhidGRnbGhuUHBTd1UzNWV0aUU0c0FTdDYxdjFmREhYbjY3ZS8w?=
 =?utf-8?B?TzRjQmQ1ZDVrT200N3ZpVWt1cm1CYkdMUmpyaWxyQ2cxakhGanVkMTRDNDJ1?=
 =?utf-8?B?QVFBck5abEZ0NFJ4bzlKanBWWTVuNjhXWDJNNmJGZU9rOEdwcmpHTG1obnhr?=
 =?utf-8?B?R3JLLzh2QnJrR1JZa3hUY0hjd2pCR0hIV2tRYkVueW1palpsNVZja3ArNC9a?=
 =?utf-8?B?OEpLOWI4UmF2blRQbzhWTzcxWGRmZmtNVm56YzgzUnl6bHB6RkxRVG0rVTNo?=
 =?utf-8?B?Kys1UHg5MDk4U2xyVEkrRytBYlZxT1VXTU1KMW5zK3JBK3Z1R0p3cmJsTGkv?=
 =?utf-8?B?cGdsYmVrVzNwVXRjaWd4bWtYVEhwUkZzaEFKeFF5TityZ2tzK3IrdGpDc1lL?=
 =?utf-8?B?NCt0NEJNeFRFQ1Q3RytRemNoUTJSV0RvTXdZYkJYUkFVb25JMklYaUtnem1a?=
 =?utf-8?B?eFU1Ymg3cmhHZFZzRUs4MXcvd0JIaDgyMkduV0tSQnBWeDZwS1pzRjYyd0Nu?=
 =?utf-8?B?bDZOOEE3SFdOdWM5dUhHVUhXT2pDSlBLZjBaRkZtYkFhK1JJUlZIbS90ZzZP?=
 =?utf-8?B?dXdBc0VRMEVlMHhyNVZsckJkRWdyMFhWR1NoQXAybFBYS0hScis5RVpoenBt?=
 =?utf-8?B?NFlPYnB3VTZZS0JNbXlPc0tjU0N4aXovaTNxVEhIYk5HTndyY01iK1QwWEIw?=
 =?utf-8?B?MlZrNFVzOFN4ODQ0VnhnRE05SG5KcmNhMEpBVmMvdHdEbTdBcjFLSUVqbjZx?=
 =?utf-8?B?LzY4SDlFN0RCOUU2OERUZm9ZRVhpd1htWEhIZy9rdFQ4Njd2SEdlSHlTR2Zl?=
 =?utf-8?B?SittSHFxaUpFSHhuMWhoTjMvMU5xNGVxUW9vS0d6ZklhNU56RWpCaktmbmc5?=
 =?utf-8?B?SUlOTmdBQ2lnWDVkSk5PQ2RTQjFDZ3ljVTBUNzhTSGFLb1pQSGJWdzRZRFBX?=
 =?utf-8?B?MElVbkFoU2J0M1MvbUdEYkplVTN4ZHpXVTVkS0N3Q1d0Lzd5enRJTkkzVVd4?=
 =?utf-8?B?VEhBQUlOQzBtVk5DMkp2alFJQVlSR1VmWTVKOGhsa2lQSThkalZIeTJBd1ZY?=
 =?utf-8?B?aWltMWQ3WmNJVVdXYVp4TjkyME9PTlVpNXB2d3hpbDg3MXFNd3BNMnlXWUU0?=
 =?utf-8?B?LzdRL0UrYjJZcVZpVWw3OWR5Ujd0M2dvSDNmTklQRlA4K1FOTzFDa2xhWlJH?=
 =?utf-8?B?NCs5U0U1aGFVTzljeWVsa2w2UmxwWE9Pd1BlaGtHRCszYndNVUwwaTFrQlQx?=
 =?utf-8?B?c1ptTFh4QTJvangwSzZDL1Jha0N1czB2cDhsZEF3NS8yU0EyVVRuK0tPWmIw?=
 =?utf-8?B?ZHJHcHBrRmh1U1pURytwZnoxQ3p4VzlQVzlPblNiNDRvQXdhZmxxRUVMN2pw?=
 =?utf-8?B?NDk1ZWJzNXdzU1RLa1ljRHY0aS9td3RjbUovakZRZnROcktzRkMyQU1IQ1Vm?=
 =?utf-8?B?cmxqN0lNWjBwZzMzeDc4NkwrUXQ0V2RxTTREM1BQRTNuRXdnTys3RUcya0tG?=
 =?utf-8?B?REhzMzZBWlpobFJzZS9yUUwrT283RmVsWHJodGtqdFBXeEthV3JzUWxvWW9B?=
 =?utf-8?B?elRZaTVaMmQ2QkhZNGRRdUZ2Ulo0cVZ3RWJDaE5FTHhPeDFzOTFnQ0FqQnNa?=
 =?utf-8?Q?MD5EEGDJs9jDiRbQN0zjRFFmp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20ff8658-b4d5-4978-2c92-08db04f4d315
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 08:09:36.7499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hDKENkV73Rv539BZ5eWxxewFj1WhFAS+FWxuhH25mRS5cbbogAE3T4BSK7QKuukkfFdVGoDRQX14oPVVNV/U1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4084
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 01/02/23 23:52, Borislav Petkov wrote:
> On Wed, Dec 14, 2022 at 01:40:03PM -0600, Michael Roth wrote:
>> From: Nikunj A Dadhania <nikunj@amd.com>
>>
>> Pre-boot guest payload needs to be encrypted and VMM has copied it
> 
> "has to have copied it over" I presume?

True, payload is being copied in patch 10/64 now.
 
>> over to the private-fd. Add support to get the pfn from the memfile fd
>> for encrypting the payload in-place.
> 
> Why is that a good thing?
> 
> I guess with UPM you're supposed to get the PFN of that encrypted guest
> payload from that memslot.
> 
> IOW, such commit messages are too laconic for my taste and you could try
> to explain more why this is happening instead of me having to
> "reverse-deduce" what you're doing from the code...
> 

I am updating the SEV related patches, will add more details in commit and send.

Regards
Nikunj