From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: RE: [PATCH v3] crypto: aspeed: fix type warnings
Thread-Topic: [PATCH v3] crypto: aspeed: fix type warnings
Thread-Index: AQHZN3+/YgDO47yOgkqlmhg8xMbIP668kMcg
Date:   Fri, 3 Feb 2023 03:31:14 +0000
Message-ID: <SG2PR06MB3207A065990C50F67B66BE8E80D79@SG2PR06MB3207.apcprd06.prod.outlook.com>
References: <20230203032932.971586-1-neal_liu@aspeedtech.com>
In-Reply-To: <20230203032932.971586-1-neal_liu@aspeedtech.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vTyAo7YO6vLKj+KQyX+aB/8jGjbhMMT5Phl7AnCZBZ6wVPNByn21ePdXNMwK?=
 =?us-ascii?Q?KyYsG2MsvN5M8OMagnfrAuc0NFjgh3W5sRUGzw/K65hPk5ERnVxoswaA0l3c?=
 =?us-ascii?Q?ETyzqcyzFxhjS1/93FiFwYl13ovkfwWuocEbyDtv1jIwgHBUwmOLKNW9tmMs?=
 =?us-ascii?Q?Puy1QWi7TjTyf3bopsfeDVuzvPEOLz0dqEi6n+zBKrxBDgjSBBbalEHWAaDe?=
 =?us-ascii?Q?vAeiJaQ5TOJAKewfHNbpKQuzRxh5ji0SGAnomMZ2QSnqv3rFQOrV/bJyhvoT?=
 =?us-ascii?Q?Y4Qj2GoavlQbV0yWPuZ9pHdO149ykzkiOeQ7mVW6lliF+gc8pbaJsBLUEQue?=
 =?us-ascii?Q?MJjAU0/fXt8AIkDJn1HvPXcqPAiL3CI5dbwxrsxbLJ++yhHjczNMWWM4imFV?=
 =?us-ascii?Q?cRuuumXyyonX90hZsOqy7oDlQyLfE8/2dqmM5d2JgjhjN4CQPXXFn/4qxiTp?=
 =?us-ascii?Q?tRMhFYqSH7HzqpdHSu7436WWGlrdErkYFF3EiKHEtkKC1csfiQwmSp60vQdj?=
 =?us-ascii?Q?aMtkK7Cfa4I5rv3TmZRFhveMISIz4Roxh2ZNvhn/4HjjlaYd0K7bTKM6Bz1N?=
 =?us-ascii?Q?MyRatToD/FNIjkMy8WDENuNjOK+BpmcPbgx/qYseJdLuNrREPQaGIHJGBZSq?=
 =?us-ascii?Q?knkYRp4Flrd7Iz8CJUjYtKp8E/kCcT1dgs0O1sNyaoUcktBGuJLxtxiP9/OO?=
 =?us-ascii?Q?npmRBWP+cObQhGwFrlWvthiIlU+dcv+b3+5Q7OzD5uv0AlH5jfnbfNgJw1NS?=
 =?us-ascii?Q?0PUj1B3DaUY6GRlFdq2EhwIo0cxDNZHF8mFAMUTbIbVxcNgAV6+8UKQ8UrYI?=
 =?us-ascii?Q?MYXBOtj1VZJWHn70FXDVDUCPQzMIZFFBjMOWk/6lEilQhCZ1r5lKRIARdHlm?=
 =?us-ascii?Q?iHd3IUFFfqSYoT+IrMywQs5cLrJLJw6PbaxSQilq8deA0HvO1eNmz0UDRuLW?=
 =?us-ascii?Q?Hv2xHQ+9BpM+JMbaT4AIlqGO64IC9v7bfIj2TQVYo7IixJd715c1nhFYsors?=
 =?us-ascii?Q?xjGhrEk1rQEpQT9BvW/8A1ZAds1SvNszLxZZVif7OQq7SYWPUDnd0jofKXd4?=
 =?us-ascii?Q?hQktY3PxRcLgcAIdi9xocwOZLtNtCEz78PeincA64pfui6aRRF2Hzrwh5uCH?=
 =?us-ascii?Q?uKDwEHSmoDTusBZcjZqOb6TB+yps0rIQncW+9bH0FqZltJVJN7YIvr30Bs5W?=
 =?us-ascii?Q?kX4Eo/xM7hCtm+JmhaxvFuedJv+Fc6bCa6XXIxGIwuCBgYKi/vB/l7CqNx5b?=
 =?us-ascii?Q?kyJDVxqFddYFBhzJq2PVO9DRXXm9yaioY9kYzJG8O0701kizh5tVI2g4mCLo?=
 =?us-ascii?Q?8HBAfjPMuR8roLuy7w4phOb1zeJD+ClBovV7BtVHDs0BF6N/64bfNy7zo0f6?=
 =?us-ascii?Q?fedNgf+OV0wMU8G5vgBtp0LWHImSmxyQnOeurvxhfFjvKw/57X+MFMDdTboQ?=
 =?us-ascii?Q?tNhXZYmv+oK/MK2dgmL410bveOBKiJvYw9xdnU4lIo7smrlYz3d/9YfrQI+O?=
 =?us-ascii?Q?XpFTGz3fFUjhy+XrXAjxHpItSji1nfkyy0DnWs5mbmFZdBO8NkpJ6WCKe6UD?=
 =?us-ascii?Q?gLyHO4SIclSvBiGMseYFseYWy8gXcwJal6FrnBmz?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3207.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb80335d-c327-4875-651d-08db05971a63
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2023 03:31:14.3510
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mGF7zCWe63cix8rRIPUBeGjmx2g3EVRYAvVl+JDHANooQgUl8B3gOU9AZWXRCeKGkXvG7oTyq/H+k6XiTihiZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5671
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Sorry, ignore this patch.

> -----Original Message-----
> From: Neal Liu <neal_liu@aspeedtech.com>
> Sent: Friday, February 3, 2023 11:30 AM
> To: Joel Stanley <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>; Neal
> Liu <neal_liu@aspeedtech.com>; Herbert Xu <herbert@gondor.apana.org.au>;
> David S . Miller <davem@davemloft.net>
> Cc: linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org;
> linux-kernel@vger.kernel.org; linux-crypto@vger.kernel.org
> Subject: [PATCH v3] crypto: aspeed: fix type warnings
>=20
> This patch fixes following warnings:
>=20
> 1. sparse: incorrect type in assignment (different base types)
> Fix: change to __le32 type.
> 2. sparse: cast removes address space '__iomem' of expression
> Fix: use readb to avoid dereferencing the memory.
>=20
> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> ---
> Change since v2: remove unnecessary cast.
> Change since v1: keep iomem marker to remain its purpose.
>=20
>  drivers/crypto/aspeed/aspeed-acry.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/crypto/aspeed/aspeed-acry.c
> b/drivers/crypto/aspeed/aspeed-acry.c
> index 164c524015f0..f2429e699d14 100644
> --- a/drivers/crypto/aspeed/aspeed-acry.c
> +++ b/drivers/crypto/aspeed/aspeed-acry.c
> @@ -252,7 +252,7 @@ static int aspeed_acry_rsa_ctx_copy(struct
> aspeed_acry_dev *acry_dev, void *buf,
>  				    enum aspeed_rsa_key_mode mode)
>  {
>  	const u8 *src =3D xbuf;
> -	u32 *dw_buf =3D (u32 *)buf;
> +	__le32 *dw_buf =3D (__le32 *)buf;
>  	int nbits, ndw;
>  	int i, j, idx;
>  	u32 data =3D 0;
> @@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct
> aspeed_acry_dev *acry_dev, void *buf,  static int
> aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev)  {
>  	struct akcipher_request *req =3D acry_dev->req;
> -	u8 *sram_buffer =3D (u8 *)acry_dev->acry_sram;
> +	u8 __iomem *sram_buffer =3D (u8 __iomem *)acry_dev->acry_sram;
>  	struct scatterlist *out_sg =3D req->dst;
>  	static u8 dram_buffer[ASPEED_ACRY_SRAM_MAX_LEN];
>  	int leading_zero =3D 1;
> @@ -321,11 +321,11 @@ static int aspeed_acry_rsa_transfer(struct
> aspeed_acry_dev *acry_dev)
>=20
>  	for (j =3D ASPEED_ACRY_SRAM_MAX_LEN - 1; j >=3D 0; j--) {
>  		data_idx =3D acry_dev->data_byte_mapping[j];
> -		if (sram_buffer[data_idx] =3D=3D 0 && leading_zero) {
> +		if (readb(sram_buffer + data_idx) =3D=3D 0 && leading_zero) {
>  			result_nbytes--;
>  		} else {
>  			leading_zero =3D 0;
> -			dram_buffer[i] =3D sram_buffer[data_idx];
> +			dram_buffer[i] =3D readb(sram_buffer + data_idx);
>  			i++;
>  		}
>  	}
> --
> 2.25.1