Message-ID: <cf60caa6-a540-c09a-e34b-4fdf30fd0d39@gmail.com>
Date:   Wed, 8 Feb 2023 20:03:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] crypto: crypto4xx - Call dma_unmap_page when done
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
References: <Y+CX0WWNtrURdr5g@gondor.apana.org.au>
Content-Language: de-DE, en-US
From:   Christian Lamparter <chunkeey@gmail.com>
In-Reply-To: <Y+CX0WWNtrURdr5g@gondor.apana.org.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/6/23 07:01, Herbert Xu wrote:
> In crypto4xx_cipher_done, we should be unmapping the dst page, not
> mapping it.
> 
> This was flagged by a sparse warning about the unused addr variable.
> While we're at it, also fix a sparse warning regarding the unused
> ctx variable in crypto4xx_ahash_done (by actually using it).
> 
> Fixes: 049359d65527 ("crypto: amcc - Add crypt4xx driver")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Tested this on the MyBook Live. Internal cryptmgr_test pass with:

[    2.888784] alg: No test for stdrng (crypto4xx_rng)
[    7.519740] "cryptomgr_test" (102) uses obsolete ecb(arc4) skcipher
(but all crypto4xx entries in /proc/crypto say that the selftest pass)

as well as libkcapi kcapi-enc-test.sh passes.

The ahash portion is a bit "underused". Currently the driver doesn't
register any hashes (this is because in testing I found the getting
the crypto-hardware to do those is so much slower than letting the
CPU do these).

Anyway:

Tested-by: Christian Lamparter <chunkeey@gmail.com>

Thanks!