Date:   Fri, 10 Feb 2023 17:45:39 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Peter Lafreniere <peter@n8pjl.ca>
Cc:     linux-crypto@vger.kernel.org, peter@n8pjl.ca, x86@kernel.org,
        jussi.kivilinna@mbnet.fi
Subject: Re: [PATCH v2 0/3] crypto: x86/blowfish - Cleanup and convert to
 ECB/CBC macros
Message-ID: <Y+YSQxsegOhpBcx/@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230131012624.6230-1-peter@n8pjl.ca>
Precedence: bulk

Peter Lafreniere <peter@n8pjl.ca> wrote:
> We can acheive a reduction in code size by cleaning up unused logic in
> assembly functions, and by replacing handwritten ECB/CBC routines with
> helper macros from 'ecb_cbc_helpers.h'.
> 
> Additionally, these changes can allow future x86_64 optimized
> implementations to take advantage of blowfish-x86_64's fast 1-way and
> 4-way functions with less code churn.
> 
> When testing the patch, I saw a few percent lower cycle counts per
> iteration on Intel Skylake for both encryption and decryption. This
> is merely a single observation and this series has not been rigorously
> benchmarked, as performance changes are not expected. 
> 
> v1 -> v2:
> - Fixed typo that caused an assembler failure
> - Added note about performance to cover letter
> 
> Peter Lafreniere (3):
>  crypto: x86/blowfish - Remove unused encode parameter
>  crypto: x86/blowfish - Convert to use ECB/CBC helpers
>  crypto: x86/blowfish - Eliminate use of SYM_TYPED_FUNC_START in asm
> 
> arch/x86/crypto/blowfish-x86_64-asm_64.S |  71 ++++----
> arch/x86/crypto/blowfish_glue.c          | 200 +++--------------------
> 2 files changed, 55 insertions(+), 216 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt