Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19FE7C05027 for ; Fri, 10 Feb 2023 09:46:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231642AbjBJJqY (ORCPT ); Fri, 10 Feb 2023 04:46:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231748AbjBJJqW (ORCPT ); Fri, 10 Feb 2023 04:46:22 -0500 Received: from formenos.hmeau.com (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 705F5635BA for ; Fri, 10 Feb 2023 01:46:21 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1pQPyg-009c0p-3M; Fri, 10 Feb 2023 17:45:59 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 10 Feb 2023 17:45:58 +0800 Date: Fri, 10 Feb 2023 17:45:58 +0800 From: Herbert Xu To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Tudor Ambarus , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH] crypto: atmel-i2c: Drop unused id parameter from atmel_i2c_probe() Message-ID: References: <20230131081351.165235-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230131081351.165235-1-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jan 31, 2023 at 09:13:51AM +0100, Uwe Kleine-K?nig wrote: > id is unused in atmel_i2c_probe() and the callers have extra efforts to > determine the right parameter. So drop the parameter simplifying both > atmel_i2c_probe() and its callers. > > Signed-off-by: Uwe Kleine-K?nig > --- > Hello, > > just found a nice optimisation while grepping for something else in the > tree ... > > Best regards > Uwe > > drivers/crypto/atmel-ecc.c | 3 +-- > drivers/crypto/atmel-i2c.c | 2 +- > drivers/crypto/atmel-i2c.h | 2 +- > drivers/crypto/atmel-sha204a.c | 3 +-- > 4 files changed, 4 insertions(+), 6 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt