MIME-Version: 1.0
References: <20230210181541.2895144-1-ap420073@gmail.com>
In-Reply-To: <20230210181541.2895144-1-ap420073@gmail.com>
From:   Samuel Neves <sneves@dei.uc.pt>
Date:   Fri, 10 Feb 2023 21:18:02 +0000
Message-ID: <CAEX_ruFsUzDheaa0GMSeoauFMnymU9kcN1r0MZR3Mai1vrRS9g@mail.gmail.com>
Subject: Re: [PATCH] crypto: x86/aria-avx - fix using avx2 instructions
To:     Taehee Yoo <ap420073@gmail.com>
Cc:     linux-crypto@vger.kernel.org, x86@kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Feb 10, 2023 at 6:18 PM Taehee Yoo <ap420073@gmail.com> wrote:
>
> Also, vpbroadcastd is simply replaced by vmovdqa in it.
>
>  #ifdef CONFIG_AS_GFNI
>  #define aria_sbox_8way_gfni(x0, x1, x2, x3,            \
>                             x4, x5, x6, x7,             \
>                             t0, t1, t2, t3,             \
>                             t4, t5, t6, t7)             \
> -       vpbroadcastq .Ltf_s2_bitmatrix, t0;             \
> -       vpbroadcastq .Ltf_inv_bitmatrix, t1;            \
> -       vpbroadcastq .Ltf_id_bitmatrix, t2;             \
> -       vpbroadcastq .Ltf_aff_bitmatrix, t3;            \
> -       vpbroadcastq .Ltf_x2_bitmatrix, t4;             \
> +       vmovdqa .Ltf_s2_bitmatrix, t0;                  \
> +       vmovdqa .Ltf_inv_bitmatrix, t1;                 \
> +       vmovdqa .Ltf_id_bitmatrix, t2;                  \
> +       vmovdqa .Ltf_aff_bitmatrix, t3;                 \
> +       vmovdqa .Ltf_x2_bitmatrix, t4;                  \

You can use vmovddup to replicate the behavior of vpbroadcastq for xmm
registers. It's as fast as a movdqa and does not require increasing
the data fields to be 16 bytes.