Message-ID: <1d5c317b-81a2-6ddf-7641-cbe325688c51@gmail.com>
Date:   Sun, 12 Feb 2023 04:02:12 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] crypto: x86/aria-avx - fix using avx2 instructions
Content-Language: en-US
To:     Samuel Neves <sneves@dei.uc.pt>
Cc:     linux-crypto@vger.kernel.org, x86@kernel.org
References: <20230210181541.2895144-1-ap420073@gmail.com>
 <CAEX_ruFsUzDheaa0GMSeoauFMnymU9kcN1r0MZR3Mai1vrRS9g@mail.gmail.com>
From:   Taehee Yoo <ap420073@gmail.com>
In-Reply-To: <CAEX_ruFsUzDheaa0GMSeoauFMnymU9kcN1r0MZR3Mai1vrRS9g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/11/23 06:18, Samuel Neves wrote:

Hi Samuel,
Thank you so much for the review!

 > On Fri, Feb 10, 2023 at 6:18 PM Taehee Yoo <ap420073@gmail.com> wrote:
 >>
 >> Also, vpbroadcastd is simply replaced by vmovdqa in it.
 >>
 >>   #ifdef CONFIG_AS_GFNI
 >>   #define aria_sbox_8way_gfni(x0, x1, x2, x3,            \
 >>                              x4, x5, x6, x7,             \
 >>                              t0, t1, t2, t3,             \
 >>                              t4, t5, t6, t7)             \
 >> -       vpbroadcastq .Ltf_s2_bitmatrix, t0;             \
 >> -       vpbroadcastq .Ltf_inv_bitmatrix, t1;            \
 >> -       vpbroadcastq .Ltf_id_bitmatrix, t2;             \
 >> -       vpbroadcastq .Ltf_aff_bitmatrix, t3;            \
 >> -       vpbroadcastq .Ltf_x2_bitmatrix, t4;             \
 >> +       vmovdqa .Ltf_s2_bitmatrix, t0;                  \
 >> +       vmovdqa .Ltf_inv_bitmatrix, t1;                 \
 >> +       vmovdqa .Ltf_id_bitmatrix, t2;                  \
 >> +       vmovdqa .Ltf_aff_bitmatrix, t3;                 \
 >> +       vmovdqa .Ltf_x2_bitmatrix, t4;                  \
 >
 > You can use vmovddup to replicate the behavior of vpbroadcastq for xmm
 > registers. It's as fast as a movdqa and does not require increasing
 > the data fields to be 16 bytes.

Thanks for this suggestion!
I tested this driver using vmovddup instead of using vpbroadcastq, it 
works well.
As you mentioned, vmovddup doesn't require 16byte data.
So, I will use vmovddup instruction instead of vpbroadcastq instruction.

I will send the v2 patch for it.

Thank you so much,
Taehee Yoo