From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>
Subject: RE: [PATCH] crypto: aspeed - Fix modular aspeed-acry
Thread-Topic: [PATCH] crypto: aspeed - Fix modular aspeed-acry
Thread-Index: AQHZPTPOz63YKu8QIkKM6cbL7zYuJq7MIA0Q
Date:   Mon, 13 Feb 2023 01:48:40 +0000
Message-ID: <TY2PR06MB3213FAE443DC7F66CC3438CB80DD9@TY2PR06MB3213.apcprd06.prod.outlook.com>
References: <Y+YRKdWUA4jjoUZ2@gondor.apana.org.au>
In-Reply-To: <Y+YRKdWUA4jjoUZ2@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?l9DjIrm9Vvf30Nz/1y2BSxojGu74NRT7hsnkGf/vm17FUNuXYDRfmwUpLsgL?=
 =?us-ascii?Q?c0ipVJuWaJk+LW99P/I6mD32rsFPUKJ3kGxKRmQbMUYQ8sbwmUc+tTQgMY5w?=
 =?us-ascii?Q?dMFp/OKj0khojT/S83aAu3VWHSecQimmJN3Ddydl563FCgKFuAVv6lTjeUCZ?=
 =?us-ascii?Q?qbU+ZvNxMwDnColKkbRSghR7Wh96OpXjleFUemROecrkrAzz4Wm/LOp4A+pM?=
 =?us-ascii?Q?25tChBWE5cA6+t0PazENRGbH1FLqakqpQZY7wfFMqxMkl6qMThtNlOKpt/1M?=
 =?us-ascii?Q?ZJcwUCF0yHbQRk28eggpjUi3HaDrWrzli20JSEc7hy869LVfyPum+D0VEqqJ?=
 =?us-ascii?Q?k2tHeoRkr7L8XJj45qxR16JhNdKs2XhSDFg4h7AEzTcjogiKUNCxwaxjSo3h?=
 =?us-ascii?Q?CChzSwe7621Ms07U1jM54Bdhbs3e5UkCoh7ojHv0BCtgjVUDz0bJsmhJyPQT?=
 =?us-ascii?Q?bEQfgH3H6moTdHvssKD2qKzxPThW2IPQDI6pk6gqXye1QatjdfPuvPf8AYWL?=
 =?us-ascii?Q?2ETHkfMDne8hqjBa5+XNk7lTCDiTm39t2aAtlT5KzPVfMFG67ElZ7RrKkf+y?=
 =?us-ascii?Q?7GC6tpEoSoZpGHeUPVIP+Hd1a1STm/RN1boZsJ6RJoT3R8aPj5Mf/2FFQaKu?=
 =?us-ascii?Q?vTG84Jh96xJuPb9sv/SQuwWg/iD7HpwpP3o56G7D7nBOk26BxnUaf7KGlkRu?=
 =?us-ascii?Q?fi3L4u/ruKSBhLxMPGBWpa+ZtS38Krc+e9CpcoQYxlhk7CXT8piG/8LJsyPE?=
 =?us-ascii?Q?VCvCc4K0ugvUM89jN0N6AwBRoI5nGJeuvhETQLaiP4LneyfahsBCG3GuK8U+?=
 =?us-ascii?Q?UCsseauwGDsS+z41FSXgdRdtXU/A/QQdPvRZLfVhJwpQnaZWKgGYSIBvbztT?=
 =?us-ascii?Q?XpOnrY/amx4/zM5Y0kpkkJGqM/dBExmUqulbo9PA2qbQxPM+k6wLjOVFe4ai?=
 =?us-ascii?Q?PB7s1yIUBAKAbxt01cNTbZp/rjJvn+kjHFf+bZMIyhCskfWvbWmiWzMPQQ60?=
 =?us-ascii?Q?IOf79vWi6FT4J+w+Ew+3NyqmFnUwP1Ka6quUpv5qj+W9e1Jq/dWNJrKQlf8c?=
 =?us-ascii?Q?JronV2nGUQRw3gTbuPHQzWcy9bn48b2FzQTqvwfettsDRsjek/TFC3KW28LA?=
 =?us-ascii?Q?f0uiez7+FihyCGm0vpB2Y+U1AaddwBNS6eOW3aPLf0vaZyArcJq9kSfHk54N?=
 =?us-ascii?Q?S+kpT2pScqlNGDROuvA2qww/tWbZvxfpABbH74pg5QXFIcE9frEio6nmuagS?=
 =?us-ascii?Q?ZgZpmPDp/RNPVgPFeDrzGXG5HolbM7iY+buq1jJRz8pN8zYM2aSawIWkO4Ue?=
 =?us-ascii?Q?hQa596XKY72AwoR20xcAeSc5uImbtoJX/wq/kw5VIk0ON2yDFxSPIg0/SwD0?=
 =?us-ascii?Q?Ksx6XPGN4MXt4ixQkinJa1yliA2XdyQab4NSOe1sZf2MMvATeASOR2Jlz7cU?=
 =?us-ascii?Q?apWGTKTkREeVHcoWzl3+6l/E5xGY/okI9+1yMKX+WJ4tOnt/+fFn9EJ/L77q?=
 =?us-ascii?Q?LdXzUTf5WQeW5T6hVez8RUioOy0CpkmS5dHDitUFcqSfZPXX3EWbOLP28PbQ?=
 =?us-ascii?Q?5ojCzntw8mIjPcjWe+WdtsfdpVR2JaKU1nbmuB9F?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3213.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 680446d4-80f7-4a0f-81d3-08db0d646eaa
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2023 01:48:40.7303
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JBnpsCdEZbBCAMnPC/G4VafySvrJw8r0Myf0NmNkFdZOqA1NQlB+ELgJ79rMicfoj4Utdu2i/kZBdMaHIlFBJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3997
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> When aspeed-acry is enabled as a module it doesn't get built at all.  Fix=
 this
> by adding it to obj-m.
>=20
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Reviewed-by: Neal Liu <neal_liu@aspeedtech.com>
=20
> diff --git a/drivers/crypto/aspeed/Makefile b/drivers/crypto/aspeed/Makef=
ile
> index 24284d812b79..15862752c053 100644
> --- a/drivers/crypto/aspeed/Makefile
> +++ b/drivers/crypto/aspeed/Makefile
> @@ -6,4 +6,6 @@ aspeed_crypto-objs :=3D aspeed-hace.o	\
>  		      $(hace-hash-y)	\
>  		      $(hace-crypto-y)
>=20
> -obj-$(CONFIG_CRYPTO_DEV_ASPEED_ACRY) +=3D aspeed-acry.o
> +aspeed_acry-$(CONFIG_CRYPTO_DEV_ASPEED_ACRY) +=3D aspeed-acry.o
> +
> +obj-$(CONFIG_CRYPTO_DEV_ASPEED) +=3D $(aspeed_acry-y)
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt