Message-ID: <ca9c0f77-c191-d88a-22a1-315ca97f17e8@amd.com>
Date:   Thu, 16 Feb 2023 07:29:53 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 6/6] i2c: designware: Use PCI PSP driver for communication
Content-Language: en-US
To:     Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        =?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>,
        Grzegorz Bernacki <gjb@semihalf.com>,
        Thomas Rijo-john <Rijo-john.Thomas@amd.com>,
        Lendacky Thomas <Thomas.Lendacky@amd.com>,
        herbert@gondor.apana.org.au,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     linux-i2c@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230209223811.4993-1-mario.limonciello@amd.com>
 <20230209223811.4993-7-mario.limonciello@amd.com>
 <703033aa-1293-307d-42a2-9734a51c7190@linux.intel.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <703033aa-1293-307d-42a2-9734a51c7190@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aC9NbHBMbmIrNk0zLzc4ZHlwUVF1MEdXcGo2ZEdndiswaUlmN0U3QW5EN3BY?=
 =?utf-8?B?RjhJUWN6Q3BCWk5lQ2JRTFpqajcrYXNjcmRwMlNaRjRHZm8yRys4ZVBhSWtI?=
 =?utf-8?B?WFFhNlF4dW40eXUyd25JcDczNThENU5yalRXbzZqdXpGOXJSVUQwWG1YK1V3?=
 =?utf-8?B?NDlDRWNBWkZ0WDdvYUdBaWdZVWt5K09zdytVNFY3eEE1ZHBoZU1JYklrck1L?=
 =?utf-8?B?RXlUYi8rbWpITEpoUm5mNlVkeFZiTFhtMGcvaFBpcHJieXhvRitJejFXUjJk?=
 =?utf-8?B?Y3hhQ2R1R1lWSFo5TVVENjBxd2tzbE5XUlI0a1h6KzdteHhxSmswMGRhMU4v?=
 =?utf-8?B?c25yd3pMRVE4aTRmcmFiNVRtN1cwYWRlWXU1d2hNQjlqbTZ2bW5oYmFNTjA4?=
 =?utf-8?B?OWJraFY5cytZNmVZRi9uSUUvM2dxbHFRN2VJcTB0OExTcEFvbEJjOGNtOWl0?=
 =?utf-8?B?VU9LR0UzK1l1RVhNczRUWWg4YlhmNVovK2lqSW0wMGw4SFpqcEZGc28rbFJa?=
 =?utf-8?B?bTRHN0xLY0x3SUl3aWJsTFVqbjhWK1lGQ2Z6VEc1UW5IZUl1b1o2RHpCMmxE?=
 =?utf-8?B?VHlWM2dkUUx6WXZ1T3dyV2Q0Q25sY1RrZmZwUTkwTU9STUt6VDloeVdRSEdG?=
 =?utf-8?B?QnJINW8vZWJLOWFvUkVmSEF5VEc4QnZOMEJTMS85NTdESlpEb2VUZStWM3o4?=
 =?utf-8?B?Z1JSaDNSTDJVbk50S0J3aDFZWEtLOU1uZ2s2RDJPdjRSaTFtNnJUTXB2UkJR?=
 =?utf-8?B?aXI0eGdhWjdxQjR4NXgzYVdldTRrQ1JQVjZDSC9XeVpvZzNCdnJBaU1nWUkv?=
 =?utf-8?B?TW11dmozZERQeGlhSFcxVXhwdTVaZ21PNHNMRUE2alhQbTlCYzVySmZwRktL?=
 =?utf-8?B?V3NEZlRHejZ3T0Z0ek5vdlM0aGNyNFpJLzJsd1RhRVB5TFNBNGhXM3EvZDJs?=
 =?utf-8?B?MEUvaXVaa2RrejlFTFpMbTI3VjJSY1BOV3NtN1ZOVmtoMzJHMVp5ZmV0WmI0?=
 =?utf-8?B?UmxIT093eStoY3NXY2FENTVGbFlrV3EvS2ZHODUzMVZpYVlqcjY0MFZScHlD?=
 =?utf-8?B?T0xDVVFESFZHaThVZVR0MXlQbm9RS3V4a21LY2dWSzVUQ1JiNDJLRlEvdWFk?=
 =?utf-8?B?ZG4ycDBTdm12OXExQlM0c1VIOGNTeXN0RGlaZis4T20vcU9ZQmZqbVJ0QXZo?=
 =?utf-8?B?c2JycGNsNlJ5RlpidytxUDQxaWtKRTFkRTdrc1NMR0w3NlZyUjRwNEVFbHRs?=
 =?utf-8?B?SzZtelBBanNMYVhGaWduM1gzdERGS21xU0Z3dSt4L29tbHV4cDVIY21TTHFT?=
 =?utf-8?B?eml4MWFlbFh3Qzk2aXY3dU12TnI0cjhBMHF6ejVVUXV3L0tOUWdSaXpKQ0Vt?=
 =?utf-8?B?OWZmZk16ajByeGNONGZiODVJWFBMRWRUbjJBNzNiSllzL3NWS21paGpQaUht?=
 =?utf-8?B?SXFHaW5XV3E2VVpFOElGaTRNdDVyMWVJNDNqeWs4dEZJMkNsc3dUaFpLQ3F3?=
 =?utf-8?B?ODk4bHZLZjRlVll4WVJtVTZPMHA4ZDdwWmtwUnFWeXdtUjNRaU5qcXZmdDBi?=
 =?utf-8?B?dENHSjRGQkQyMEN3ZFdJOVNOM1hBbzJidzVkVmJMcld4eGRYUDZkVXZzWG9r?=
 =?utf-8?B?WEtaLzQycExEa2Nyc0dZNnIwV1UxRlJHS3N0UnJlcEpJRHNtSUFmRzhhYW4r?=
 =?utf-8?B?a1R3Uk42T1hVaWRQdkUweHpzWjVDTDhwMUxSSk5lT2cyYTI0cFdrdCtIUjgz?=
 =?utf-8?B?bHdJMXlVOGlaYXFRdHBUZ3BBcjROVXNGOEVDVFhNY2VMVFI2UUxNdmF2RUpN?=
 =?utf-8?B?TE5qRjJ1YVF6cE15VmNlVVQrKzM1Y25TUFA1a3FiVnZXck5OVlFVOXdWOTIy?=
 =?utf-8?B?TDVYaEdtSE1CeWJkc1J4N1FtUUR4b2FSL25CODBtWVQ4QnRydGRBOUN6Q1l6?=
 =?utf-8?B?RjlGTVlNd0hCWVhWck9aZSs2VEw3d2ZBdDYwbG9uZlhRNHdaeFBISHl1RC9T?=
 =?utf-8?B?eU53Q20wb2NVamVWZDdmejBOdDUxVlNQSlFaVFpHTk90SjdoRys4OGNXcytL?=
 =?utf-8?B?MTZkZXZiNENKMlZHN0p3UGhvVXprdi94R0F0MG9SMEthRVJwdVRFTitHMm90?=
 =?utf-8?B?dmN5QXNrVC9PekdLdlQzMnJ5bklNdVdBZmxnWXlOeWVWa0dYUmVoUGFrdmRL?=
 =?utf-8?Q?BlZimszZLkamgyEli8ozHiPMHD3viPnXQbgb/9c/7g4g?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ebd5032-c262-4865-15ab-08db1021e783
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 13:30:00.8378
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: isBevsVlvN5gNizNkpIptFxcod5nlT6fDEzzugJmF76p4qY/oD6Q0hfggrr1KBNnW7Z2aqtWc36a6tEeWGxqUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5232
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 2/16/23 07:27, Jarkko Nikula wrote:
> On 2/10/23 00:38, Mario Limonciello wrote:
>> Currently the PSP semaphore communication base address is discovered
>> by using an MSR that is not architecturally guaranteed for future
>> platforms.  Also the mailbox that is utilized for communication with
>> the PSP may have other consumers in the kernel, so it's better to
>> make all communication go through a single driver.
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>>   drivers/i2c/busses/Kconfig                  |   2 +-
>>   drivers/i2c/busses/i2c-designware-amdpsp.c  | 141 +-------------------
>>   drivers/i2c/busses/i2c-designware-core.h    |   1 -
>>   drivers/i2c/busses/i2c-designware-platdrv.c |   1 -
>>   include/linux/psp-platform-access.h         |   1 +
>>   5 files changed, 9 insertions(+), 137 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index a7bfddf08fa7b..9e2202ca73ec7 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -566,9 +566,9 @@ config I2C_DESIGNWARE_PLATFORM
>>     config I2C_DESIGNWARE_AMDPSP
>>       bool "AMD PSP I2C semaphore support"
>> -    depends on X86_MSR
>>       depends on ACPI
>>       depends on I2C_DESIGNWARE_PLATFORM
>> +    depends on CRYPTO_DEV_SP_PSP && !(I2C_DESIGNWARE_PLATFORM=y && 
>> CRYPTO_DEV_CCP_DD=m)
>>       help
>
> Would this look better if split? I.e.
>
>     depends on CRYPTO_DEV_SP_PSP
>     depends on !(I2C_DESIGNWARE_PLATFORM=y && CRYPTO_DEV_CCP_DD=m)
Yes, thanks I'll change that for next version.