Message-ID: <d86181b5-bf73-13e3-08f7-6cab43cb3398@amd.com>
Date:   Thu, 16 Feb 2023 08:23:02 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 3/6] crypto: ccp: Move some PSP mailbox bit definitions
 into common header
Content-Language: en-US
To:     "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        =?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>
Cc:     Grzegorz Bernacki <gjb@semihalf.com>,
        "Thomas, Rijo-john" <Rijo-john.Thomas@amd.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "Allen, John" <John.Allen@amd.com>,
        "Singh, Brijesh" <Brijesh.Singh@amd.com>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>
References: <20230209223811.4993-1-mario.limonciello@amd.com>
 <20230209223811.4993-4-mario.limonciello@amd.com>
 <CAOtMz3PuzpcrqQb-L9kzY1be4xwhp72fqNqSWnRvAE0Nd4d3qQ@mail.gmail.com>
 <MN0PR12MB61017A594AF2CCD1D75EC798E2A29@MN0PR12MB6101.namprd12.prod.outlook.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <MN0PR12MB61017A594AF2CCD1D75EC798E2A29@MN0PR12MB6101.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXorMFlodzV0YWpsYit1VzFyalZvSkc2aUk3YWtGdk1DTG9yUEY3dUFrcDQr?=
 =?utf-8?B?ck43VDBNMm9IRGhsV2xnTUdCNXFMN2ErNGhDLzBuelUrUVlXNDhtSGwweWFu?=
 =?utf-8?B?OURlYzEwR2FNdFkwS2xLakM0dVk2RGNtcGdhbm9RQ1BRTFBiKzFJd1RwaXoz?=
 =?utf-8?B?WUhDaE9GM3IwYVNnUkF6eHhBRkRobTNNbkRyU0JrT3NrWmhYWURGVUhmK2Rq?=
 =?utf-8?B?cmZvT1dhb3dybFRyQzRNWDdtczRZQ0JiMmx5VGJmTVMrOE1jSXRWQVpybGNS?=
 =?utf-8?B?ZnpGaTJLNEFoWUxzNVNpb241M0xmdUc4YTJnWkU4ZVZmRWRwdVZsMU01dkov?=
 =?utf-8?B?dGVoWWswMlV6MnBxNjhDZEJjQWEySVkvQlJzRDEyTVdteUVPQjZaVmFFMVBx?=
 =?utf-8?B?eDFjQ3ZPUXlTY2E1Z24zWGRFZ3BKVTM3VXBsWjAwUUdSdGlVZ2wyNnNxV0t1?=
 =?utf-8?B?anMvRUxMNzRoTnVLVlFUVmZxTlhiSU96VFd1QnJpSFN3S3NuUGdYUUpKZk50?=
 =?utf-8?B?NkR0L3FIQktaTjZVWWxwVy9mMEp6SXF6aHRJQUVGK1lRdEExZk9tSWdVOVJL?=
 =?utf-8?B?TVVncU9QdFZBdTYzT1I5TFdPVHZlRzJYYWVFSmJDZUNjdWcvNmlETWt4MXJ5?=
 =?utf-8?B?ekJJL295M3JUTTNISnBEcFN4ZE1TWGlUS0Y2b21CMEloemRpRmpCUE4xcy9T?=
 =?utf-8?B?TU82amdtLzZOajNhRG5paU5Zbjdtd3d2WHR2Um1PQ0ViWkNSMWJUMVg2UVZD?=
 =?utf-8?B?aHlhREFBQWpKZGowdGF1cW9lZkVnMFVOUjNWSjVyZ2xyN0d0aFFvTkhtUHlE?=
 =?utf-8?B?d1Q2b0ZqdkRNajQzMVZabnBEMTF1SEdjZmlQNXFHWVlFL3hDcElxVDdOQXhj?=
 =?utf-8?B?NTRMemp0VDR3aGVDMGRTQTJsK1lTZDMxUzZYT25rUXVnTG1TOGtZbkEyRHJm?=
 =?utf-8?B?WHpTVVhRVTh6UGJWT1pMNVFnU3R0eDZ5QlVONVFOSHpWa1llMWJOWC9oN2NZ?=
 =?utf-8?B?bEdsRnNwYnE4Tzl0NWZzTXRPL0J6VUhoZlhROXM1ZFhTK3N0Snk5TnNEbTAr?=
 =?utf-8?B?Rm42YUo5VlM1NkZZQjJFbDVWTDFFNnplQTBJWUVrRGlnbFZic2doczkwOGE4?=
 =?utf-8?B?ZHZZb1YwR0R6ak8zWE4vUndIVHFnOEdnbURXZ0ZKaHhBZWpwWFBXRytVS2Rm?=
 =?utf-8?B?Ky94ckNjUGxjK2NLSGhKSUR0UWdjWXdYekdvbHBIT2Y3M1B4V1liVnU3ZWR6?=
 =?utf-8?B?SUNuNFdUQjYzR3lJajFlMFZvTzNJSVVVemJ0KytHdWUyVVdUNGRaR2ppckYy?=
 =?utf-8?B?MkV2WnRwRHoxZWM0V201WW5nWFQzVlVyYy9xb2pZSzA0UC92WkpJRVRmcC9k?=
 =?utf-8?B?KzdnQ1FjZ1dVS041WE5DazNNVjRZeldwZzJKZk53WG9qaEJoZWMrdy8rRUQr?=
 =?utf-8?B?Z0FKNXU1ZjVMdnhnZVN6K204ZDJtUlNUZFcxdXg0ZVVPOUNTZ0Vldm9HbVRZ?=
 =?utf-8?B?Q1ArVCtUemFpbi9RVmZ1Q1hhK2ZuMHdzb0NpR1Q3UXdPOXR1Sk1UZkNqc1JD?=
 =?utf-8?B?ZnFFTkt5WlJoWERJQnd2Q2N2SGhKQlFYK05XenhYOUVZK1M2dCtNcTFlTzMr?=
 =?utf-8?B?eFdKam1ObmhySVlZOTBpM3UwS2M4VkRpMVBaM2l4YlhFaEdoemJmS000Smcw?=
 =?utf-8?B?ZXcwVUNmdTVvSU5YdklId0ZMRjduTWpCMGorV0VsdHY2WncvRDJ2Z1pES29r?=
 =?utf-8?B?bFB1SW9Yekt4VTBDWGliNWdwVzVCRHR1bENNaGtKY2E0Z0J4Y2tHYkhGUlJS?=
 =?utf-8?B?QXU5YXg2VUppU1BlUm4wWUFGMTIyRGQ0bmU3T0w2UGpNemluSVB1SUZlUFZt?=
 =?utf-8?B?NUIrRGprMmJyWUo1ZGNyaC9EQm81ME41TTBuU1hUaCtlSGExOTJuUTVUVVhM?=
 =?utf-8?B?UkkwSzRsdE42M1dCMFNqSCtCeDJlTVpwcGFMRW4xUmx4THhOZ3RZRFdPQlk0?=
 =?utf-8?B?bzhpckRVeThmNUttMUZqMllsZG5qNUZoa2NsR2RhaU5jQlhENngrbVYzbjFY?=
 =?utf-8?B?VkxTMlZPaGwvSzI5LzBFSEh0MmhDcjByaHRWckgrbVAwSmN6RFc5eGZ0K2pN?=
 =?utf-8?Q?kMLWZeO8mJHxYRZN/WIu/WzdA?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc093cdb-9021-4dab-4da4-08db10295162
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 14:23:05.0344
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tEdTdzzWZyL2XEE9gTO1AV3rER429BWps6UZEbwea9szGY3VVnJzFSffn1sQXNO2qNrgPBqtriK7/BeEbb3l8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4953
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 2/14/23 16:05, Limonciello, Mario wrote:
> [Public]
> 
> 
> 
>> -----Original Message-----
>> From: Jan Dąbroś <jsd@semihalf.com>
>> Sent: Tuesday, February 14, 2023 03:04
>> To: Limonciello, Mario <Mario.Limonciello@amd.com>
>> Cc: Grzegorz Bernacki <gjb@semihalf.com>; Thomas, Rijo-john <Rijo-
>> john.Thomas@amd.com>; Lendacky, Thomas
>> <Thomas.Lendacky@amd.com>; herbert@gondor.apana.org.au; Allen, John
>> <John.Allen@amd.com>; Singh, Brijesh <Brijesh.Singh@amd.com>; Jarkko
>> Nikula <jarkko.nikula@linux.intel.com>; Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com>; Mika Westerberg
>> <mika.westerberg@linux.intel.com>; linux-i2c@vger.kernel.org; linux-
>> crypto@vger.kernel.org; linux-kernel@vger.kernel.org; David S. Miller
>> <davem@davemloft.net>
>> Subject: Re: [PATCH 3/6] crypto: ccp: Move some PSP mailbox bit definitions
>> into common header
>>
>> (...)
>>> @@ -99,7 +93,7 @@ static int psp_check_mbox_recovery(struct psp_mbox
>> __iomem *mbox)
>>>
>>>          tmp = readl(&mbox->cmd_fields);
>>>
>>> -       return FIELD_GET(PSP_MBOX_FIELDS_RECOVERY, tmp);
>>> +       return FIELD_GET(PSP_CMDRESP_RECOVERY, tmp);
>>>   }
>>>
>>>   static int psp_wait_cmd(struct psp_mbox __iomem *mbox)
>>> @@ -107,7 +101,7 @@ static int psp_wait_cmd(struct psp_mbox __iomem
>> *mbox)
>>>          u32 tmp, expected;
>>>
>>>          /* Expect mbox_cmd to be cleared and ready bit to be set by PSP */
>>> -       expected = FIELD_PREP(PSP_MBOX_FIELDS_READY, 1);
>>> +       expected = FIELD_PREP(PSP_CMDRESP_RESP, 1);
>>
>> What's the meaning of "PSP_CMDRESP_RESP"? I see that this new macro
>> name is currently used by other drivers, but in my opinion "READY" is
>> more descriptive. (It is also aligned to the comment above this line.)
> 
> It should indicate that the PSP has responded.  I think both terms work
> to describe what's going on.
> 
> Tom - What's your preference?
> I'll either adjust all the drivers to use READY or fix the comment for v2.

I think the comment should be changed.

Thanks,
Tom