Message-ID: <9523a6ce-0220-e939-392d-2b48b2a4dc48@amd.com>
Date:   Thu, 16 Feb 2023 14:55:07 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH 6/6] i2c: designware: Use PCI PSP driver for communication
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        =?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>,
        Grzegorz Bernacki <gjb@semihalf.com>,
        Thomas Rijo-john <Rijo-john.Thomas@amd.com>,
        Lendacky Thomas <Thomas.Lendacky@amd.com>,
        herbert@gondor.apana.org.au,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230209223811.4993-1-mario.limonciello@amd.com>
 <20230209223811.4993-7-mario.limonciello@amd.com>
 <703033aa-1293-307d-42a2-9734a51c7190@linux.intel.com>
 <ca9c0f77-c191-d88a-22a1-315ca97f17e8@amd.com>
 <Y+5EI3XGBzuwwVBV@smile.fi.intel.com>
Content-Language: en-US
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <Y+5EI3XGBzuwwVBV@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVZVM29YbGFiUlgxTDlaSXdRNlVWNks2aGN4ajR2NlhIcW51V2ZtSXl2Zk1x?=
 =?utf-8?B?ZVNtNHJ3cGhTUEFMZGNtbmxKV1N1MElJL294N3krMmVtcWRqblRjV2U2dUNP?=
 =?utf-8?B?bEhPMUM5bGlUczNHc2dJR3daOC9peHBOWW9VTEh0S0h0SEdzQ0pOa0ljbG5j?=
 =?utf-8?B?SEh0RzR6VHcwL091QXo2MURvdU9reHJiYTB6YWtTb09nNFFWRnIzcHA4QllP?=
 =?utf-8?B?QVdNelZIVDgvNG1iS0MxbWhjd0R0RGFpUUJnWVl0RkpMYUpZMVNNTUIxa0dP?=
 =?utf-8?B?Ujh4d1Y3eEx4RUkwZkpBeVlkUmVyVGkwcGV2YnU2TTZOdk9hVTFzTVRqQzJk?=
 =?utf-8?B?Qi9Pc25DaVRpVWlGd1BEOS83UGx2QXFtNkpTWUpSbVRCaHJtc0VpdFIxNkNK?=
 =?utf-8?B?SWp5R1NNTmNMNkoxVzVaVUJUVlJudFNsOCtsVXlMZHhQSDRMVi9kZXNaN054?=
 =?utf-8?B?NGdReC9HMXdpY0sxbGJIMlYybVA0M2N3UVJ5bHJUQkJlWkh3UnovM0N3aWox?=
 =?utf-8?B?SXZJUWFOTFJuUm5yMUJNTVVFbGVxTzFKei9WbUxZMlBRR3pUSHVlbDBWK2Rz?=
 =?utf-8?B?ZXJReFpOTkZia3YvcmNpUGMvcTBFQm5YcXp5Nm0rU3VNT3RINXl1em1sa1g4?=
 =?utf-8?B?L3lDbldnb3FhRjRoSlQ1VE13VE40Vi9OOWVuQXprVWtPcmVmclBhVTVmT3Vx?=
 =?utf-8?B?ME93VkFmRnNWcGZEdkZxU1hMTXNWK1g4SFRWL0FIczdsTzdxUmx5cXdjZTZ4?=
 =?utf-8?B?WW9XY2Y0dUlWSWhLSFhkeUgybHRkQzVZbHlzQllORmFGRFY4aGtpbjQxakZv?=
 =?utf-8?B?YWVwVFROcTVXTHJQdzhOdjBkajJlZmJLL1JjbkZidjJiVDhIN0wyd2ZhOVM0?=
 =?utf-8?B?SGtxZVZyRHgvRXJ0Q0VYU1BZbmlacWlmamprZ09NUjNPK3VtL3dhQUJXZXRZ?=
 =?utf-8?B?NlhyV09rV3Q0VEZ4OFZpQ1JJUXU4bDB3cXIyRGZmYmZkclpHU2kxS3BkVzdk?=
 =?utf-8?B?d0VRcGFYQjh1a3BUTzFnY0dCSk1GTGdQUmlPdmVxOW9PODNYZ2xvMXBkanBr?=
 =?utf-8?B?dmNueDhQZDF3b2dza2l4UDF2NzBYU3h5YjVxNzZ3WkJxSDYxOXFRY2hSVDJp?=
 =?utf-8?B?dzd2ZTFIYzM1SUFHSTdoOWZXVU84ZUl2NzREQXd2YUVTSXF3amlLL2xaTFpG?=
 =?utf-8?B?N0FWSVZiajZ3VitHeE56SDc0Rnd6b0FDanI0TFkxVC8yVE1Sb3pBa1Faa0pJ?=
 =?utf-8?B?QUE2WVAwcmFieERGYmd6eTIwYXNrdiszU0piNGd3UHl4TXdEajZSeU1hM1ZE?=
 =?utf-8?B?SDlLRUo0SDAreWhCMFlzTkQ4aFdVbVJMOXhZbWsxUXpZR2o4SWtNcjBRRHc2?=
 =?utf-8?B?Zmk0cVQwMTFMaFB1enYvWW9zN3owTVNtcmx6TjI1b3gvYUhwK3dWdzRxV2tP?=
 =?utf-8?B?MnBUTXdydWdaRVFqSjRqbEdoRVY3bW1UWVplcC9nUGVnTUJmT3BTZVBKY2Qr?=
 =?utf-8?B?aWZsMzdrclJjR0dhSzJwWUNQM1hUOHliNjNNcEM5NDVOa0hsRy9zcFlORzJs?=
 =?utf-8?B?STBQOWpoOEw1ZVYwQllOTFF1WHdyakRMT1VRT0xsd0ZZaFFISTV1VFozOGVv?=
 =?utf-8?B?WnZUbno5WUUvSTU3YUJBY24yVnMyYTlGY1YwbytrV2V2Z2E3M0FhTStwS2p1?=
 =?utf-8?B?dUpGWVAyVzdzNHl0alc4NEJFT2l0eWRUV3VUdkpCb2RJMzFKSUxmUEd6UW5Q?=
 =?utf-8?B?ckpqUis0bXJGR2hQR3JEUVp6SU5hb2dkVWFWZDh4Z3ZUaE5sN3dzUU5mLzZS?=
 =?utf-8?B?L2ZPYjNCNjNXMHh1aHU0eHRCZUZyYmdTVXNKQ3MxWWU2MkVPRHNKMC84WFVt?=
 =?utf-8?B?VU5JYmluZjVGZzZDelkwWVNucExIQ0Zja1JmNWZPeS8xMGoxdjEwYklYclhx?=
 =?utf-8?B?MDFRaVl2UG9CRlN4a1dodE1YZ0NZWERIUUVxTFRUc3lnVTY4eFBwRS9jcUtK?=
 =?utf-8?B?cEpqcWhlcHRvQ25RSk1naVN1WGYvekJsYjdhSURVdUI5UDFtSDFTbU4zcjQ2?=
 =?utf-8?B?ZFRnakdTTU40QjVIY2hzdkU3QmdBNDd2UDZMTWN5QkFiVHdvaDJlOUlEeDlt?=
 =?utf-8?Q?5eItEMjo+ni/wEO/tmaRzJ5Z9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 741b0053-cf0e-4892-4c08-08db106017db
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 20:55:10.8084
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +VqsYstbSoG1hhfBMHLnLto3BanOBvna+sRC/owgCMDRxppKhEFFAK0rewbUf77B9m6+hyl12JTrCTNiDK4URg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5316
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 2/16/2023 08:56, Andy Shevchenko wrote:
> On Thu, Feb 16, 2023 at 07:29:53AM -0600, Mario Limonciello wrote:
>> On 2/16/23 07:27, Jarkko Nikula wrote:
>>> On 2/10/23 00:38, Mario Limonciello wrote:
> 
> ...
> 
>>>>      config I2C_DESIGNWARE_AMDPSP
>>>>        bool "AMD PSP I2C semaphore support"
>>>> -    depends on X86_MSR
>>>>        depends on ACPI
>>>>        depends on I2C_DESIGNWARE_PLATFORM
>>>> +    depends on CRYPTO_DEV_SP_PSP && !(I2C_DESIGNWARE_PLATFORM=y &&
>>>> CRYPTO_DEV_CCP_DD=m)
>>>>        help
>>>
>>> Would this look better if split? I.e.
>>>
>>>      depends on CRYPTO_DEV_SP_PSP
>>>      depends on !(I2C_DESIGNWARE_PLATFORM=y && CRYPTO_DEV_CCP_DD=m)
>> Yes, thanks I'll change that for next version.
> 
> I'm wondering if this is homegrown implementation of 'imply' keyword?
> 

Like this?

config I2C_DESIGNWARE_AMDPSP
    depends on CRYPTO_DEV_SP_PSP
    depends on CRYPTO_DEV_CCP_DD

config CRYPTO_DEV_CCP_DD
    imply I2C_DESIGNWARE_PLATFORM