Date:   Thu, 16 Feb 2023 22:59:28 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     "Limonciello, Mario" <mario.limonciello@amd.com>
Cc:     Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Jan =?utf-8?B?RMSFYnJvxZs=?= <jsd@semihalf.com>,
        Grzegorz Bernacki <gjb@semihalf.com>,
        Thomas Rijo-john <Rijo-john.Thomas@amd.com>,
        Lendacky Thomas <Thomas.Lendacky@amd.com>,
        herbert@gondor.apana.org.au,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] i2c: designware: Use PCI PSP driver for communication
Message-ID: <Y+6ZMEoQ2UoH7SxD@smile.fi.intel.com>
References: <20230209223811.4993-1-mario.limonciello@amd.com>
 <20230209223811.4993-7-mario.limonciello@amd.com>
 <703033aa-1293-307d-42a2-9734a51c7190@linux.intel.com>
 <ca9c0f77-c191-d88a-22a1-315ca97f17e8@amd.com>
 <Y+5EI3XGBzuwwVBV@smile.fi.intel.com>
 <9523a6ce-0220-e939-392d-2b48b2a4dc48@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9523a6ce-0220-e939-392d-2b48b2a4dc48@amd.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Feb 16, 2023 at 02:55:07PM -0600, Limonciello, Mario wrote:
> On 2/16/2023 08:56, Andy Shevchenko wrote:
> > On Thu, Feb 16, 2023 at 07:29:53AM -0600, Mario Limonciello wrote:
> > > On 2/16/23 07:27, Jarkko Nikula wrote:
> > > > On 2/10/23 00:38, Mario Limonciello wrote:

...

> > > > >  ? ? config I2C_DESIGNWARE_AMDPSP
> > > > >  ????? bool "AMD PSP I2C semaphore support"
> > > > > -??? depends on X86_MSR
> > > > >  ????? depends on ACPI
> > > > >  ????? depends on I2C_DESIGNWARE_PLATFORM
> > > > > +??? depends on CRYPTO_DEV_SP_PSP && !(I2C_DESIGNWARE_PLATFORM=y &&
> > > > > CRYPTO_DEV_CCP_DD=m)
> > > > >  ????? help
> > > > 
> > > > Would this look better if split? I.e.
> > > > 
> > > >  ????depends on CRYPTO_DEV_SP_PSP
> > > >  ????depends on !(I2C_DESIGNWARE_PLATFORM=y && CRYPTO_DEV_CCP_DD=m)
> > > Yes, thanks I'll change that for next version.
> > 
> > I'm wondering if this is homegrown implementation of 'imply' keyword?
> > 
> 
> Like this?
> 
> config I2C_DESIGNWARE_AMDPSP
>    depends on CRYPTO_DEV_SP_PSP
>    depends on CRYPTO_DEV_CCP_DD
> 
> config CRYPTO_DEV_CCP_DD
>    imply I2C_DESIGNWARE_PLATFORM

Looks okay, but I'm not familiar with this code. The documentation about
'imply' can be found here:

https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html#menu-attributes


-- 
With Best Regards,
Andy Shevchenko