Message-ID: <6217b51c-4982-8548-688d-8bfce97d3352@linaro.org>
Date:   Fri, 17 Feb 2023 09:57:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v10 05/10] dt-bindings: qcom-qce: Add new SoC compatible
 strings for Qualcomm QCE IP
Content-Language: en-US
To:     Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Thara Gopinath <thara.gopinath@gmail.com>,
        Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Andy Gross <agross@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-crypto@vger.kernel.org,
        Neil Armstrong <neil.armstrong@linaro.org>
References: <20230216131430.3107308-1-vladimir.zapolskiy@linaro.org>
 <20230216131430.3107308-6-vladimir.zapolskiy@linaro.org>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230216131430.3107308-6-vladimir.zapolskiy@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 16/02/2023 14:14, Vladimir Zapolskiy wrote:
> Introduce a generic IP family compatible 'qcom,qce' and its two derivatives
> based on SoC names rather than on IP versions. Having a generic compatible
> is only partially sufficient, the QCE IP version can be discovered in
> runtime, however there are two known groups of QCE IP versions, which
> require different DT properties, these two groups are populated with SoC
> based compatibles known at the moment.
> 
> Keep the old compatibles 'qcom,crypto-v5.1' and 'qcom,crypto-v5.4' for
> backward compatibility of DTB ABI, but mark them as deprecated.
> 

As I asked at v9, please mention that you document already used v5.4
compatible. You do not "keep it", because it was never there in the binding.

Best regards,
Krzysztof