Date:   Fri, 17 Feb 2023 11:14:50 -0500
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc:     Steffen Klassert <steffen.klassert@secunet.com>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] padata: Make kobj_type structure constant
Message-ID: <20230217161450.blix7iek7duexlic@parnassus.localdomain>
References: <20230217-kobj_type-padata-v1-1-e70b6cab4875@weissschuh.net>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230217-kobj_type-padata-v1-1-e70b6cab4875@weissschuh.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?rvJh+16N4vW94NxUh4uIr4jMJdn71FS4nU4BoL4JGkdrmmYVuyfi0jVpWu?=
 =?iso-8859-1?Q?QQjZp+ApcjC+bAJ7NMe3pPQKUm3h0f5fz/O565Nx+DPdHpC7SFGaJu+SW0?=
 =?iso-8859-1?Q?pdD8GhToB/+39+A9WEi0P5Q2SZzFO0RqJoNt+jdMZJjgjtIWoyA1+n50nj?=
 =?iso-8859-1?Q?nBwM5JZWt1d2wiWaCFbMRWeZfY/FdeZ4Whi2fFRYzuyj8zhbxJYEBS7FzQ?=
 =?iso-8859-1?Q?t/+TuKbzqrS8R+oEAxJTKlOufSpJcP/HTHPD+gFYrV7dMh0R3DjJcdKptD?=
 =?iso-8859-1?Q?YWW3/EQ1xtnl+FTxbSfIG4gsVR7BevL/xCU+dzj3Trt50bYT+tZ1AmJ7wm?=
 =?iso-8859-1?Q?Z5vq+UtDQb7LJ4SekRSmttoUzskex9Dy3FRnXXjmIG6LHOmBD++2batZxH?=
 =?iso-8859-1?Q?0UxKEUjHoaWo5NXwNTsesugyk5AgJNSi/gqCT/OhmdijNppAIJGvk+9b7E?=
 =?iso-8859-1?Q?i5KDGvjz9aac+RDLNl29Vr0uiaOBERVGrBTsJ/9Xp6y8VV6VBZv9lfEPle?=
 =?iso-8859-1?Q?cyIO4obCp4MYwheKq/kclafJ/vJED2QNGw4FEp4S5gEVw4RAk7hy6Srbel?=
 =?iso-8859-1?Q?52o46vx/4kwK+DRm9C+4lKIOoYCzQcrvRpsI3vTl5PLNljbsUFJ9mUbBOe?=
 =?iso-8859-1?Q?nhfk6b4aMH//8QWRk+xzmTF+pVGKxQlXKFEgQkUw208f+xHkK+UM534OJv?=
 =?iso-8859-1?Q?a7PMQGWP71DuezVMAUuuYRRk7ggQgWeKAT0eP4STuH31B7fNrogofMtpLd?=
 =?iso-8859-1?Q?81DAoi3UzySuMVlhpl9gB4bvHAfw3oEiJmWDpEqPdWUru7Sl+3r2Yx65wi?=
 =?iso-8859-1?Q?GMZfzOJ7gdrPV9Tvkto7HbyMS+Cg5nZAZqKCc6aUvjvfnIG07BD+PnnVa2?=
 =?iso-8859-1?Q?vqqNmzts3bhplrO6YqJs/wnDzzs1I6kz0v9kKlC4rlOKzqEoiOo2DUFNIQ?=
 =?iso-8859-1?Q?QvyOw5XeGCi15Gu3wdfQbioV/AREDg89Lg2YOHRSHQgM8BY2iFr2chxgp5?=
 =?iso-8859-1?Q?aWMA//yAXc1sAgadRHD7/f2ucqxbGkAcsFgsaI5DCvtQnAOjyiTRsLLCvJ?=
 =?iso-8859-1?Q?udwBxs6Q5YRkJ8FuJPZef9zvy8y6+8SpnuUxf+CUS+l8qjuo1mgPN2kbjT?=
 =?iso-8859-1?Q?Q88MXUCg8qSAMaazEapW7VE5pzSZLPeZEgRrBQMeAotpOg8jTYApi5mGyx?=
 =?iso-8859-1?Q?mb1HEQY8mTWwn6hPv6z5XTma3LiZq5b+M65lYHUdTaRuOEie5qZ3Y+oSlY?=
 =?iso-8859-1?Q?8XQQ6kWf6OkP5cdc9GOMKioDYg/DjVhY5jJ6f0MFXDnqYnEZVKgQzuNBRj?=
 =?iso-8859-1?Q?fzDuq/r5qMRmoXROhZ5az+Dj9Iq2WenvUM4mK+Tc+P+zRDJNyg7NQb1jQb?=
 =?iso-8859-1?Q?1wUe4hpVT8uX2XVTqYLZD+kF9jdWffHvz2Sf50Rqb3lmrY2+nMF/zTz9xt?=
 =?iso-8859-1?Q?/X9Q4BBZBcYrNQ5Gxma/M2HTVGYg4XeU/yYND7BTu3a5vkBVarggFxub+I?=
 =?iso-8859-1?Q?vAUChbszgLuwmQVuMVGXugI8NtqwwTJojUdhqQ3KSQPzBgTvoMVKKX8rQq?=
 =?iso-8859-1?Q?E/WnhRreoObmWeixOOhgoAmtMR2LPvfurMcvPYz+uulECw9NaGMA5xfIsh?=
 =?iso-8859-1?Q?I5JfNaj172WCf1rBNYecngX/AdgWogc0602B3iHXtitUBDW9kHhu72pw?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: dy6LlPmwLe+ncs6l5MtDRolW6/UutydZ3jWCAsFU09rhiXhjjh5ICgP9/OT1ib1lD+8ct8LI0VSe1gEZF9LdAJBT/0R12j2sm+T9gxXJMMEk5Kw5GMk1jvz1Ou1JV6xJ88tnbVCVltFb/ijrC6IDIT3hx9Ezm7COVmMfwY4xDivwnv7WTe3QJa2uKclqPHITFrnQkwlvep7gjqxGzKzR7CcKrqR0G+ENv2Xofobhpb+e2k0v/eJMMEXFhm0QVGq5IR89G4+M8V6XCtjpTsx8NRSpQfFR8Np2v3bCFpBeS9wwDjN+Sl6wouR7wWDgJi5b4a8VrYG+jsIGUOAkSb1yzEyzAouQkzhW2sekBunjYpfOh21egE7XfGlMTxD3zSSr4wlaeW4xPbFCwrA3xCeL76hkafaFDnaIcD1j9xlaTY1r20hHVZLcuHTOkKdWy/i4IXR0INaG5zOExDzkuQpbDWD3Mkbu+mGJZJl97YPtMp0wchp8XPy/wxVQHNDp2pX6r+L40A5Y3RD52PTa0fM3UNT++rkjk3V4Ij64u6MZ0X1qfmfbWNQGSvtDfP/H+ESl1Wsn4KwPIpdpZ7DWljYn01yEGh0L0fR0K0x1FEfBrwBeUCzx8A9zJQ3YFUU8V06tsiwFZaqhWZt6MhR4F6kuGU1njS9hlyh0a5Vu75hi+SBw/0kPXYU7qoMg72haj6NISQSUuEAYKvNwyBKh1igAkO3IGweRJ7uF+iCB6dbR4pBRmPSg5xqfUF1lLpqJ7rlJWNr1B4uV5ZBEqCL624i7OMPFfLsi/aYFgDqaO2I/UtMSRIJwSpZ6c2jfNlK4h0ZP+ICLwWev4+3UdSQvBEAPaQ==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad874ef4-fedb-4f2a-5a03-08db11021aa8
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5711.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 16:14:53.9935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X1R8MwLdi1tGFPaIy5Il7VCjypfUYVkVOVVZU4ObEwxNYna9vEThLQwMd35PdgnPZTU+N2rKCbB8JGBI9jyoXBjK9iSLy+UMAGYiRPELu80=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6471
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-17_10,2023-02-17_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0
 mlxlogscore=999 phishscore=0 spamscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302170144
X-Proofpoint-GUID: wGipZ43OcmKd7QiNSycIE5v5qo-ucxXl
X-Proofpoint-ORIG-GUID: wGipZ43OcmKd7QiNSycIE5v5qo-ucxXl
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Fri, Feb 17, 2023 at 03:17:49AM +0000, Thomas Wei?schuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
> 
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
> 
> Signed-off-by: Thomas Wei?schuh <linux@weissschuh.net>

I see the symbol in .rodata now.  Thanks.

Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>

> ---
>  kernel/padata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/padata.c b/kernel/padata.c
> index e007b8a4b738..106d08ee9ce2 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -967,7 +967,7 @@ static const struct sysfs_ops padata_sysfs_ops = {
>  	.store = padata_sysfs_store,
>  };
>  
> -static struct kobj_type padata_attr_type = {
> +static const struct kobj_type padata_attr_type = {
>  	.sysfs_ops = &padata_sysfs_ops,
>  	.default_groups = padata_default_groups,
>  	.release = padata_sysfs_release,
> 
> ---
> base-commit: 3ac88fa4605ec98e545fb3ad0154f575fda2de5f
> change-id: 20230217-kobj_type-padata-288edceca728
> 
> Best regards,
> -- 
> Thomas Wei?schuh <linux@weissschuh.net>
>