From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     Danny Tsen <dtsen@linux.ibm.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
CC:     "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "leitao@debian.org" <leitao@debian.org>,
        "nayna@linux.ibm.com" <nayna@linux.ibm.com>,
        "appro@cryptogams.org" <appro@cryptogams.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ltcgcw@linux.vnet.ibm.com" <ltcgcw@linux.vnet.ibm.com>,
        "dtsen@us.ibm.com" <dtsen@us.ibm.com>
Subject: RE: [PATCH v3 1/6] Update Kconfig and Makefile.
Thread-Topic: [PATCH v3 1/6] Update Kconfig and Makefile.
Thread-Index: AQHZQuuGDnnRnVY7A0GShYfN/q6Vy67TobxQ
Date:   Fri, 17 Feb 2023 21:44:37 +0000
Message-ID: <MW5PR84MB1842DB9DF917B9B3B83A005BABA19@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20230217161805.236319-1-dtsen@linux.ibm.com>
 <20230217161805.236319-2-dtsen@linux.ibm.com>
In-Reply-To: <20230217161805.236319-2-dtsen@linux.ibm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?urmgQHfFpv7ITom0Yw3HMX6cKdr25nzoQY1lHNDk8LKghbqNNNLgLRXELtPX?=
 =?us-ascii?Q?TWDyt0Oagiy2ww8go0ZfetN+B/MJp00SNW4IpyZMBnQPYyBsZBtBrRgU2GuK?=
 =?us-ascii?Q?+Eriis7A8Wo88qNQfBe6CicqLEhIxL4pdL6zrleNHfcdVvA2egTCit2/nM6C?=
 =?us-ascii?Q?d523ps+6Qe+mm1BAD0VbAKYbeMn+kfsWQ6/GbzH9KPeuH2mL/ABBRHItlVtX?=
 =?us-ascii?Q?g3BWHDm3k+QW/zEVbViubaB2+DV7ecZFiNH7C1LyaluVJ+KF8RtrB/3zBtE8?=
 =?us-ascii?Q?ILGX2yKxBUFk1O+ipxfz0WGDxDvC9IaKkY28fqItsoQ0CIRm1WP9NAHhJsrX?=
 =?us-ascii?Q?+FujFt3pPem2fwv2VKndbzNauO9rSYBSvZBSdbnEcuAx7z5yN28pgi3w9dau?=
 =?us-ascii?Q?1a+pLpyHRlBmASW4/IEVpQgthms88HiV7w6Euuh4Df8KXue7xPoahkuhb+rv?=
 =?us-ascii?Q?JTPosl5pLGLppcpLiGE8i1sbm8zKKx4AgUcnFo2le98QkOhRNyuukgZtTYwL?=
 =?us-ascii?Q?xUv1wTNGs4BND/mkzazZtzc/GBuFbPNahI+yCn4oHVoYnTsC14gJ/f/PxWS3?=
 =?us-ascii?Q?ihdbUuJbY4jiEsSha0wQkpB7RC9zW51wa7rVt+kX+zeD8KwYhK2aA0njyd79?=
 =?us-ascii?Q?HgqebqLbnIUTmZsTD525ARKnTIQsBdUUUwPxNDf3h3SeebGH5p7zul9uQkMM?=
 =?us-ascii?Q?JuEkNZca97dnsWpuN2B6SEu6fh0Mf6WOpSzXL8TNPdqgaZSuw377w0ZflP/T?=
 =?us-ascii?Q?+7CZAzr7va0n6M+4ktPZn85D8UD+YcLebB6CLxfdiF6TolIsM7PYNQtlotq2?=
 =?us-ascii?Q?H46IRqZYEmTVymdeEOK190m8wZN2UmknX+K9AJDrQoV+JGZoeO3UYMZDtD7p?=
 =?us-ascii?Q?ifVKi8mztgWNQjuO5VPPs5m6OO2o4zUm3AGbeHDyc3cXG3ys6ya6vpaH0vdk?=
 =?us-ascii?Q?8Dmontb5lFom6xfPt/xsMLV0rC5r+X4GR2Ss8SnfENLHbfpCEvbXZauH81VW?=
 =?us-ascii?Q?Y9Y/LVlb4EeCoFo65hpxv16t9x7g9f1vDkXwCzCZYwrL9YD/tstBcMPtzilf?=
 =?us-ascii?Q?OVeu+M0zkNjSpRBkNoLXYHXmlnmqoVxCWLWHK52uLGXDWb9BP5l2H7NoYtkj?=
 =?us-ascii?Q?PSTud7bM2ADT4MvXEilp2tLb4+I22RP2kt+SHiz7RMDHx7HF8MZXbUPKoT4/?=
 =?us-ascii?Q?RtLiE5MJYrQ6WyyFZnVJhcyoZvLqgyZmSAUI9sVHytnGjVX74YRX4togpOUq?=
 =?us-ascii?Q?LF6FuWoaCQpVCIxno8Asl3ZstPz6EBqEtKdoi0QhtJCUcWk3g6E78wyuPGMB?=
 =?us-ascii?Q?ncDsTifwRTh3wga4+YLlpg48Y2sx+oPmYA/NcdKko/1eheHqonMsZ2La6sIu?=
 =?us-ascii?Q?oCX+u1ZEOivlI3afKH2u8xRJ0kpjoDw7sDAficHPUBumOGyfvKY4igleCXQc?=
 =?us-ascii?Q?tvtm6pM7jlAsre+pAWDp1Llqw7Uye7fMNjSkah20sYG35A3WLutsLu1wBMVZ?=
 =?us-ascii?Q?Q+TIBLZb1QshEACmxRjiDav4S6LqySkQ/XMpQmRF0U9wMEahlmETuaKUS2ol?=
 =?us-ascii?Q?Uu5q9u7jbirYDjAFJkk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: a4de8a0b-d227-47bb-a330-08db11302af1
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2023 21:44:37.9482
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x0BeupBwrbKgvj/UEVY2QMvSSenh6oL4NOwDCXYE13IrwDZ34TMYbI0f1HH0O+5J
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR84MB1431
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: 1OpJb4UPyBMehuBmrcspCq7OikZZ2A1x
X-Proofpoint-ORIG-GUID: 1OpJb4UPyBMehuBmrcspCq7OikZZ2A1x
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-17_15,2023-02-17_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 suspectscore=0 mlxlogscore=940 phishscore=0 malwarescore=0
 priorityscore=1501 mlxscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0
 clxscore=1011 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302170190
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> +config CRYPTO_P10_AES_GCM
> +	tristate "Stitched AES/GCM acceleration support on P10+ CPU (PPC)"
> +	depends on PPC64 && POWER10_CPU && CPU_LITTLE_ENDIAN
> +	select CRYPTO_LIB_AES
> +	select CRYPTO_ALGAPI
> +	select CRYPTO_AEAD
> +	default m
> +	help
> +	  Support for cryptographic acceleration instructions on Power10+ CPU.
> +	    This module supports stitched acceleration for AES/GCM in
> hardware.

Is "Power10+" a specific architecture or does that mean "Power10 or later"?

Please follow the newer wording conventions for the menu item and
help text, more like:

config CRYPTO_AES_GCM_PPC_P10
        tristate "AEAD cipher: AES in GCM mode (Power10)"

        help
          AEAD cipher: AES cipher algorithms (FIPS-197) with
	   GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D=
)

          Architecture: powerpc64 using:
          - little-endian
          - Power10 features=20

          [some description here]

Also, all the other powerpc cra_driver_names follow=20
	alg-arch
not
	arch-alg

so=20
	.base.cra_driver_name	=3D "p10_aes_gcm",
might be better as
	.base.cra_driver_name	=3D "aes-gcm-p10",

Patch 4 seems to have code for lots of other modes like CBC and XTS.
Does the perl script strip out all of that?