Message-ID: <f1675b6e-fb57-0331-7c39-ebf14f1d0f16@amd.com>
Date:   Mon, 20 Feb 2023 08:49:57 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2 0/8] Support ACPI PSP on Hyper-V
Content-Language: en-US
To:     Jeremi Piotrowski <jpiotrowski@linux.microsoft.com>,
        linux-kernel@vger.kernel.org
Cc:     Brijesh Singh <brijesh.singh@amd.com>,
        "Kalra, Ashish" <ashish.kalra@amd.com>,
        linux-crypto@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org
References: <20230213092429.1167812-1-jpiotrowski@linux.microsoft.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20230213092429.1167812-1-jpiotrowski@linux.microsoft.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHFveU9tZ21WaFV5TEExL3lVVDAya0ZOZEZ6d0owZHdZMGsrSjJ2VDJJNGxk?=
 =?utf-8?B?V1RLamUyU0Zyc0pjdkcwSXZqU3ZzdnRJTzR6RlNjajFFUWQwMmZ5Y3RUMVcy?=
 =?utf-8?B?UTFLNTZnVWRKMjhRVHN4cXJkS0h6b1R4RTYvaUNNZlJGRS9KVnJDbjlGaHdL?=
 =?utf-8?B?M0Voa0pqakVvdEdoWm1mb2ptQ2pGMFFPaURxRUxnNHg0enZENUcwaDdhMGl4?=
 =?utf-8?B?dWhxcWEwaXJxVUVMdU9heVRkelZXSGZmcXlObFhvbTY0L0dzVndmRTlRUk04?=
 =?utf-8?B?YUF4MFlxcGtMK0dWRjdETy9uNGpxS0JlS3dRTjNCT2lHYitEbExzS0ZyeFVV?=
 =?utf-8?B?Ymp1Qit3Z2RyYlo3Mm1McVJEcW5XeXZlKy84NGhFejZOZVpDWkZZZW1tbHFl?=
 =?utf-8?B?MG9XRk12ckFDSDF5d2hUYmNsVjNoaDF2aldDUlZRZXN1ZzI3QXdIZWF1LzBM?=
 =?utf-8?B?cWd3MXVWbTdpZGU5RjFOSWM3YmpBOFZyY1NKWkdFMnNUeUZBK1FCMDd1QURq?=
 =?utf-8?B?VE8yb21uRjBraEEyMGtzTzNVV2hpaWZFOXdOTzNKc2RZYXE0RFFTTzFaV1ZN?=
 =?utf-8?B?MThrSm15UVAvZWlyb1l3N1RQT0h4SFJFOVRCbzFhUDF2Mmo4V1RyeUNsa3Vt?=
 =?utf-8?B?cG1kd25uU3hmLzBKV0sxU1NSc3VONXlFcTJDeFVtYUoyOHllbk5Cc2twejZK?=
 =?utf-8?B?cW8yMmNxSUY1enNUbHpDSW13VGlLV0tXVUc2dmhCZlMzbnpJY040ODhxc3Fx?=
 =?utf-8?B?eTVlN3VOdWx3SHRkQ2dXTTJ3eWFMS3FoMDZTR2F4MTB2akdyeE0zdTJSR1pj?=
 =?utf-8?B?QmtRSmtuV2kzc2ZFNGswNU1kZHFySDZwMGNJZE53SlhSKzk0bkY1Z1ZYUkVO?=
 =?utf-8?B?SU8xaHNYdThsOGNkR0JkekRiYk10eXQ4M1hEdGFRbE8zZ0NyMWxaOG1FN21a?=
 =?utf-8?B?dFpDc3ZHQ21Pbm1nMHNaZFlrY3RZR3dLTzJYSDY0RzlsRDluSWVjVjkySC9s?=
 =?utf-8?B?TmVhbkE5eVZITW9GdEJnYWxxZGNNVWxzbHdZUXgzTXpnaHRpWnNIUzVhWjda?=
 =?utf-8?B?Q0xRMjMxTHJMd3VJSXp5V2J6SGp0WVZUNzFrZEVoSXNDa3ZMRTc3T1lJNmJH?=
 =?utf-8?B?Yi8wbDA1L1gxYWdIQWJOQmw5UHZiNks4VDEwZVJmOG5Md2hjc0Q4MjBDbE1X?=
 =?utf-8?B?SjRsTHJnckNxUU5uTTZybkdBZFQwaDR0aGlIOGFVSXFmNGVnRVJSQ1hmckJB?=
 =?utf-8?B?YS90M09uNVR1UGRSQ1Rhc2QyMEhHRzZGaGVtZ1FyWko1aTdzRzRMNVEwNGtM?=
 =?utf-8?B?UWZuWUZnNHZoQmY1cUFzUW5xaklFUWdaV0tnUzMrWUtlcW9QZitPQnJCMFBW?=
 =?utf-8?B?L0dhSVd6WnJpRnhZMW5GYTQ1V01GZWtwN2NsUjcvL0JkRjkwenFCZFRET2hV?=
 =?utf-8?B?NFpMNnpKUHkvcDRuTU83blRpMmhSa3E3NnhEbnN2RDhjZmQ0YzN4c1lPcThU?=
 =?utf-8?B?TVlZT2lDZGltd1orcEoxRGFSWGVuL1VDVFdKbEVxd25sSk5uTTd6SUhoZHN3?=
 =?utf-8?B?Tlh6bTdmU0VVUlVyTS9PVUU5RzBKSGJrSUgxaFh5RjV6Nk1FaTRnZUNZSkt6?=
 =?utf-8?B?cXZHV1NCeC9KRk5ieEp2c1pRTXlacWhYUjNIR09aU0JxZFp5WGtjb2tHcXRz?=
 =?utf-8?B?MGJvOEZOZCtwVEJMYUJ2Q01jSzJKY2p0YTVSaFpaTGE1ejZDMHpoNDUwYVJn?=
 =?utf-8?B?MGRDVEg4YmR3dTRGQ0hkcVZhOEdJTVpITUpUYkJ0NjFIcFNPZmxaQ2l2RVVo?=
 =?utf-8?B?blJSS1lRREJOa2svcUlYSDNhbmxIN2FxY2J4bTVxcm9YZHVKUlJYcmVhM0xK?=
 =?utf-8?B?a0lwRDM3Z0hyWGtRTXFUNTBGYVZldUNjczlJdEhEOHkrU05VTVNRTm1Kei9n?=
 =?utf-8?B?WEx0S2xSbHZzUFJpZkpCaS85M1YrbnIzOXBQNXorQ1B0Uk5pUU5kMFZmNFNm?=
 =?utf-8?B?NkF0ZTgxa0czQkRZVTNnNEtFcnI2RkZnZWorZ1ZOb0lWODJhMG9IOEdUL3FJ?=
 =?utf-8?B?MjdPaldPZjRobWJaS1c2eW1hS1BlTTZ6a0VNOC9VWHNDTk5PVnZsb1VaZm9T?=
 =?utf-8?Q?Nr4KrBWbA0TDFzXZV7BohW/9Z?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb4fac27-4664-43a8-287e-08db1351bda5
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 14:50:00.2116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hFaPAmRMQAYOSQxMiAl3vjJlvT/X2lr/x6NIyHl0AEUiPfhxQ1570oABe3Dvj06wPi3OSPzTXIIciWv87b/Krg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6332
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 2/13/23 03:24, Jeremi Piotrowski wrote:
> This patch series introduces support for discovering AMD's PSP from an ACPI
> table and extends the CCP driver to allow binding to that device on x86. This
> method of PSP discovery is used on Hyper-V when SNP isolation support is
> exposed to the guest. There is no ACPI node associated with this PSP, so after
> parsing the ASPT it is registered with the system as a platform_device.
> 
> I thought about putting psp.c in arch/x86/coco, but that directory is meant for
> the (confidential) guest side of CoCo, not the supporting host side code.
> It was kept in arch/x86/kernel because configuring the irq for the PSP through
> the ACPI interface requires poking at bits from the architectural vector
> domain.
> 
> This series is a prerequisite for nested SNP-host support on Hyper-V but is
> independent of the SNP-host support patch set. Hyper-V only supports nested
> SEV-SNP (not SEV or SEV-ES) so the PSP only supports a subset of the full PSP
> command set. Without SNP-host support (which is not upstream yet), the only
> PSP command that will succeed is SEV_PLATFORM_STATUS.
> 

For the series:

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

Probably want Boris to weigh in on whether he wants the new psp.c file 
located in arch/x86/kernel, though.

> Changes since v1:
> * move platform_device_add_data() call to commit that introduces psp device
> * change psp dependency from CONFIG_AMD_MEM_ENCRYPT to CONFIG_KVM_AMD_SEV
> * add blank lines, s/plat/platform/, remove variable initializers before first
>    use, remove masking/shifting where not needed
> * dynamically allocate sev_vdata/psp_vdata structs instead of overwriting static
>    variables
> 
> Jeremi Piotrowski (8):
>    include/acpi: add definition of ASPT table
>    ACPI: ASPT: Add helper to parse table
>    x86/psp: Register PSP platform device when ASP table is present
>    x86/psp: Add IRQ support
>    crypto: cpp - Bind to psp platform device on x86
>    crypto: ccp - Add vdata for platform device
>    crypto: ccp - Skip DMA coherency check for platform psp
>    crypto: ccp - Allow platform device to be psp master device
> 
>   arch/x86/kernel/Makefile          |   1 +
>   arch/x86/kernel/psp.c             | 219 ++++++++++++++++++++++++++++++
>   drivers/acpi/Makefile             |   1 +
>   drivers/acpi/aspt.c               | 104 ++++++++++++++
>   drivers/crypto/ccp/sp-dev.c       |  66 +++++++++
>   drivers/crypto/ccp/sp-dev.h       |   4 +
>   drivers/crypto/ccp/sp-pci.c       |  48 -------
>   drivers/crypto/ccp/sp-platform.c  |  76 ++++++++++-
>   include/acpi/actbl1.h             |  46 +++++++
>   include/linux/platform_data/psp.h |  32 +++++
>   10 files changed, 548 insertions(+), 49 deletions(-)
>   create mode 100644 arch/x86/kernel/psp.c
>   create mode 100644 drivers/acpi/aspt.c
>   create mode 100644 include/linux/platform_data/psp.h
>