MIME-Version: 1.0
References: <20230221013414.86856-1-yang.lee@linux.alibaba.com>
In-Reply-To: <20230221013414.86856-1-yang.lee@linux.alibaba.com>
From:   Gilad Ben-Yossef <gilad@benyossef.com>
Date:   Thu, 23 Feb 2023 09:33:31 +0200
Message-ID: <CAOtvUMeMe=vwhC39FpGQJ2g=FKT5wKnT1pnT2XCS+c=4cBzyQg@mail.gmail.com>
Subject: Re: [PATCH -next] crypto: Use devm_platform_get_and_ioremap_resource()
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     davem@davemloft.net, herbert@gondor.apana.org.au,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Yang,

Thank you for the patch.

On Tue, Feb 21, 2023 at 3:34 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/crypto/ccree/cc_driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_d=
river.c
> index d489c6f80892..c57f929805d5 100644
> --- a/drivers/crypto/ccree/cc_driver.c
> +++ b/drivers/crypto/ccree/cc_driver.c
> @@ -350,9 +350,9 @@ static int init_cc_resources(struct platform_device *=
plat_dev)
>
>         /* Get device resources */
>         /* First CC registers space */
> -       req_mem_cc_regs =3D platform_get_resource(plat_dev, IORESOURCE_ME=
M, 0);
>         /* Map registers space */
> -       new_drvdata->cc_base =3D devm_ioremap_resource(dev, req_mem_cc_re=
gs);
> +       new_drvdata->cc_base =3D devm_platform_get_and_ioremap_resource(p=
lat_dev,
> +                                                                     0, =
&req_mem_cc_regs);
>         if (IS_ERR(new_drvdata->cc_base))
>                 return PTR_ERR(new_drvdata->cc_base);
>
>

The patch itself is good but can you please avoid the line break after
plat_dev, it adds nothing to readability.

With this minor nitpick for the next revision -

Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>

Gilad


--=20
Gilad Ben-Yossef
Chief Coffee Drinker

values of =CE=B2 will give rise to dom!