Date:   Wed, 1 Mar 2023 11:36:47 -0500
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Anthony Yznaga <anthony.yznaga@oracle.com>
Cc:     steffen.klassert@secunet.com, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] padata: use alignment when calculating the number of
 worker threads
Message-ID: <20230301163647.zkldvrdkkqxffvo3@parnassus.localdomain>
References: <1677112392-17332-1-git-send-email-anthony.yznaga@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1677112392-17332-1-git-send-email-anthony.yznaga@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hJoOGIo99Gz2srpLKzIam7kwnlAT3J2NHtJZLXvQpUsEN6JSFqWp2WUeXuO1?=
 =?us-ascii?Q?5hPatqat04f+JUZA44CpZ7TU2EK+4D5TI/QafSkH0eVEbiXYJLa6u1jREYXj?=
 =?us-ascii?Q?mL0AbUNKLsPvwjLlUF/EDAS4IpYq+mHaKlPisTckBDZga2VZvLrHLuzZZWsQ?=
 =?us-ascii?Q?sLK4+WuJTZUAW5o+Wee/pggPgn+VLxWOLwv+IqFTuDJY9MDYC0fiii8693f4?=
 =?us-ascii?Q?pK3uF0RSWbsmuVNyvNMxcrm6RVydCQbE5z9+OTh3owkiXm4Fm6QK1v1tvhOa?=
 =?us-ascii?Q?slqbiaRyzbDQflr2uGdNk3jA8bdd4snzVN+Cv4II0KMJVLPXq8f2QLXTxeUG?=
 =?us-ascii?Q?om18X2Yaoa8JyrJ9UhuZm10zjVUFWrb6yiPMQt+x33cVXq2UWFoB5QiL9TvO?=
 =?us-ascii?Q?YiM3a6uYFXu1nAnBofkZEOXdC9cDNm1nc1VPeVQRUq3oph7T1+2QYRRxl+d8?=
 =?us-ascii?Q?EZ42Y7s9MD/j6OCTDvvo8gwmGu4uQ1Pblrm18V4O9P2ZQyuU39OlvkM7JhvD?=
 =?us-ascii?Q?TxZgSRcqGRiGHKU+F+5sBNhZdrkrv8os1OODk0f1KK66CTfc64cS+m+CbOMR?=
 =?us-ascii?Q?XGo2sVnyJzrKBKihnbSFJ7wbE94HJiI3MgprYOElY49uSrE4yY8ZUa+rrF1W?=
 =?us-ascii?Q?i6+34t+UL6jgNcBHAtd1oIuT/eDZuXVugjJaHs3d1bDw0JFeLILr0c52GUQ6?=
 =?us-ascii?Q?mUetttwmzwJQhwQZpGMXEUJqfiE0Kwd1yUssgsvbT7lkFIXSo7f8D6HPe3OS?=
 =?us-ascii?Q?slF0rBdx9d4sc16CD8ez6vz8y19ZbS1kaix+oC5zR8cEwALewMn5tenG0m0/?=
 =?us-ascii?Q?GY+yXa3A8zPUfbFXnOvHwO1nkInh884VVWJ/dqrIHXHvnkYDS9gJdCotIIuY?=
 =?us-ascii?Q?N254uDb9RwkOh0rK9IS0rTtzgBgNCm6fbBUetyqzO9vYL7s2a2flwo9On3gu?=
 =?us-ascii?Q?boq9QtutbZu0oidDuvUpGxO4rbJkfbQ0yT4fevKowUNWl1CR87El8QYd6+jD?=
 =?us-ascii?Q?YKXMAz9aPvrm3LAfYOZccKeWbu5w4BGsbDBDxlOobRx1WCr/KLNcoTotRJU+?=
 =?us-ascii?Q?sBm8kLl7Ypi68zQ/U74lL3CUEfXiK5xffuRRct9I7wPg8dAcYfTGlBqRp9b8?=
 =?us-ascii?Q?svYaTPT0gulZdOBqjUUn5NZ3HArcIOWvxJ1QxPygLtlNDfA+7x7rzJTacS0s?=
 =?us-ascii?Q?8GyexjmLGcM2cMH9MYTULC6VN88KvJSvfieQdTONe60XX5yDNhe1jkd1/QaJ?=
 =?us-ascii?Q?G+KMHN1lK29cD8QIz/dndVFSh1X3O5K4lXxtgb++b9M/PupEmpWkL1z0AAe5?=
 =?us-ascii?Q?gzHyrsSxPloYXla7NUK4wPzZMscCDeR3Chv+kIwhdS6FYXORIAA0Qi1EDGl4?=
 =?us-ascii?Q?PMkKoXxyCP78D1nOn0zcG01nE4ImSByl06GnrVirqSONjTpd0kYFNN4/UYOD?=
 =?us-ascii?Q?5M5WgoB4Taw3y6dvyfun/lrVe77McVVNngpJftSl7ahMPCimGnIhHfluDY40?=
 =?us-ascii?Q?ISm+99ZWZ9fNHrJxaq9LHMAibTPdKrxX/TTaTTk1FNPvp/vkqna3AisUlzRR?=
 =?us-ascii?Q?z//W9REBDfaku7wxRHVIrJOqIK+4SRNE0vKgpR7x0H0oRSQ8FjkcDvoCJpS0?=
 =?us-ascii?Q?+A=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: M49kVcvzwN+f8g/0DS6Vl4PFntqzf3y3yS7MJ6bouazezHYwOAA/yMVFE8cr0cWBMx1XmhYMbeFA4RjbbKzPM0OD66ZD4x9VRKSSYUZCb8Is+zjM7ZZqKUpdBRGmGwZJVhhhpdlCyX/rSRda0Yngm24KG3Xp6HIVtMu/oOdYInc8oTRdEYfN5v9o5c/96BCMY4ex+ASNw5OKD2iuMl4+IZfIuNmYyr8/gvNYwVnfEQbDmEcWv8m2KgpCUMLAbQV1gaHJHXNxRDuz9k/Gn+/tx74iPQRYe1rY7felxqPxYZRSPN2SghVyF+qsOrr6FjOy8dukgv/H11kJa+UzAXnezhiS+32a3mRb6kqqFZnt8bTOj4IAb4xHENSmT1DvFPethMaf9u2Pd7BJjal4O6IjvK0LwENM9OVpz3Db1uIxXpW0gkkTBJKHkvjj7Tpv+Aa5u8tIEbr6U/2Z+beoVfqi0EjiaePffNX7ZNLFljnZoEuDxcYe8qR+6tWl97CSCVarnZRyEJsIl0B00kRjwQsWVLoFnIbT8OVfFEyusdZuWOmfS51ezOZ7UPYNsx8QBytflRGHehMNVvS3W4TaVcyyknkAWoiqNYN8/NJyrLAFtfmq24hwkmPgN+oLsl3KuuI4WrayvkZgfGerFAr1p14yIaCYYPkuApHMUqWQ4dYq843H1BtnRCS9o8dHI9Du3RmilNAZaglAWS2vquMaNxFP4QoT0/bG1fWLiBi8uZprPp0+Xvo5nCCrdPaNJK4a8ejfMUmBL/Ili1zWmB9bQVf9hifHwEDS2FpD3PS4a4h7Dbc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7dd90f2-01be-4164-cf0e-08db1a7328e2
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5711.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2023 16:36:51.6008
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dTLKxMJm+nE4kZN2jiUY9kOWidHT+8G3VCstMy/vD3I9+F+HIeixBdG55ftSNmMc5ip7SM6mi5bFoRRzmH7cghzHi+ibiw6+/kODjr2lTUE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5108
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-01_13,2023-03-01_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 mlxscore=0
 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2303010137
X-Proofpoint-ORIG-GUID: 2znkJpUJNTzNnvzYx2e8g0v2MZClPBwo
X-Proofpoint-GUID: 2znkJpUJNTzNnvzYx2e8g0v2MZClPBwo
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Wed, Feb 22, 2023 at 04:33:12PM -0800, Anthony Yznaga wrote:
> For multithreaded jobs the computed chunk size is rounded up by the
> caller-specified alignment. However, the number of worker threads to
> use is computed using the minimum chunk size without taking alignment
> into account. A sufficiently large alignment value can result in too
> many worker threads being allocated for the job.
> 
> Signed-off-by: Anthony Yznaga <anthony.yznaga@oracle.com>

No effect for now since the page init code uses the same align and
min_chunk, but it protects future users from this problem so

Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>

Thanks.

> ---
>  kernel/padata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/padata.c b/kernel/padata.c
> index e007b8a4b738..4abc536ecdb1 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -491,7 +491,7 @@ void __init padata_do_multithreaded(struct padata_mt_job *job)
>  		return;
>  
>  	/* Ensure at least one thread when size < min_chunk. */
> -	nworks = max(job->size / job->min_chunk, 1ul);
> +	nworks = max(job->size / max(job->min_chunk, job->align), 1ul);
>  	nworks = min(nworks, job->max_threads);
>  
>  	if (nworks == 1) {
> -- 
> 1.8.3.1
>