From:   Eric Snowberg <eric.snowberg@oracle.com>
To:     jarkko@kernel.org, zohar@linux.ibm.com, dhowells@redhat.com,
        dwmw2@infradead.org
Cc:     herbert@gondor.apana.org.au, davem@davemloft.net,
        dmitry.kasatkin@gmail.com, paul@paul-moore.com, jmorris@namei.org,
        serge@hallyn.com, pvorel@suse.cz, eric.snowberg@oracle.com,
        kanth.ghatraju@oracle.com, konrad.wilk@oracle.com,
        erpalmer@linux.vnet.ibm.com, coxu@redhat.com,
        keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org
Subject: [PATCH v5 1/6] KEYS: Create static version of public_key_verify_signature
Date:   Thu,  2 Mar 2023 11:46:47 -0500
Message-Id: <20230302164652.83571-2-eric.snowberg@oracle.com>
In-Reply-To: <20230302164652.83571-1-eric.snowberg@oracle.com>
References: <20230302164652.83571-1-eric.snowberg@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U8RQtdChm/5NpJ6o34joXUvorbhr6WJQzC4SG/H7cuVVPtisOcqM72K/hrHr?=
 =?us-ascii?Q?9rn5lFKy1e7hCc9ktJIFlrXwJjjtxssN8VHPV2S7r6bVQTwlSTPCbIH2FuTf?=
 =?us-ascii?Q?SChp0PvpJF83gpGRmpSW8GLoWf5V+FSeklY6mJgRe19yzmot8TRwK7svxOQj?=
 =?us-ascii?Q?mqbBD6ybYGUZ72jVcBwwf+M3FgW1xsfC8PEIr11RbaPCcZUalu2sbA6k+oqf?=
 =?us-ascii?Q?mYSuhpLwbww3IYhnPDjo25wUZq/cYKxCN0hrk5gAjkKVOX3SnVqXwRLvAxbi?=
 =?us-ascii?Q?IZg028ujwoukz+2PqRhSNxl58nWCahr0MPd3ryXhiX0VA7wbPe2a1XzBKXRk?=
 =?us-ascii?Q?1CUQE5F7k/OrDwhsKdVI3mkwj797fBFh6Rf14Vs5HBm2N9/GW6+39HUi3iaJ?=
 =?us-ascii?Q?CVFCEYdw9NM3Poekx9qeUsKZMW2KSOGtR87qtpEbL/n627Tk7vziyHZeTS8R?=
 =?us-ascii?Q?O0MRGrN9pqXPbzjOo4tCvYfChzOBE8uVqkTrFMGDToiQPgs7xbUTSgQaX31/?=
 =?us-ascii?Q?4J79fwepBA6ZcgjLdyZK3NSkWI1wGSF4u0GVmfTdwULXEb66A5cVmiiSxX/b?=
 =?us-ascii?Q?cD3EJyvMYG/eCyd8Dqoa/G6wcLl1er+i+37dknget+ir+Ny1c/Wu8XQJkQY4?=
 =?us-ascii?Q?d05PiOqvpectOiL0NpI4tArj+EASiwAjgD+KMu1ey8UDdafeEHxGWMpjPVA2?=
 =?us-ascii?Q?tVWK6HHbEKBulCsYxq2JzVo6e3+MNdtiB1PDdpLLEB4lduiiTT4XkGoSZKWg?=
 =?us-ascii?Q?UoGYfubFhGb/5TTKsVSDvXlBdZkN1YKILlswDHF7ndG17j1PY/DzVvEA8NwZ?=
 =?us-ascii?Q?8Fmms5Gi7Z3K0mVwccCTP3vQwzf/8g0U7bPNdYAXbIqpEggcJi8nX61DOpuE?=
 =?us-ascii?Q?b4GsN4J8cu67MInnlEduZiJplvX0e5I5HxNMsM8rK7J05JkrhpJe8dHhOrut?=
 =?us-ascii?Q?Sa7m22bzlTkLtQKTOUqUkvl0XU9Ct+NOPGe9wmCnSWMnHxJ4V3LwOkfHPIVv?=
 =?us-ascii?Q?YrgE1uSAXzxn/xDSb5VkfchYnclEZsB8SwRS7VxOlJvZ3Tktj02YNc7E0RjT?=
 =?us-ascii?Q?/fPEUFxD2iOtH0B5xKV0BqfY3hNrxEKC19RygTYc8b6ZV8D+v/RLdkozEZG4?=
 =?us-ascii?Q?mC/eCn9ekN9sYb0TZjHtIaUadeSP2TAkH1LnQfDIGemgKKqt29joIUmLY4kX?=
 =?us-ascii?Q?E74UN+nH/Zvvi6unAYNoO4P0/JLOpfWgszpvMOKr2FHYL9/p3DPrF3BUXWkx?=
 =?us-ascii?Q?jiHQbp3552wvMbNZZjt08qFNXYMvDIYShsKn6sQLOa6vzVSBRPt3/Ex4J6iq?=
 =?us-ascii?Q?IaYHmZUJiDmqSOsdTAuu4eWcDQ4z0CMkRX3toftWO+wec81Kaf8I6LC3DF26?=
 =?us-ascii?Q?LjbGiy1qmc0JGn1IBFaIzhWCtmiNmikBpKmk4PIz1jbsXci8sxO2kagTQto5?=
 =?us-ascii?Q?H5impAPHDsaaUfdfFxZweM73+bFeVuHhmYzAn3NqCL63r80qpHB0lwEw5lLU?=
 =?us-ascii?Q?o7C6BeFIc+SrNNvvELGtvB+FiaWigwpo321Evy5v/q0P+rHaLffHq4+YtCfy?=
 =?us-ascii?Q?3XHxgalFV81VkcJyzI9J3Xm+px6tUYwGN9133BaDtcSTGs/7Eisoob16rGr8?=
 =?us-ascii?Q?QE47kto+VrdzJeB0g0jgDcY=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?XoClScFGop0m2jyYkig76aqGZe29+X/Y6GgPyDwJyXVy/0AF7D14Z50LfXc/?=
 =?us-ascii?Q?2ceZuDhVzRzph/fVRyUO95i16dy5E686d+DbQzGZPdUzedqPXxgxfFwylX6T?=
 =?us-ascii?Q?2VbbSmFU0csGO53LoNRV9JQ0vc89dKXh/dsIZx4RGjVxJuBpsuUaRdL3UF+z?=
 =?us-ascii?Q?eD91awePb9QV02j6Ygih1PLZaLuGYuvGrzODox5RiQoVZ+hLCdtrVJFebpZ7?=
 =?us-ascii?Q?sIvwTtMvQw/VxudzkWdj/cv4yBJuP2nXAmmRo0KfHrB7anRyRoswdUQAb4wG?=
 =?us-ascii?Q?kduoBWBSMwSzjSYvQjNNgNcXfflOr6ptomBn7IX1H9fbXnLYKNwIrOfBhcoh?=
 =?us-ascii?Q?CT9evlG/098bcftRnfz/mbDFZkh0nX5IZ7l/5q6E0OReV62Z733B5LmlX63d?=
 =?us-ascii?Q?shDBfcLDItBvPjkSYFbkEgWs5kfejU0Q66xSBwTFR7mmli/gcoXJpzfJJzjU?=
 =?us-ascii?Q?N24SslnPD4JPUql9mFvOH1KjDbLctQWHL6f8iE1iIWoJGYKn8YtPFltbcr3O?=
 =?us-ascii?Q?Ay/VO2zbRrLleVq7jsZ1ICfwkbj7uZxtqMELsWLrRFE2bCA8XYju0VN/g+ff?=
 =?us-ascii?Q?4GayKfhtVyTvlOy7xotwsTGowWBnu8T7GxeycXzBwgTGyJ94tqxuiOk1+Ci1?=
 =?us-ascii?Q?GGcfKy9RNGnkbFCkC+OvnqYleCwJl19+Ycc5I3heiMxDMX5z/5WEtTkbcI8Y?=
 =?us-ascii?Q?4vwgZqu3kwDz+h8ecfnX+79HZ4eGfKwqEt1mTYNNp23WEQjzf39nD6CjTIxC?=
 =?us-ascii?Q?1cA8CGNADdC4hrhAJg/3XYkkJwE7TeQumo8FsmZMYqrkGQcQyl5+C56LtOlw?=
 =?us-ascii?Q?/YgV64lafABB62Ta55BAu5z6ZgLejPgwaxDDPiy1a4bjgCwF6NSnK2bGnNYX?=
 =?us-ascii?Q?D9TRqNIfxMQLkOXXpDKkc1v8gWRhp2sBs84X5fjMlDcIdo/LOEA2oKucMDYa?=
 =?us-ascii?Q?/SjlWtkpRv10PnZDpnLfXIxW5ARzRNioS9aRhuFDG8FmNW495QqJRrs0pcwE?=
 =?us-ascii?Q?yEaGd4BOHlrZaZDztMq+MxOr4TOf4b+vYe2uYaMw/IjgvYm5w7FD/xitXA6L?=
 =?us-ascii?Q?Xsg1MhHkxDZpdfajdX6s2f+fq4DEhxW8xBr0lAruK6IS7dAkl/9rpzjtNef6?=
 =?us-ascii?Q?lA9Slvl0ug6lyFluFExkT/e6krxkfM2uPeeNfs+A1Sh/FccJurSYg2g=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8932a5c5-106b-4497-e74e-08db1b3db8b0
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4150.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2023 16:46:50.9706
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XotLS/yOpdRlcX5/xkblJND64OJ6PeQt6crl6aX0ux8y1pFiIOirsuKVVj0Xgf8Q0loiMFDLM9YoF9dI+YquovNWQg9IKCPsKi+xU65ev74=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6357
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-02_10,2023-03-02_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2303020146
X-Proofpoint-GUID: pZwDn_-T_ltIMFrnhgkTyfbtLkxn5jFo
X-Proofpoint-ORIG-GUID: pZwDn_-T_ltIMFrnhgkTyfbtLkxn5jFo
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

The kernel test robot reports undefined reference to
public_key_verify_signature when CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE is
not defined. Create a static version in this case and return -EINVAL.

Fixes: db6c43bd2132 ("crypto: KEYS: convert public key and digsig asym to the akcipher api")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
---
 include/crypto/public_key.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/include/crypto/public_key.h b/include/crypto/public_key.h
index 68f7aa2a7e55..6d61695e1cde 100644
--- a/include/crypto/public_key.h
+++ b/include/crypto/public_key.h
@@ -80,7 +80,16 @@ extern int create_signature(struct kernel_pkey_params *, const void *, void *);
 extern int verify_signature(const struct key *,
 			    const struct public_key_signature *);
 
+#if IS_REACHABLE(CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE)
 int public_key_verify_signature(const struct public_key *pkey,
 				const struct public_key_signature *sig);
+#else
+static inline
+int public_key_verify_signature(const struct public_key *pkey,
+				const struct public_key_signature *sig)
+{
+	return -EINVAL;
+}
+#endif
 
 #endif /* _LINUX_PUBLIC_KEY_H */
-- 
2.27.0