Message-ID: <32f6e47e-453d-3f8b-84b0-a9b7590cd19e@amd.com>
Date:   Mon, 6 Mar 2023 16:31:57 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH RFC v8 08/56] KVM: SEV: Rename sev_{pin,unpin}_memory
Content-Language: en-US
To:     Vlastimil Babka <vbabka@suse.cz>,
        Michael Roth <michael.roth@amd.com>, kvm@vger.kernel.org
Cc:     linux-coco@lists.linux.dev, linux-mm@kvack.org,
        linux-crypto@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
        jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com,
        ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com,
        vkuznets@redhat.com, jmattson@google.com, luto@kernel.org,
        dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com,
        peterz@infradead.org, srinivas.pandruvada@linux.intel.com,
        rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com,
        bp@alien8.de, kirill@shutemov.name, ak@linux.intel.com,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com,
        dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com,
        nikunj.dadhania@amd.com
References: <20230220183847.59159-1-michael.roth@amd.com>
 <20230220183847.59159-9-michael.roth@amd.com>
 <86906f29-9853-6e18-6e03-7b689088ed5d@suse.cz>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <86906f29-9853-6e18-6e03-7b689088ed5d@suse.cz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHBVeEx5SXlUeFgvRWM3RjQzdkY1OERWRXUzQUd0WUJya1JxQ3F0NUs2NlZa?=
 =?utf-8?B?MDRrM3krSityNjdqMzBiZllKU2hmWEQrQlBmSFlzWEJjY21rejlacU5JdU9G?=
 =?utf-8?B?TzhsMUVnMnlKeHZvaWpBWklvRkRGMXR2MWVSeDZxUWpibWowa0YvNTg4NFpS?=
 =?utf-8?B?NjNJUWNiUi9TcHVRVWdzbTNIWlRCdlpxcWpmcmRSVmQ2TmlMckN5ZGUvOGkw?=
 =?utf-8?B?d1F1VTNodUNBajhnNEpKOWZOVGZiR3NMbExLeHlzT0M4YXVLNnMvamoxL01F?=
 =?utf-8?B?QWpRMmc4K1A4eUFNT1IwT0JReWN3TVZUSGd2aDBmOWxDVUMvL24zcWU1Q1dX?=
 =?utf-8?B?dWgrTkNJdmdVeG5laTRWRTBXNFZsRmtkbTZYUkJZQlIwTVZqdHd1ZVRJaUhD?=
 =?utf-8?B?ZXhTMVdwTVVvT3VMaS9iTnBLTGVPV1p1ZXJpUUxHL2lFd0hyVEJLbVdYVTIz?=
 =?utf-8?B?dUZFUEg3dk0vcGJ5ZzZUdS9ydlF3a3I0NGZIR2lod0E4TDVMT1JYelVSOVAv?=
 =?utf-8?B?L2V6VjdxWDdtY0RZT2hlblcydHJzcUh2cm95UlNEN296K1dwL09hTjBrRTNi?=
 =?utf-8?B?Y1krQm04aEs4RW1oM2xmRFlCZ3VyVXU0TG9XLzBLOEVuV052eTk0ZHNHdnAr?=
 =?utf-8?B?eXU3Zy9SV1o4ZGVOL3NZYkJDS2IwZTRHS0pZZW9TdkJ4d3pReWZKTTVUNDJ0?=
 =?utf-8?B?aTlTbG1tZWFRR2s2SXcyMHV0UFMrb0dpSm0rNEI3OVRLMFRkQmNGemcva0k0?=
 =?utf-8?B?aWFvK1pEaUJBMW1ia1ZpWWpxVDlaL2xESS9XZWszdGtxL1l6cjdLeUFVWUVo?=
 =?utf-8?B?elRxVkwwYVBQZW1rVS9yWnVZN3EzWEdIYk16WjR4MmdqWmx5akxPYU4yVW1D?=
 =?utf-8?B?RjY2TVByVy9BbzlWMWllemJEazhaejhuTXFoYW9uOEVSVTJBR3hQZkFDYmxS?=
 =?utf-8?B?NFZudWVVR2l3OE5qRi80TzhtRUFLVzJscDAva0Q4Mkg0M2ZPa05JRGlWMUoy?=
 =?utf-8?B?b1dOOWVyUk9SQlkyeFpUbHNrOFpINE5NS1FDam9zM0dQNGhPa3FCaHY4OThj?=
 =?utf-8?B?MDNCbkI3VWQ3Z0psbjJ3OVN6dmh5RTVvZ2hvOW1QQzF4eFhJUEhCd213MHc5?=
 =?utf-8?B?LzFva0pJbkUzOXFCTHlSekJvN01JTEQxdno4eGp3Tk54dHhubkhFb2MyTUZ6?=
 =?utf-8?B?eFFmMmRsOVU2VFhiV296YzI4RDRIeUJqbmo5VTlDRWVxc3dNODFqYnVFS1Yv?=
 =?utf-8?B?NWUySS9NemJpRXVjU0h5dmphb25OMm5nVFAvYUFQWUQ5SzVMeHJkelphMFIy?=
 =?utf-8?B?M253N0wxUFN1bngvMEs3czdvMG13bTZHNGF4Y3Joak1IcDJvMVZSRXRJaitJ?=
 =?utf-8?B?b2x0YUV3K0FSTXQ3RUE0aHJsQkt1Uzg5eXl0Nk93dCtYeFltVmpJU2llMWNw?=
 =?utf-8?B?bWZjNUxyVUJXV2k3WTBKV3hpL0hyRGpZWnR3Y2RmZ3BVSjVYOHVQWVBMTFR2?=
 =?utf-8?B?clkzVmxSUGhlVXFPYSt3MkpSbWNaYS9XR1dCSWFkUjdCSlUrR0RQSlFyVStH?=
 =?utf-8?B?YllGR2pwNDRXU25rckFaWk43cHlTS0hCYkpsQVFjYk5lQ1kySklxNXJQdng5?=
 =?utf-8?B?bUpPRS9yK2JHRm1Nc1lNSFJmalpwbFFJaDl4Z0dMUDJTMjA3OCttQWlybUF0?=
 =?utf-8?B?R1ZXUWl4bVVTS05ROGFtWC9FNXZqclI5bEV3eWIraFhkMjEyWWV4UjNpTnc4?=
 =?utf-8?B?TnRMS2kzYTZXN21UYlJ1NWJrdFlrTnhZYTdkNTF6eUQwM2xWU0greFE0ams0?=
 =?utf-8?B?NGRaWlR1T05aejlWTUdHN09iZXNiaS91WlNKZVQxNncxVEJIN3lRZHFCSXpo?=
 =?utf-8?B?RlEyVk5SUWxVNkdzSm1kSk5VdWNXSnptamZrS01sdUh1Wk9ZSSt6aTd2S1d2?=
 =?utf-8?B?dW5Zb0lOOVlFaDZUOEloaXE5UTVQYUo5VmVIM09EM3lKUVlJb2lZY1VwRVRi?=
 =?utf-8?B?VjN3TjBUVzVVSkcyVHJaaTdQY3RtcGlSQ2RxcnRMeHY0OGlTenZCV09xaTVF?=
 =?utf-8?B?SUNQZ1dKcFlFNFg4N2lQYitEKzJvdVhBS2NRUzZURUxyRXNWSTN5TDFURVd3?=
 =?utf-8?Q?5znL+RQLAVw0R3m3QaecMWpCq?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5d5d64c-f626-4625-1f17-08db1e32417c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 11:02:20.4523
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NFvV9s5ypd0RBSe54ZrZkYs/SYJKgh8BSYUiW8f8Px3r/cPUi0GmQ23XnPh+b0IsAcIy+GlND7L5v/c2Aa3AKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6378
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 03/03/23 19:30, Vlastimil Babka wrote:
> On 2/20/23 19:37, Michael Roth wrote:
>> From: Nikunj A Dadhania <nikunj@amd.com>
>>
>> Rename sev_{pin|unpin}_memory to sev_memory_{get|put}_pages. Apart
>> from pinning the pages, sev_pin_memory also populates the pages array
>> which is used by its callers. SEV guest using restricted memfd do not
>> to pin the memory but will require the pages array to be populated.
> 
>   ^need to?
> 

Sure

Regards,
Nikunj