Message-ID: <c44caf95-6fe5-c336-e47e-d624e9c27054@intel.com>
Date:   Tue, 7 Mar 2023 05:43:31 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH 01/16] dmaengine: idxd: add wq driver name support for
 accel-config user tool
Content-Language: en-US
To:     Tom Zanussi <tom.zanussi@linux.intel.com>,
        <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
        <vkoul@kernel.org>
CC:     <dave.jiang@intel.com>, <tony.luck@intel.com>,
        <wajdi.k.feghali@intel.com>, <james.guilford@intel.com>,
        <kanchana.p.sridhar@intel.com>, <linux-kernel@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>, <dmaengine@vger.kernel.org>
References: <20230306185226.26483-1-tom.zanussi@linux.intel.com>
 <20230306185226.26483-2-tom.zanussi@linux.intel.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20230306185226.26483-2-tom.zanussi@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzQzTk4yYWNZM3V4azBYL0R5TkdmNDdlSGIzWDRrR2ZwTjZHbk9NMTRRYnZh?=
 =?utf-8?B?d2xNbGdBcnRISzBidldQcmdXdHdJRncyM3JISmozb0xHNnpWTTdDS0lEWFU2?=
 =?utf-8?B?RFpHekxSVXc3RzloWXpUY3gxYnBYcDY1L2NzcDZ4S214bkpOWnpPYmY5RVQ1?=
 =?utf-8?B?cmt4SkI4UnpXY09OSS93c28yY1UwUmNkSkpFaFlXTm4zbDFhRkNSOWh2VDZU?=
 =?utf-8?B?WC9tYXdBcU1tVitvRGxFZFZwTzRUQXhSM2RUQW8vcTZPV2E3Z3lFTnliam82?=
 =?utf-8?B?eGF4UU9YSEE1MncwTU43ejVQTjhuYUFqOU5oUnB0UHRkSlV4Tlk3QXRPZXV5?=
 =?utf-8?B?Y1FFeUZkZkZRR0J2UzQ3TDlNUHlJc1l2S1VJc0Znam9FRkNQWm1HNVR6TFhI?=
 =?utf-8?B?cFhrT1JGUmx1c2hPNjZYQnhJcURJMGFGSS95R1h4aTMrcmJYNk1LbXp2ckgr?=
 =?utf-8?B?MjQwNEp1Mm1JZzZMdmVGSklyN3ZTQ21hWU1ncjBzbm02Mkl4QUJHc2hUSWpT?=
 =?utf-8?B?a3hxWUpyQk1SaEU5aHJLYmRxT3ZIMGtyb2RhRHptTVlOS1k0MlFxMXkvbXhC?=
 =?utf-8?B?aEcxb2RzREhveUZ3ZzBoK0lhcEEvUmVTR0NPSjdwalhYR2ZmVDZ2V0Y0MTln?=
 =?utf-8?B?bmRHR2NjUTdKZHJKUDlscDVqeTZSVjNET0RIeUI1cVI5UDBQZEJIc2FxNlRE?=
 =?utf-8?B?UmNwQ1dOdHk3bkhhZ0VsbHNKR3ZxQ2JXWE1QNW12d3BpWisxMHpCbXZzUEtR?=
 =?utf-8?B?cUpPTkJOb3RPNkpTOElSUFdlN05QdXlRWUUzWTNHV2tJeGFSVldNV1VvQkNh?=
 =?utf-8?B?bTcza3Z2M25TZG9mcmJzL0p2eGo0aFRxK3M2NVhsdkVKNW1WNm5IWnBnRnEv?=
 =?utf-8?B?RUZiRVJGZ1BZamQyUC9XYVNaeGozMEFBd0NqckNMM2NlUm5BU1JrSkE3dE9h?=
 =?utf-8?B?VEl3NSsvd1orV3JpaTZJZ2ZXaE5mOEIwS0FSYlJqUzRDRFh4RGN1WnpKMEh0?=
 =?utf-8?B?RmZKdWhiTGNKVmFWL20ySzdaamJUSTJkOUJyd3pxN3pnT2xwcVFYOTkvZllP?=
 =?utf-8?B?c1hvakxGV01FcnRBZU5QWU0razdLdEZUK3VRRjdtTC85bWphR0pmWEdsb1h5?=
 =?utf-8?B?TlVaMytGTm9PRVE4WWlIMllzVUhvenpYOTg2NnJLUXA4OEdGOEFzVlJOTmQz?=
 =?utf-8?B?RTRJNXJ1UTIvb3VNaitOQ1lONUNFUzFqZ3p0QlhsaERQZml2WCtNMmtCL1ZK?=
 =?utf-8?B?V21rSTVsTDBQOW1CTm44bkw1SUxxTlNiNEEyR1RDUW9nSW5jZVpGaURXZXpH?=
 =?utf-8?B?SXU4WG1qdHMzakJUODNGaFN1aHMyc3daUVBXNGpXb1FZaFZ1clo4OFQ5dlRN?=
 =?utf-8?B?NjdURXU3dWZwbnd2RXlicEI3aWZsV1pZUHJlcDROU1hESnZKbFN4WUdVM1Fn?=
 =?utf-8?B?RkVyYkE4VjJnbmNNRXpmSStBK0psV3luZEtIVnIyY0RzaXR3M2hucGEyWjFm?=
 =?utf-8?B?KzE0dmtrWUFMN0dYc3RKZ041YWZGelRUWjJWb2xUVmRvWUR3OElGMGN1ZVBq?=
 =?utf-8?B?MFRwdFpXQ3FZQjl3Q1JrT0VFaWhYUEl2T0RUTkdFUktxY0I2eEgwN1gzTUgv?=
 =?utf-8?B?TThGbkJ2MDgzaFBzWE9ibjNXWEFGcHBtSEYybW5QUDN2VzlUSStNejJWcXIx?=
 =?utf-8?B?L01halVuMjNLUzZubk4zYnVSSXh1VW1qbm9GV0MveVVtMmVuWHJ5RjhqbjAv?=
 =?utf-8?B?YUxZYjF3NjVtNlVGeXNNVzVyWi9RRW5aajhzLzhIVkVxQ0tJeDF4YnJtd2Vr?=
 =?utf-8?B?YzFaTm8xRmt2bFZJQzg3YkNxZ3d6dHMwYXpkdVZ2SHZWSGZtRG5LeGpmeHJ4?=
 =?utf-8?B?T2FzRnBWclpTREFFY0RMRmV5V0xvdmhSenBYQUxrOHUzM0lVOE9EMml2VEpm?=
 =?utf-8?B?ZEJsZkdFWWRzZnRuendhQitFMkpnZzJHZWhoZnpLbWhFN0p0UHhsL2JIa2Mw?=
 =?utf-8?B?eXZlekQ1elVjNnM4NGxiVXE4L3IrNnhhM3VnWVVJYlRmUkpEamV4b3NYcXd4?=
 =?utf-8?B?YmRhYWgzc3ZId0UwakhQdytheDdlZ0VrVDBrYWlPOThSa1RKdFlFVXNZd1R4?=
 =?utf-8?Q?TXCHwwOvki/mrpA6SpS0BPTvf?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 29871bf9-5a16-440b-672d-08db1f11f2bd
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 13:43:35.7334
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z4D2LwRbIMKayIdAV0RfmgvLFPi3MY4cmqnqJIltWa+fVyDX4kN/KbTswIr7st753kidYZEhM9BCDTMDdz+n6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5813
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi, Tom,

On 3/6/23 10:52, Tom Zanussi wrote:
> From: Dave Jiang <dave.jiang@intel.com>
> 
> With the possibility of multiple wq drivers that can be bound to the wq,
> the user config tool accel-config needs a way to know which wq driver to
> bind to the wq. Introduce per wq driver_name sysfs attribute where the user
> can indicate the driver to be bound to the wq. This allows accel-config to
> just bind to the driver using wq->driver_name.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> ---
>   .../ABI/stable/sysfs-driver-dma-idxd          |  6 ++++
>   drivers/dma/idxd/cdev.c                       |  8 ++++++
>   drivers/dma/idxd/dma.c                        |  6 ++++
>   drivers/dma/idxd/idxd.h                       |  7 +++++
>   drivers/dma/idxd/sysfs.c                      | 28 +++++++++++++++++++
>   include/uapi/linux/idxd.h                     |  1 +
>   6 files changed, 56 insertions(+)
> 
> diff --git a/Documentation/ABI/stable/sysfs-driver-dma-idxd b/Documentation/ABI/stable/sysfs-driver-dma-idxd
> index 3becc9a82bdf..e9a37e064193 100644
> --- a/Documentation/ABI/stable/sysfs-driver-dma-idxd
> +++ b/Documentation/ABI/stable/sysfs-driver-dma-idxd
> @@ -244,6 +244,12 @@ Description:	Shows the operation capability bits displayed in bitmap format
>   		correlates to the operations allowed. It's visible only
>   		on platforms that support the capability.
>   
> +What:		/sys/bus/dsa/devices/wq<m>.<n>/driver_name
> +Date:		Feb 23, 2023
> +KernelVersion:	6.3.0

Need to change to 6.4.0. This series won't be in 6.3.0.

> +Contact:	dmaengine@vger.kernel.org
> +Description:	Name of driver to be bounded to the wq.
> +

Thanks.

-Fenghua