Date:   Thu, 9 Mar 2023 12:57:07 +0000
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
CC:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>, <qat-linux@intel.com>
Subject: Re: [PATCH 1/6] crypto: qat - drop redundant adf_enable_aer()
Message-ID: <ZAnXoysp8IPjoYmR@gcabiddu-mobl1.ger.corp.intel.com>
References: <20230307161947.857491-1-helgaas@kernel.org>
 <20230307161947.857491-2-helgaas@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230307161947.857491-2-helgaas@kernel.org>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NpmRyIG81BQQOwbzJD0NrN9DIR6iueWxCrpCtPFR3RQnF9p2o9cKnrHyemT3?=
 =?us-ascii?Q?fwyft7/3kU34dSX3/HV6y+Lhv5iZ1kpggbEFhS4Z/jnePHRbZ1a6xP2pPeG2?=
 =?us-ascii?Q?ifZLMcbZZVI+NKfAeQRifSnD8x+jq/gPtbz2U2rFh+IE74297LP1NAB9ybb3?=
 =?us-ascii?Q?5fxl39WDzHyeRs3/4Ws3jt+WeBiQu2HyIvFL5jUoohgWkuNJhLIn8SMZrarj?=
 =?us-ascii?Q?axkwVLlu3EWS+C7CiB9cVt5WaHj6bC5Bw0f3jUMPdSwomgXE8HgPioQZoEiE?=
 =?us-ascii?Q?hlguI2K2DH4vPgBgVQhGgGn93Kmg7f114sfPz+N/tApLd4+xUhf1sZPWhF5f?=
 =?us-ascii?Q?fYhmNUwRBtRWKSv5Wbh1NaUmVilaoRfaXdMQJqTeATUtTJYvRC5CKUrLqe0B?=
 =?us-ascii?Q?WUyJgJ6vBBYAinxHhI6EdHff06rc4VS8A7P9fCGFmqBoUI4d1Bp7ckm3swYC?=
 =?us-ascii?Q?E+56zd93+kTA9Hlm7Uj3o4qiV8aNytFJXB7lDrm/okfVOInciljdKKjlzmLM?=
 =?us-ascii?Q?zOHEyIKTxXjO/Y1VSJpvCTkfDN4QkeCkZn7qVGgIPcXryUNJUhymKx2PRbjv?=
 =?us-ascii?Q?boH5zNwnpJbxHGKmVuArFpe66poi4rpmHR+axQ2wuF4dF8c/uqYX6QFkchpe?=
 =?us-ascii?Q?6p4ZE/YsXpBmD58yoqJgSXSA4fheYZ7Fag0qCbVfRrMnRUTloCzo9DSRCSB+?=
 =?us-ascii?Q?5QxIKgNyYPPt4JH+TfTnaLQMNC15Nffx7Ebkj2mybPcDoQRHCiMNVOKMFi4G?=
 =?us-ascii?Q?zRApCrUV/fhcWN6A26zH/5Kgc1+efsFMQz6pOKb7Wj3ZifdbrxL9myj0NfJv?=
 =?us-ascii?Q?yyNIQlJK3rpGMMlpP5Bffkzpg8AQHsI1sWpxQeuFwbKVm4jAhrd2HLZ9KlP0?=
 =?us-ascii?Q?yjrE811Y720p9pNfbxxBokfDMakmGYU0ARfapuaYN5MV5XJ8Nm7l+pHeT3GL?=
 =?us-ascii?Q?jL2/ExnhIQSrvlTvT0AuXuDL90K2+F6ZLGmrKdCFnZTv5vQZUUsAzbGgkZcN?=
 =?us-ascii?Q?UCY/L/JRiE6tJ9VksAlErfmqw+95IictWIglGf029wzDYOVuhewl5vLFGM/c?=
 =?us-ascii?Q?DBnQrWnNuqqvVOx/sBrBvv0e/Ai2Yzsy8pEcwss9NGjRVsmuDTZ8vk6ahLOd?=
 =?us-ascii?Q?DDTfQv/hMs0L5Z7fhxE3Qdmklte0i8g/L0dNEXLguGXT57i4iCyR9VkYsYfd?=
 =?us-ascii?Q?QmS5KWJkuZZYC+AWCAQddUW5GV4IQ3ESqIqhxZvEFPen35a0qTHZGCWfB4IM?=
 =?us-ascii?Q?2Vh8pDeAci1BFSiuyeYac1v3goEOeJzfQHWkiHS7a+OnIMTmVODlG/daNGOH?=
 =?us-ascii?Q?iqNrCEqCv/1aVLJbtKsl4tjU6vHxl4bRYDGArqSOZGuff4n1S67tRZwWucI8?=
 =?us-ascii?Q?a/CY7rXb3YSoHTDSio+cjdKQUzi54JHrAc4HDHBu/YfYoBWo2cLI6EwvvTYR?=
 =?us-ascii?Q?V5iBXRMYKxqbxlbKSP7qBuP8tQchJQK8qwdCuTNGQCk4rJtiPRRfLlu+wBh7?=
 =?us-ascii?Q?kdKJ0mACtmbVjpsCAiLJSeo+SisR9z3Uh7yehJIvqj/5u2WBqoUvaQnQioi3?=
 =?us-ascii?Q?QUQbKlFKOb1K1ADnqT064MCXdXZya/zQ3r52R3UEvpLpzOW2hlNsh2WDWpEg?=
 =?us-ascii?Q?zQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bb5348ff-cd9b-4441-0efc-08db209dd345
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 12:57:23.0793
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I3G96o565Uewij8GY3HppcMHFsg7v9SIynYC1yf6Lm+uQM1LEf2XlXuSuc5mfUF6VWnh92yLXROdeVmd1WUad+d1WCgPydub1mWT7GKvdtU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5146
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Tue, Mar 07, 2023 at 10:19:42AM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration, so the
> driver doesn't need to do it itself.
> 
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
> 
> Note that this only controls ERR_* Messages from the device.  An ERR_*
> Message may cause the Root Port to generate an interrupt, depending on the
> AER Root Error Command register managed by the AER service driver.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> Cc: qat-linux@intel.com
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Reviewed and tried on c62x and 4xxx.
Just a note. This patch will not apply cleanly after [1] is applied.

[1] https://patchwork.kernel.org/project/linux-crypto/patch/20230227205545.5796-2-shashank.gupta@intel.com/

Regards,

-- 
Giovanni